From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>, Gary Lin <glin@suse.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] NetworkPkg/TlsAuthConfigDxe: Declare EFIAPI for the ChooseFile handler
Date: Tue, 17 Jan 2017 04:49:06 +0000 [thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B727416294456@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <B1FF2E9001CE9041BD10B825821D5BC58A8D15C8@shsmsx102.ccr.corp.intel.com>
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
> -----Original Message-----
> From: Fu, Siyuan
> Sent: Tuesday, January 17, 2017 11:47 AM
> To: Gary Lin <glin@suse.com>; edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: RE: [edk2] [PATCH] NetworkPkg/TlsAuthConfigDxe: Declare EFIAPI for
> the ChooseFile handler
>
> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gary
> Lin
> Sent: 2017年1月16日 14:30
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH] NetworkPkg/TlsAuthConfigDxe: Declare EFIAPI for the
> ChooseFile handler
>
> The ChooseFile handler, UpdateCAFromFile, has to be EFIAPI or gcc would use
> the wrong ABI and cause the crash of the firmware. This commit also removes
> the unnecessary type casting in ChooseFile.
>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
> b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
> index 5f04503887..fedfb01be9 100644
> --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
> +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
> @@ -1218,6 +1218,7 @@ UpdatePage(
> @retval FALSE Not exit caller function.
> **/
> BOOLEAN
> +EFIAPI
> UpdateCAFromFile (
> IN EFI_DEVICE_PATH_PROTOCOL *FilePath
> )
> @@ -1728,7 +1729,7 @@ TlsAuthConfigAccessCallback (
> CleanUpPage (LabelId, Private);
> break;
> case KEY_TLS_AUTH_CONFIG_ENROLL_CERT_FROM_FILE:
> - ChooseFile( NULL, NULL, (CHOOSE_HANDLER) UpdateCAFromFile, &File);
> + ChooseFile( NULL, NULL, UpdateCAFromFile, &File);
> break;
>
> case KEY_TLS_AUTH_CONFIG_VALUE_SAVE_AND_EXIT:
> --
> 2.11.0
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-01-17 4:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 6:30 [PATCH] NetworkPkg/TlsAuthConfigDxe: Declare EFIAPI for the ChooseFile handler Gary Lin
2017-01-17 3:47 ` Fu, Siyuan
2017-01-17 4:49 ` Wu, Jiaxin [this message]
2017-01-18 5:00 ` Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895558F6EA4E3B41AC93A00D163B727416294456@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox