* [PATCH] NetworkPkg: Remove superfluous return statement.
@ 2017-01-19 9:37 Thomas Huth
2017-01-20 0:39 ` Wu, Jiaxin
2017-01-23 2:35 ` Wu, Jiaxin
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2017-01-19 9:37 UTC (permalink / raw)
To: edk2-devel; +Cc: Siyuan Fu, Jiaxin Wu
If the code eventually returns "Status" anyway, it does not make
sense to explicitely return "Status" in case of an error, too.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
NetworkPkg/HttpDxe/HttpsSupport.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c b/NetworkPkg/HttpDxe/HttpsSupport.c
index 77e5371..f0077dd 100644
--- a/NetworkPkg/HttpDxe/HttpsSupport.c
+++ b/NetworkPkg/HttpDxe/HttpsSupport.c
@@ -1294,10 +1294,6 @@ TlsCloseSession (
FreePool (BufferOut);
NetbufFree (PacketOut);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
return Status;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] NetworkPkg: Remove superfluous return statement.
2017-01-19 9:37 [PATCH] NetworkPkg: Remove superfluous return statement Thomas Huth
@ 2017-01-20 0:39 ` Wu, Jiaxin
2017-01-23 2:35 ` Wu, Jiaxin
1 sibling, 0 replies; 3+ messages in thread
From: Wu, Jiaxin @ 2017-01-20 0:39 UTC (permalink / raw)
To: Thomas Huth, edk2-devel@ml01.01.org; +Cc: Fu, Siyuan
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
Thanks,
Jiaxin
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Thomas Huth
> Sent: Thursday, January 19, 2017 5:38 PM
> To: edk2-devel@ml01.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH] NetworkPkg: Remove superfluous return statement.
>
> If the code eventually returns "Status" anyway, it does not make
> sense to explicitely return "Status" in case of an error, too.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> NetworkPkg/HttpDxe/HttpsSupport.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c
> b/NetworkPkg/HttpDxe/HttpsSupport.c
> index 77e5371..f0077dd 100644
> --- a/NetworkPkg/HttpDxe/HttpsSupport.c
> +++ b/NetworkPkg/HttpDxe/HttpsSupport.c
> @@ -1294,10 +1294,6 @@ TlsCloseSession (
> FreePool (BufferOut);
> NetbufFree (PacketOut);
>
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> -
> return Status;
> }
>
> --
> 1.8.3.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] NetworkPkg: Remove superfluous return statement.
2017-01-19 9:37 [PATCH] NetworkPkg: Remove superfluous return statement Thomas Huth
2017-01-20 0:39 ` Wu, Jiaxin
@ 2017-01-23 2:35 ` Wu, Jiaxin
1 sibling, 0 replies; 3+ messages in thread
From: Wu, Jiaxin @ 2017-01-23 2:35 UTC (permalink / raw)
To: Thomas Huth, edk2-devel@ml01.01.org; +Cc: Fu, Siyuan
Commit:
https://github.com/tianocore/edk2/commit/f3fa35a00233b6f2e7653b3b8c3e2b28b8ecbe7f
Thanks,
Jiaxin
> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Friday, January 20, 2017 8:39 AM
> To: Thomas Huth <thuth@redhat.com>; edk2-devel@ml01.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>
> Subject: RE: [edk2] [PATCH] NetworkPkg: Remove superfluous return statement.
>
> Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
>
> Thanks,
> Jiaxin
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Thomas Huth
> > Sent: Thursday, January 19, 2017 5:38 PM
> > To: edk2-devel@ml01.01.org
> > Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> > Subject: [edk2] [PATCH] NetworkPkg: Remove superfluous return statement.
> >
> > If the code eventually returns "Status" anyway, it does not make
> > sense to explicitely return "Status" in case of an error, too.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > NetworkPkg/HttpDxe/HttpsSupport.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c
> > b/NetworkPkg/HttpDxe/HttpsSupport.c
> > index 77e5371..f0077dd 100644
> > --- a/NetworkPkg/HttpDxe/HttpsSupport.c
> > +++ b/NetworkPkg/HttpDxe/HttpsSupport.c
> > @@ -1294,10 +1294,6 @@ TlsCloseSession (
> > FreePool (BufferOut);
> > NetbufFree (PacketOut);
> >
> > - if (EFI_ERROR (Status)) {
> > - return Status;
> > - }
> > -
> > return Status;
> > }
> >
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-23 2:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 9:37 [PATCH] NetworkPkg: Remove superfluous return statement Thomas Huth
2017-01-20 0:39 ` Wu, Jiaxin
2017-01-23 2:35 ` Wu, Jiaxin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox