From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 10EA981E9C for ; Thu, 19 Jan 2017 16:54:14 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP; 19 Jan 2017 16:54:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,256,1477983600"; d="scan'208";a="55108801" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 19 Jan 2017 16:54:13 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 16:54:13 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Fri, 20 Jan 2017 08:54:09 +0800 From: "Wu, Jiaxin" To: Laszlo Ersek , "edk2-devel@ml01.01.org" CC: "Ni, Ruiyu" , "Ye, Ting" , "Justen, Jordan L" , Gary Lin , "Kinney, Michael D" , "Fu, Siyuan" Thread-Topic: [edk2] [PATCH 3/3] OvmfPkg: Allow HTTP connections if HTTP Boot enabled Thread-Index: AQHSchN2G/UgWyeEVkWMPqytxTNZZKE+8yWAgAGXx6A= Date: Fri, 20 Jan 2017 00:54:09 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B72741629638B@SHSMSX103.ccr.corp.intel.com> References: <1484803083-147376-1-git-send-email-jiaxin.wu@intel.com> <1484803083-147376-4-git-send-email-jiaxin.wu@intel.com> <23d6bd7a-84b5-dc7a-d830-2673d1d5d781@redhat.com> In-Reply-To: <23d6bd7a-84b5-dc7a-d830-2673d1d5d781@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTlmMDk3OGYtYjAzMS00ZjA2LWI5NzEtMTEyMTc4NjlkNThjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImhNZkNBWUxnVWJ5bTZscFl2MlRjczBhd0ExbVRXV2FqRVpkRFZUclVtKzA9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/3] OvmfPkg: Allow HTTP connections if HTTP Boot enabled X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 00:54:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Laszlo, I will refine it before commit the patches. Best Regards! Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo > Ersek > Sent: Thursday, January 19, 2017 4:33 PM > To: Wu, Jiaxin ; edk2-devel@ml01.01.org > Cc: Ni, Ruiyu ; Ye, Ting ; Justen, > Jordan L ; Gary Lin ; Kinney, > Michael D ; Fu, Siyuan > Subject: Re: [edk2] [PATCH 3/3] OvmfPkg: Allow HTTP connections if HTTP B= oot > enabled >=20 > Jiaxin, >=20 > On 01/19/17 06:18, Jiaxin Wu wrote: > > Overwrite the value of PcdAllowHttpConnections to allow HTTP > > connections if HTTP Boot enabled (-D HTTP_BOOT_ENABLE). > > > > Cc: Laszlo Ersek > > Cc: Justen Jordan L > > Cc: Gary Lin > > Cc: Ye Ting > > Cc: Fu Siyuan > > Cc: Ruiyu Ni > > Cc: Kinney Michael D > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Wu Jiaxin > > --- > > OvmfPkg/OvmfPkgIa32.dsc | 6 +++++- > > OvmfPkg/OvmfPkgIa32X64.dsc | 6 +++++- > > OvmfPkg/OvmfPkgX64.dsc | 6 +++++- > > 3 files changed, 15 insertions(+), 3 deletions(-) > > > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > > index e060602..2c38578 100644 > > --- a/OvmfPkg/OvmfPkgIa32.dsc > > +++ b/OvmfPkg/OvmfPkgIa32.dsc > > @@ -1,9 +1,9 @@ > > ## @file > > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > > # > > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<= BR> > > +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<= BR> > > # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> > # > > # This program and the accompanying materials > > # are licensed and made available under the terms and conditions of t= he > BSD License > > # which accompanies this distribution. The full text of the license m= ay be > found at > > @@ -394,10 +394,14 @@ > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > > > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > > > > + !if $(HTTP_BOOT_ENABLE) =3D=3D TRUE > > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > > + !endif > > + > > # DEBUG_INIT 0x00000001 // Initialization > > # DEBUG_WARN 0x00000002 // Warnings > > # DEBUG_LOAD 0x00000004 // Load events > > # DEBUG_FS 0x00000008 // EFI File system > > # DEBUG_POOL 0x00000010 // Alloc & Free (pool) > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > > index 0e24e7a..2760533 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > > @@ -1,9 +1,9 @@ > > ## @file > > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > > # > > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<= BR> > > +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<= BR> > > # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> > # > > # This program and the accompanying materials > > # are licensed and made available under the terms and conditions of t= he > BSD License > > # which accompanies this distribution. The full text of the license m= ay be > found at > > @@ -440,10 +440,14 @@ > > !ifdef $(SOURCE_DEBUG_ENABLE) > > > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 > > !endif > > > > [PcdsFixedAtBuild.X64] > > +!if $(HTTP_BOOT_ENABLE) =3D=3D TRUE > > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > > +!endif > > + > > !ifndef $(USE_OLD_SHELL) > > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, > 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0= xB4, > 0xD1 } > > !endif > > > > !if $(SMM_REQUIRE) =3D=3D TRUE > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > > index 108f7d5..56fddc3 100644 > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -1,9 +1,9 @@ > > ## @file > > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > > # > > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<= BR> > > +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<= BR> > > # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> > # > > # This program and the accompanying materials > > # are licensed and made available under the terms and conditions of t= he > BSD License > > # which accompanies this distribution. The full text of the license m= ay be > found at > > @@ -399,10 +399,14 @@ > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > > > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > > > > + !if $(HTTP_BOOT_ENABLE) =3D=3D TRUE > > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > > + !endif > > + > > # DEBUG_INIT 0x00000001 // Initialization > > # DEBUG_WARN 0x00000002 // Warnings > > # DEBUG_LOAD 0x00000004 // Load events > > # DEBUG_FS 0x00000008 // EFI File system > > # DEBUG_POOL 0x00000010 // Alloc & Free (pool) > > >=20 > thank you for the patch; it looks good. However, for aesthetic and > consistency reasons, I'd like to request an update. >=20 > The placement of the new setting is entirely right in the > "OvmfPkgIa32X64.dsc" file. However, the Ia32 and X64 DSC files don't > follow that placement. Therefore I would like to request the following > two changes, for both the Ia32 and X64 DSC files: >=20 > - please move the new setting just above the "!ifndef $(USE_OLD_SHELL)" > part, where "PcdShellFile" is set, >=20 > - please un-indent the new setting to column zero. (Well, the "!if" goes > to column zero, the actual setting goes to column two.) >=20 > The idea is that all three DSC files should remain pair-wise comparable > with the "diff" utility; any differences displayed by "diff" should be > related to *genuine* Ia32 <-> Ia32X64 <-> X64 differences. >=20 > For the next version, I think you can carry forward the following two > tags from Gary (see his email elsewhere in this thread): >=20 > Reviewed-by: Gary Lin > Tested-by: Gary Lin >=20 > (I'm just repeating them here so you can easily cut n' paste them to the > commit message.) >=20 > Thank you! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel