Re: [PATCH] NetworkPkg: Remove superfluous return statement.

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Commit:

https://github.com/tianocore/edk2/commit/f3fa35a00233b6f2e7653b3b8c3e2b28b8ecbe7f

Thanks,
Jiaxin

> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Friday, January 20, 2017 8:39 AM
> To: Thomas Huth <thuth@redhat.com>; edk2-devel@ml01.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>
> Subject: RE: [edk2] [PATCH] NetworkPkg: Remove superfluous return statement.
> 
> Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
> 
> Thanks,
> Jiaxin
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Thomas Huth
> > Sent: Thursday, January 19, 2017 5:38 PM
> > To: edk2-devel@ml01.01.org
> > Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> > Subject: [edk2] [PATCH] NetworkPkg: Remove superfluous return statement.
> >
> > If the code eventually returns "Status" anyway, it does not make
> > sense to explicitely return "Status" in case of an error, too.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  NetworkPkg/HttpDxe/HttpsSupport.c | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c
> > b/NetworkPkg/HttpDxe/HttpsSupport.c
> > index 77e5371..f0077dd 100644
> > --- a/NetworkPkg/HttpDxe/HttpsSupport.c
> > +++ b/NetworkPkg/HttpDxe/HttpsSupport.c
> > @@ -1294,10 +1294,6 @@ TlsCloseSession (
> >    FreePool (BufferOut);
> >    NetbufFree (PacketOut);
> >
> > -  if (EFI_ERROR (Status)) {
> > -    return Status;
> > -  }
> > -
> >    return Status;
> >  }
> >
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel