From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5A41581EDF for ; Sun, 22 Jan 2017 18:36:04 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP; 22 Jan 2017 18:36:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,272,1477983600"; d="scan'208";a="56986171" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 22 Jan 2017 18:36:03 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 22 Jan 2017 18:36:03 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 22 Jan 2017 18:36:03 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Mon, 23 Jan 2017 10:35:59 +0800 From: "Wu, Jiaxin" To: Thomas Huth , "edk2-devel@ml01.01.org" CC: "Fu, Siyuan" Thread-Topic: [edk2] [PATCH] NetworkPkg: Remove superfluous return statement. Thread-Index: AQHScje19PrWnUkHm0mu18iZ20AEBqFAhtSggATXbYA= Date: Mon, 23 Jan 2017 02:35:59 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B727416296DA7@SHSMSX103.ccr.corp.intel.com> References: <1484818651-26205-1-git-send-email-thuth@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDFkMzg2MmUtNmI0ZS00NTc5LTlhMzktMGUyN2MzNzY2MjEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImpJbkRWa2ZyRUFwN2JLa3lmbTZUc2xRZjNLcDIxN1NjYjBYNGtjNGRLYlE9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] NetworkPkg: Remove superfluous return statement. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 02:36:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Commit: https://github.com/tianocore/edk2/commit/f3fa35a00233b6f2e7653b3b8c3e2b28b8= ecbe7f Thanks, Jiaxin > -----Original Message----- > From: Wu, Jiaxin > Sent: Friday, January 20, 2017 8:39 AM > To: Thomas Huth ; edk2-devel@ml01.01.org > Cc: Fu, Siyuan > Subject: RE: [edk2] [PATCH] NetworkPkg: Remove superfluous return stateme= nt. >=20 > Reviewed-by: Wu Jiaxin >=20 > Thanks, > Jiaxin >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Thomas Huth > > Sent: Thursday, January 19, 2017 5:38 PM > > To: edk2-devel@ml01.01.org > > Cc: Fu, Siyuan ; Wu, Jiaxin > > Subject: [edk2] [PATCH] NetworkPkg: Remove superfluous return statement= . > > > > If the code eventually returns "Status" anyway, it does not make > > sense to explicitely return "Status" in case of an error, too. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Thomas Huth > > --- > > NetworkPkg/HttpDxe/HttpsSupport.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c > > b/NetworkPkg/HttpDxe/HttpsSupport.c > > index 77e5371..f0077dd 100644 > > --- a/NetworkPkg/HttpDxe/HttpsSupport.c > > +++ b/NetworkPkg/HttpDxe/HttpsSupport.c > > @@ -1294,10 +1294,6 @@ TlsCloseSession ( > > FreePool (BufferOut); > > NetbufFree (PacketOut); > > > > - if (EFI_ERROR (Status)) { > > - return Status; > > - } > > - > > return Status; > > } > > > > -- > > 1.8.3.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel