From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2BADC20D77DD0 for ; Thu, 6 Apr 2017 17:33:33 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 06 Apr 2017 17:33:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,161,1488873600"; d="scan'208";a="84416453" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2017 17:33:32 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Apr 2017 17:33:32 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Apr 2017 17:33:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Fri, 7 Apr 2017 08:33:30 +0800 From: "Wu, Jiaxin" To: "Zhang, Lubo" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" Thread-Topic: [patch] NetworkPkg: Fix bug related DAD issue in IP6 driver. Thread-Index: AQHSrrPw9BYSWw+Dvkq2O+zzUIjFRaG5D6zQ Date: Fri, 7 Apr 2017 00:33:29 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274162BE34F@SHSMSX103.ccr.corp.intel.com> References: <1491469089-36756-1-git-send-email-lubo.zhang@intel.com> In-Reply-To: <1491469089-36756-1-git-send-email-lubo.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTZlMmJlMDctNDUxMC00ZGE4LTljYTAtODU0YzNhZmM2ODM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InU0R2FlMEN6aU53S3ZcL213NU1iRjFDUTRvMkhCU3NGbVRrZGZMRWZ0NE44PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] NetworkPkg: Fix bug related DAD issue in IP6 driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 00:33:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -----Original Message----- > From: Zhang, Lubo > Sent: Thursday, April 6, 2017 4:58 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan > Subject: [patch] NetworkPkg: Fix bug related DAD issue in IP6 driver. >=20 > If we set PXEv6 as the first boot option and reboot immediately > after the first successful boot, it will assert. the root cause is > when we set the policy from manual to automatic in PXE driver, > the ip6 Configure item size is already set to zero and other > structures are also released, So it is not needed to perform DAD call > back function which is invoked by Ip6ConfigSetMaunualAddress. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > Cc: Wu Jiaxin > Cc: Ye Ting > Cc: Fu Siyuan > --- > NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c > b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c > index bde5982..7575b79 100644 > --- a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c > +++ b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c > @@ -782,10 +782,14 @@ Ip6ManualAddrDadCallback ( > Instance =3D (IP6_CONFIG_INSTANCE *) Context; > NET_CHECK_SIGNATURE (Instance, IP6_CONFIG_INSTANCE_SIGNATURE); > Item =3D &Instance->DataItem[Ip6ConfigDataTypeManualAddress]; > ManualAddr =3D NULL; >=20 > + if (Item->DataSize =3D=3D 0) { > + return; > + } > + > for (Index =3D 0; Index < Item->DataSize / sizeof > (EFI_IP6_CONFIG_MANUAL_ADDRESS); Index++) { > // > // Find the original tag used to place into the NET_MAP. > // > ManualAddr =3D Item->Data.ManualAddress + Index; > -- > 1.9.5.msysgit.1