From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B638B21A134AE for ; Thu, 4 May 2017 22:05:47 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2017 22:05:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,291,1491289200"; d="scan'208";a="83880217" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 04 May 2017 22:05:46 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 4 May 2017 22:05:46 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Fri, 5 May 2017 13:05:43 +0800 From: "Wu, Jiaxin" To: "Zhang, Lubo" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" Thread-Topic: [edk2] [patch] NetworkPkg: Fix issue in dns driver when building DHCP packet. Thread-Index: AQHSxLnjs6J3EMEScESy0YPmfKfDcKHlL6WQ Date: Fri, 5 May 2017 05:05:42 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274162C7A09@SHSMSX103.ccr.corp.intel.com> References: <1493890536-17740-1-git-send-email-lubo.zhang@intel.com> In-Reply-To: <1493890536-17740-1-git-send-email-lubo.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDI1YTg3MTItY2Y2Yy00ZDkwLWEzNjktYjIwNWIwYTA2OGM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJCdm5jbE0xTEZ0eVdqMVVQcVJ0eVl5T3VNeXZLbWVONEp5OFpzK1h5REw0PSJ9 x-ctpclassification: CTP_PUBLIC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] NetworkPkg: Fix issue in dns driver when building DHCP packet. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 05:05:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Wu Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Zhang Lubo > Sent: Thursday, May 4, 2017 5:36 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, J= iaxin > > Subject: [edk2] [patch] NetworkPkg: Fix issue in dns driver when building= DHCP > packet. >=20 > Currently, DNS driver configure the dhcp message type to inform > when building dhcp packet to get dns info from, but it not works > with dhcp server deployed on linux system. However it works well > when changed to request type. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > Cc: Wu Jiaxin > Cc: Ye Ting > Cc: Fu Siyuan > --- > NetworkPkg/DnsDxe/DnsDhcp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/NetworkPkg/DnsDxe/DnsDhcp.c b/NetworkPkg/DnsDxe/DnsDhcp.c > index c4add70..93779be 100644 > --- a/NetworkPkg/DnsDxe/DnsDhcp.c > +++ b/NetworkPkg/DnsDxe/DnsDhcp.c > @@ -1,9 +1,9 @@ > /** @file > Functions implementation related with DHCPv4/v6 for DNS driver. >=20 > -Copyright (c) 2015, Intel Corporation. All rights reserved.
> +Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e found > at > http://opensource.org/licenses/bsd-license.php >=20 > @@ -460,11 +460,11 @@ GetDns4ServerFromDhcp4 ( > goto ON_EXIT; > } >=20 > ParaList[0]->OpCode =3D DHCP4_TAG_TYPE; > ParaList[0]->Length =3D 1; > - ParaList[0]->Data[0] =3D DHCP4_MSG_INFORM; > + ParaList[0]->Data[0] =3D DHCP4_MSG_REQUEST; >=20 > ParaList[1] =3D AllocateZeroPool (sizeof (EFI_DHCP4_PACKET_OPTION)); > if (ParaList[1] =3D=3D NULL) { > Status =3D EFI_OUT_OF_RESOURCES; > goto ON_EXIT; > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel