* Re: [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
2017-06-08 6:40 [PATCH v1 1/1] ShellPkg/ifconfig: Update help message hegdenag
@ 2017-06-08 15:55 ` Shah, Tapan
2017-06-08 15:59 ` Carsey, Jaben
2017-06-09 0:58 ` Wu, Jiaxin
2017-06-09 7:27 ` Subramanian, Sriram
2 siblings, 1 reply; 5+ messages in thread
From: Shah, Tapan @ 2017-06-08 15:55 UTC (permalink / raw)
To: Hegde, Nagaraj P, edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com, ruiyu.ni@intel.com, siyuan.fu@intel.com,
jiaxin.wu@intel.com
Reviewed-by: Tapan Shah <tapandshah@hpe.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Hegde, Nagaraj P
Sent: Thursday, June 08, 2017 1:41 AM
To: edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com; ruiyu.ni@intel.com; siyuan.fu@intel.com; jiaxin.wu@intel.com
Subject: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
Couple of instances had IP4 mentioned, instead of IPv4.
Changing all to IPv4 to maintain consistency.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
---
ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
index d9bbb209cd..d427dd209f 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
@@ -150,13 +150,13 @@
".SH DESCRIPTION\r\n"
" \r\n"
"NOTES:\r\n"
-" 1. This command modifies the default IP address for the UEFI IP4\r\n"
+" 1. This command modifies the default IP address for the UEFI IPv4\r\n"
" network stack.\r\n"
" 2. Use '-r' to renew configuration of interface and set dhcp policy.\r\n"
" 3. Use '-l' to list the DNS and other address related settings for all\r\n"
" interfaces or the specified interface.\r\n"
" 4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
-" static IP4 address configuration for specified interface.\r\n"
+" static IPv4 address configuration for specified interface.\r\n"
" 5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
" configuration dynamically for specified interface.\r\n"
" 6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
--
2.13.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
2017-06-08 15:55 ` Shah, Tapan
@ 2017-06-08 15:59 ` Carsey, Jaben
0 siblings, 0 replies; 5+ messages in thread
From: Carsey, Jaben @ 2017-06-08 15:59 UTC (permalink / raw)
To: Shah, Tapan, Hegde, Nagaraj P, edk2-devel@lists.01.org
Cc: Ni, Ruiyu, Fu, Siyuan, Wu, Jiaxin
Seems quite straight forward to me.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Shah, Tapan
> Sent: Thursday, June 08, 2017 8:55 AM
> To: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> Subject: Re: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
> Importance: High
>
> Reviewed-by: Tapan Shah <tapandshah@hpe.com>
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Hegde, Nagaraj P
> Sent: Thursday, June 08, 2017 1:41 AM
> To: edk2-devel@lists.01.org
> Cc: jaben.carsey@intel.com; ruiyu.ni@intel.com; siyuan.fu@intel.com;
> jiaxin.wu@intel.com
> Subject: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
>
> Couple of instances had IP4 mentioned, instead of IPv4.
> Changing all to IPv4 to maintain consistency.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
> ---
>
> ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm
> andsLib.uni | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> index d9bbb209cd..d427dd209f 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> +++
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> @@ -150,13 +150,13 @@
> ".SH DESCRIPTION\r\n"
> " \r\n"
> "NOTES:\r\n"
> -" 1. This command modifies the default IP address for the UEFI IP4\r\n"
> +" 1. This command modifies the default IP address for the UEFI IPv4\r\n"
> " network stack.\r\n"
> " 2. Use '-r' to renew configuration of interface and set dhcp policy.\r\n"
> " 3. Use '-l' to list the DNS and other address related settings for all\r\n"
> " interfaces or the specified interface.\r\n"
> " 4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
> -" static IP4 address configuration for specified interface.\r\n"
> +" static IPv4 address configuration for specified interface.\r\n"
> " 5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
> " configuration dynamically for specified interface.\r\n"
> " 6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
> --
> 2.13.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
2017-06-08 6:40 [PATCH v1 1/1] ShellPkg/ifconfig: Update help message hegdenag
2017-06-08 15:55 ` Shah, Tapan
@ 2017-06-09 0:58 ` Wu, Jiaxin
2017-06-09 7:27 ` Subramanian, Sriram
2 siblings, 0 replies; 5+ messages in thread
From: Wu, Jiaxin @ 2017-06-09 0:58 UTC (permalink / raw)
To: hegdenag, edk2-devel@lists.01.org; +Cc: Carsey, Jaben, Ni, Ruiyu, Fu, Siyuan
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> hegdenag
> Sent: Thursday, June 8, 2017 2:41 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
>
> Couple of instances had IP4 mentioned, instead of IPv4.
> Changing all to IPv4 to maintain consistency.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
> ---
>
> ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm
> andsLib.uni | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> index d9bbb209cd..d427dd209f 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> +++
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> @@ -150,13 +150,13 @@
> ".SH DESCRIPTION\r\n"
> " \r\n"
> "NOTES:\r\n"
> -" 1. This command modifies the default IP address for the UEFI IP4\r\n"
> +" 1. This command modifies the default IP address for the UEFI IPv4\r\n"
> " network stack.\r\n"
> " 2. Use '-r' to renew configuration of interface and set dhcp policy.\r\n"
> " 3. Use '-l' to list the DNS and other address related settings for all\r\n"
> " interfaces or the specified interface.\r\n"
> " 4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
> -" static IP4 address configuration for specified interface.\r\n"
> +" static IPv4 address configuration for specified interface.\r\n"
> " 5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
> " configuration dynamically for specified interface.\r\n"
> " 6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
> --
> 2.13.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
2017-06-08 6:40 [PATCH v1 1/1] ShellPkg/ifconfig: Update help message hegdenag
2017-06-08 15:55 ` Shah, Tapan
2017-06-09 0:58 ` Wu, Jiaxin
@ 2017-06-09 7:27 ` Subramanian, Sriram
2 siblings, 0 replies; 5+ messages in thread
From: Subramanian, Sriram @ 2017-06-09 7:27 UTC (permalink / raw)
To: Hegde, Nagaraj P, edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com, ruiyu.ni@intel.com, jiaxin.wu@intel.com,
siyuan.fu@intel.com
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>
-----Original Message-----
From: Hegde, Nagaraj P
Sent: Thursday, June 8, 2017 12:11 PM
To: edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com; Subramanian, Sriram <sriram-s@hpe.com>; ruiyu.ni@intel.com; jiaxin.wu@intel.com; siyuan.fu@intel.com
Subject: [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
Couple of instances had IP4 mentioned, instead of IPv4.
Changing all to IPv4 to maintain consistency.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
---
ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
index d9bbb209cd..d427dd209f 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni
@@ -150,13 +150,13 @@
".SH DESCRIPTION\r\n"
" \r\n"
"NOTES:\r\n"
-" 1. This command modifies the default IP address for the UEFI IP4\r\n"
+" 1. This command modifies the default IP address for the UEFI IPv4\r\n"
" network stack.\r\n"
" 2. Use '-r' to renew configuration of interface and set dhcp policy.\r\n"
" 3. Use '-l' to list the DNS and other address related settings for all\r\n"
" interfaces or the specified interface.\r\n"
" 4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
-" static IP4 address configuration for specified interface.\r\n"
+" static IPv4 address configuration for specified interface.\r\n"
" 5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
" configuration dynamically for specified interface.\r\n"
" 6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
--
2.13.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread