From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size
Date: Thu, 27 Jul 2017 00:25:30 +0000 [thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B7274162FCAF6@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170726092700.33264-1-ruiyu.ni@intel.com>
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, July 26, 2017 5:27 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size
>
> Currently the PcdMaxVariableSize is controlled by the below condition
> check:
>
> !if $(SECURE_BOOT_ENABLE) == TRUE || $(TLS_ENABLE) == TRUE
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> !endif
>
> But for other case, PcdMaxVariableSize is also required with the value
> of 0x2000 (e,g. NetworkPkg/IScsiDxe), so remove the condition of
> PcdMaxVariableSize for NT32 platform.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> ---
> Nt32Pkg/Nt32Pkg.dsc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc
> index fa3446be06..30d67309cd 100644
> --- a/Nt32Pkg/Nt32Pkg.dsc
> +++ b/Nt32Pkg/Nt32Pkg.dsc
> @@ -272,9 +272,7 @@ [PcdsFixedAtBuild]
> gEfiNt32PkgTokenSpaceGuid.PcdWinNtFirmwareBlockSize|0x10000
> gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x0f
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationC
> hange|FALSE
> -!if $(SECURE_BOOT_ENABLE) == TRUE || $(TLS_ENABLE) == TRUE
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> -!endif
>
> !if $(ALLOW_HTTP_CONNECTIONS) == TRUE
> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> --
> 2.12.2.windows.2
prev parent reply other threads:[~2017-07-27 0:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 9:27 [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size Ruiyu Ni
2017-07-27 0:25 ` Wu, Jiaxin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895558F6EA4E3B41AC93A00D163B7274162FCAF6@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox