From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 33C4A21D491AC for ; Wed, 26 Jul 2017 17:23:31 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2017 17:25:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,417,1496127600"; d="scan'208";a="116109729" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 26 Jul 2017 17:25:32 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Jul 2017 17:25:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Thu, 27 Jul 2017 08:25:30 +0800 From: "Wu, Jiaxin" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size Thread-Index: AQHTBfFga1D/WJPphUuHXG1vJarzOKJm0b3Q Date: Thu, 27 Jul 2017 00:25:30 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274162FCAF6@SHSMSX103.ccr.corp.intel.com> References: <20170726092700.33264-1-ruiyu.ni@intel.com> In-Reply-To: <20170726092700.33264-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjZjNzY0OGYtNzZjNC00YWVmLTkyNmItODA0Yzc4OWJmNDU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImF5VXJnS2dqTG8rZjNZT1VzSXRYazlaNlhKWWxlZkJLNkNPM0kxbGxXa0U9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2017 00:23:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiaxin Wu > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, July 26, 2017 5:27 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin > Subject: [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size >=20 > Currently the PcdMaxVariableSize is controlled by the below condition > check: >=20 > !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE || $(TLS_ENABLE) =3D=3D TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > !endif >=20 > But for other case, PcdMaxVariableSize is also required with the value > of 0x2000 (e,g. NetworkPkg/IScsiDxe), so remove the condition of > PcdMaxVariableSize for NT32 platform. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jiaxin Wu > --- > Nt32Pkg/Nt32Pkg.dsc | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc > index fa3446be06..30d67309cd 100644 > --- a/Nt32Pkg/Nt32Pkg.dsc > +++ b/Nt32Pkg/Nt32Pkg.dsc > @@ -272,9 +272,7 @@ [PcdsFixedAtBuild] > gEfiNt32PkgTokenSpaceGuid.PcdWinNtFirmwareBlockSize|0x10000 > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x0f >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationC > hange|FALSE > -!if $(SECURE_BOOT_ENABLE) =3D=3D TRUE || $(TLS_ENABLE) =3D=3D TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > -!endif >=20 > !if $(ALLOW_HTTP_CONNECTIONS) =3D=3D TRUE > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > -- > 2.12.2.windows.2