public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line
@ 2017-08-01  5:47 hegdenag
  2017-08-01  8:16 ` Subramanian, Sriram
  2017-08-03  2:05 ` Wu, Jiaxin
  0 siblings, 2 replies; 3+ messages in thread
From: hegdenag @ 2017-08-01  5:47 UTC (permalink / raw)
  To: edk2-devel; +Cc: jaben.carsey, sriram-s, ruiyu.ni, jiaxin.wu

If DAD failed, we print "It failed to set", print the IPv6
address and exit. We need a better error string
and also, after printing the IPv6 address, we need a new line
else the Shell> prompt will overwrite the IPv6 address. Fixed
these issues in this patch.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
---
 ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c                      | 2 ++
 ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
index 6d8df8031b..a25d4e5d00 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
@@ -2,6 +2,7 @@
   The implementation for Shell command IfConfig6.
 
   Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -1490,6 +1491,7 @@ IfConfig6SetInterfaceInfo (
             &CfgManAddr[Index].Address,
             &CfgManAddr[Index].PrefixLength
             );
+          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_INFO_NEWLINE), gShellNetwork2HiiHandle);
         }
       }
 
diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni
index 5c0fef0ff7..ee2f28717f 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni
@@ -2,6 +2,7 @@
 
   String definitions for UEFI Shell network 2 commands
   Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions
@@ -92,7 +93,7 @@
                                                                   "Hint: Please type 'IfConfig6 -?' for help info.\r\n"
 #string STR_IFCONFIG6_ERR_UNKNOWN_COMMAND      #language en-US    "Unknown commands. Bad command %H%s%N is skipped.\r\n"
                                                                   "Hint: Please type 'IfConfig6 -?' for help info.\r\n"
-#string STR_IFCONFIG6_ERR_ADDRESS_FAILED       #language en-US    "It failed to set .\r\n"
+#string STR_IFCONFIG6_ERR_ADDRESS_FAILED       #language en-US    "Failed to configure IPv6 address: "
 
 
 #string STR_GET_HELP_PING6                     #language en-US ""
-- 
2.13.0.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line
  2017-08-01  5:47 [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line hegdenag
@ 2017-08-01  8:16 ` Subramanian, Sriram
  2017-08-03  2:05 ` Wu, Jiaxin
  1 sibling, 0 replies; 3+ messages in thread
From: Subramanian, Sriram @ 2017-08-01  8:16 UTC (permalink / raw)
  To: Hegde, Nagaraj P, edk2-devel@lists.01.org
  Cc: jaben.carsey@intel.com, ruiyu.ni@intel.com, jiaxin.wu@intel.com

Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>

-----Original Message-----
From: Hegde, Nagaraj P 
Sent: Tuesday, August 1, 2017 11:18 AM
To: edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com; Subramanian, Sriram <sriram-s@hpe.com>; ruiyu.ni@intel.com; jiaxin.wu@intel.com
Subject: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line

If DAD failed, we print "It failed to set", print the IPv6
address and exit. We need a better error string
and also, after printing the IPv6 address, we need a new line
else the Shell> prompt will overwrite the IPv6 address. Fixed
these issues in this patch.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
---
 ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c                      | 2 ++
 ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
index 6d8df8031b..a25d4e5d00 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
@@ -2,6 +2,7 @@
   The implementation for Shell command IfConfig6.
 
   Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -1490,6 +1491,7 @@ IfConfig6SetInterfaceInfo (
             &CfgManAddr[Index].Address,
             &CfgManAddr[Index].PrefixLength
             );
+          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_INFO_NEWLINE), gShellNetwork2HiiHandle);
         }
       }
 
diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni
index 5c0fef0ff7..ee2f28717f 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni
@@ -2,6 +2,7 @@
 
   String definitions for UEFI Shell network 2 commands
   Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions
@@ -92,7 +93,7 @@
                                                                   "Hint: Please type 'IfConfig6 -?' for help info.\r\n"
 #string STR_IFCONFIG6_ERR_UNKNOWN_COMMAND      #language en-US    "Unknown commands. Bad command %H%s%N is skipped.\r\n"
                                                                   "Hint: Please type 'IfConfig6 -?' for help info.\r\n"
-#string STR_IFCONFIG6_ERR_ADDRESS_FAILED       #language en-US    "It failed to set .\r\n"
+#string STR_IFCONFIG6_ERR_ADDRESS_FAILED       #language en-US    "Failed to configure IPv6 address: "
 
 
 #string STR_GET_HELP_PING6                     #language en-US ""
-- 
2.13.0.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line
  2017-08-01  5:47 [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line hegdenag
  2017-08-01  8:16 ` Subramanian, Sriram
@ 2017-08-03  2:05 ` Wu, Jiaxin
  1 sibling, 0 replies; 3+ messages in thread
From: Wu, Jiaxin @ 2017-08-03  2:05 UTC (permalink / raw)
  To: hegdenag, edk2-devel@lists.01.org; +Cc: Carsey, Jaben, Ni, Ruiyu

Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> hegdenag
> Sent: Tuesday, August 1, 2017 1:48 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and
> add a new line
> 
> If DAD failed, we print "It failed to set", print the IPv6
> address and exit. We need a better error string
> and also, after printing the IPv6 address, we need a new line
> else the Shell> prompt will overwrite the IPv6 address. Fixed
> these issues in this patch.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
> ---
>  ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c                      | 2
> ++
> 
> ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm
> andsLib.uni | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> index 6d8df8031b..a25d4e5d00 100644
> --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> @@ -2,6 +2,7 @@
>    The implementation for Shell command IfConfig6.
> 
>    Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> +  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> 
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
> @@ -1490,6 +1491,7 @@ IfConfig6SetInterfaceInfo (
>              &CfgManAddr[Index].Address,
>              &CfgManAddr[Index].PrefixLength
>              );
> +          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_INFO_NEWLINE), gShellNetwork2HiiHandle);
>          }
>        }
> 
> diff --git
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.uni
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.uni
> index 5c0fef0ff7..ee2f28717f 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.uni
> +++
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.uni
> @@ -2,6 +2,7 @@
> 
>    String definitions for UEFI Shell network 2 commands
>    Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> +  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> 
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions
> @@ -92,7 +93,7 @@
>                                                                    "Hint: Please type 'IfConfig6 -?' for help
> info.\r\n"
>  #string STR_IFCONFIG6_ERR_UNKNOWN_COMMAND      #language en-US
> "Unknown commands. Bad command %H%s%N is skipped.\r\n"
>                                                                    "Hint: Please type 'IfConfig6 -?' for help
> info.\r\n"
> -#string STR_IFCONFIG6_ERR_ADDRESS_FAILED       #language en-US    "It
> failed to set .\r\n"
> +#string STR_IFCONFIG6_ERR_ADDRESS_FAILED       #language en-US
> "Failed to configure IPv6 address: "
> 
> 
>  #string STR_GET_HELP_PING6                     #language en-US ""
> --
> 2.13.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-03  2:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-01  5:47 [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line hegdenag
2017-08-01  8:16 ` Subramanian, Sriram
2017-08-03  2:05 ` Wu, Jiaxin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox