From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F679209589C8 for ; Wed, 2 Aug 2017 19:03:42 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2017 19:05:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,314,1498546800"; d="scan'208";a="885776575" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 02 Aug 2017 19:05:43 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 Aug 2017 19:05:43 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by shsmsx102.ccr.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0319.002; Thu, 3 Aug 2017 10:05:40 +0800 From: "Wu, Jiaxin" To: hegdenag , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" , "Ni, Ruiyu" Thread-Topic: [edk2] [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line Thread-Index: AQHTCom6wkm5ZzQk0UWMvg076oDBNKJx5MYg Date: Thu, 3 Aug 2017 02:05:39 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274162FE750@SHSMSX103.ccr.corp.intel.com> References: <20170801054742.23300-1-nagaraj-p.hegde@hpe.com> In-Reply-To: <20170801054742.23300-1-nagaraj-p.hegde@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjkxOWEwODgtYzNlYS00YzE1LWIxNGUtY2I2MTgzYzdjY2ZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InVTY015aDFcLzNNZkRNYXJSeG52RDRvY1FzS3UrUHZ0ekZiTnFJY2lFaitRPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 02:03:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Wu Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > hegdenag > Sent: Tuesday, August 1, 2017 1:48 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu ; > Wu, Jiaxin > Subject: [edk2] [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message a= nd > add a new line >=20 > If DAD failed, we print "It failed to set", print the IPv6 > address and exit. We need a better error string > and also, after printing the IPv6 address, we need a new line > else the Shell> prompt will overwrite the IPv6 address. Fixed > these issues in this patch. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Hegde Nagaraj P > --- > ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c = | 2 > ++ >=20 > ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm > andsLib.uni | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > index 6d8df8031b..a25d4e5d00 100644 > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > @@ -2,6 +2,7 @@ > The implementation for Shell command IfConfig6. >=20 > Copyright (c) 2016, Intel Corporation. All rights reserved.
> + (C) Copyright 2017 Hewlett Packard Enterprise Development LP
>=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > @@ -1490,6 +1491,7 @@ IfConfig6SetInterfaceInfo ( > &CfgManAddr[Index].Address, > &CfgManAddr[Index].PrefixLength > ); > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_IFCONFIG6_INFO_NEWLINE), gShellNetwork2HiiHandle); > } > } >=20 > diff --git > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > index 5c0fef0ff7..ee2f28717f 100644 > --- > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > +++ > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > @@ -2,6 +2,7 @@ >=20 > String definitions for UEFI Shell network 2 commands > Copyright (c) 2016, Intel Corporation. All rights reserved.
> + (C) Copyright 2017 Hewlett Packard Enterprise Development LP
>=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions > @@ -92,7 +93,7 @@ > "Hint:= Please type 'IfConfig6 -?' for help > info.\r\n" > #string STR_IFCONFIG6_ERR_UNKNOWN_COMMAND #language en-US > "Unknown commands. Bad command %H%s%N is skipped.\r\n" > "Hint:= Please type 'IfConfig6 -?' for help > info.\r\n" > -#string STR_IFCONFIG6_ERR_ADDRESS_FAILED #language en-US "It > failed to set .\r\n" > +#string STR_IFCONFIG6_ERR_ADDRESS_FAILED #language en-US > "Failed to configure IPv6 address: " >=20 >=20 > #string STR_GET_HELP_PING6 #language en-US "" > -- > 2.13.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel