From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6529F21E1B752 for ; Sun, 24 Sep 2017 21:59:23 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2017 22:02:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="1175443440" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 24 Sep 2017 22:02:32 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 22:02:32 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 22:02:31 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 13:02:30 +0800 From: "Wu, Jiaxin" To: Santhapur Naveen , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" Thread-Topic: Repeated condition check Thread-Index: AdMx2S+NdBBnOF5gSMOFWy5SEenozABpO22AAI8gkzA= Date: Mon, 25 Sep 2017 05:02:30 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274163374E0@SHSMSX103.ccr.corp.intel.com> References: <625A2455CC232F40B0F38F05ACED6D97012CA99E6A@VENUS1.in.megatrends.com> In-Reply-To: <625A2455CC232F40B0F38F05ACED6D97012CA99E6A@VENUS1.in.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQ0NmRmMDUtNDk5Yi00MDYwLWJlZjEtNzMzNmUwNzY1MDgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJqRmxScXRiVWZaMGVIMk9EbU42dUVxeEREUzdwK05SNGFaZnV4bXdTMmM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: Repeated condition check X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 04:59:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Naveen,=20 We may ignore your email if you don't attach any specific receiver (TO OR = CC list):(. For the issue, I agree the fix. So, can you help to report the issue on Bug= zilla? We will create the formal patch to fix it. Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Santhapur Naveen > Sent: Friday, September 22, 2017 4:40 PM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] Repeated condition check >=20 > Hello guys, >=20 > Any update? >=20 > Thank you > Naveen >=20 > -----Original Message----- > From: Santhapur Naveen > Sent: Wednesday, September 20, 2017 12:05 PM > To: edk2-devel@lists.01.org > Subject: Repeated condition check >=20 > Hi all, >=20 > There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle(= ) >=20 > VOID > EFIAPI > PxeBcIcmp6ErrorDpcHandle ( > IN VOID *Context > ) > { > ... >=20 > if (Type !=3D ICMP_V6_DEST_UNREACHABLE && > Type !=3D ICMP_V6_PACKET_TOO_BIG && > -Type !=3D ICMP_V6_PACKET_TOO_BIG && > +Type !=3D ICMP_V6_TIME_EXCEEDED && > Type !=3D ICMP_V6_PARAMETER_PROBLEM) { > // > // The type of the receveid packet should be an ICMP6 error message. > // > gBS->SignalEvent (RxData->RecycleSignal); > goto ON_EXIT; > } > ... > } >=20 > Unfortunately, some error checking tools were not able to capture this. > Please confirm and take the necessary action. >=20 > Thank you > Naveen > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel