* [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-09-25 12:48 ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic Liming Gao
` (9 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf b/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf
index 18df4a0..20214f7 100644
--- a/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf
+++ b/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf
@@ -18,8 +18,8 @@
[Defines]
INF_VERSION = 0x00010005
- BASE_NAME = BaseS3SegmentPciLib
- MODULE_UNI_FILE = BaseS3SegmentPciLib.uni
+ BASE_NAME = BaseS3PciSegmentLib
+ MODULE_UNI_FILE = BaseS3PciSegmentLib.uni
FILE_GUID = 17E2C90E-AD1F-443A-8C94-6E50C0E98607
MODULE_TYPE = BASE
VERSION_STRING = 1.0
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file
2017-09-25 11:06 ` [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file Liming Gao
@ 2017-09-25 12:48 ` Ni, Ruiyu
0 siblings, 0 replies; 25+ messages in thread
From: Ni, Ruiyu @ 2017-09-25 12:48 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
-----Original Message-----
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf b/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf
index 18df4a0..20214f7 100644
--- a/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf
+++ b/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf
@@ -18,8 +18,8 @@
[Defines]
INF_VERSION = 0x00010005
- BASE_NAME = BaseS3SegmentPciLib
- MODULE_UNI_FILE = BaseS3SegmentPciLib.uni
+ BASE_NAME = BaseS3PciSegmentLib
+ MODULE_UNI_FILE = BaseS3PciSegmentLib.uni
FILE_GUID = 17E2C90E-AD1F-443A-8C94-6E50C0E98607
MODULE_TYPE = BASE
VERSION_STRING = 1.0
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
2017-09-25 11:06 ` [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-09-25 12:44 ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code Liming Gao
` (8 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
FatPkg/EnhancedFatDxe/Fat.inf | 2 +-
FatPkg/FatPei/FatPei.inf | 10 +++++++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf
index e7044cd..686b371 100644
--- a/FatPkg/EnhancedFatDxe/Fat.inf
+++ b/FatPkg/EnhancedFatDxe/Fat.inf
@@ -81,7 +81,7 @@
[Protocols]
gEfiDiskIoProtocolGuid ## TO_START
- gEfiDiskIo2ProtocolGuid ## TO_START
+ gEfiDiskIo2ProtocolGuid ## SOMETIMES_CONSUMES
gEfiBlockIoProtocolGuid ## TO_START
gEfiSimpleFileSystemProtocolGuid ## BY_START
gEfiUnicodeCollationProtocolGuid ## TO_START
diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf
index 273f72d..c963429 100644
--- a/FatPkg/FatPei/FatPei.inf
+++ b/FatPkg/FatPei/FatPei.inf
@@ -61,9 +61,13 @@
[Ppis]
- gEfiPeiVirtualBlockIoPpiGuid ## SOMETIMES_CONSUMES PPI_NOTIFY
- gEfiPeiVirtualBlockIo2PpiGuid ## SOMETIMES_CONSUMES PPI_NOTIFY
- gEfiPeiDeviceRecoveryModulePpiGuid ## SOMETIMES_PRODUCES
+ ## NOTIFY
+ ## SOMETIMES_CONSUMES
+ gEfiPeiVirtualBlockIoPpiGuid
+ ## NOTIFY
+ ## SOMETIMES_CONSUMES
+ gEfiPeiVirtualBlockIo2PpiGuid
+ gEfiPeiDeviceRecoveryModulePpiGuid ## PRODUCES
[FeaturePcd]
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
2017-09-25 11:06 ` [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic Liming Gao
@ 2017-09-25 12:44 ` Ni, Ruiyu
2017-09-26 3:27 ` Gao, Liming
0 siblings, 1 reply; 25+ messages in thread
From: Ni, Ruiyu @ 2017-09-25 12:44 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Liming,
There is no keyword such as "SOMETIMES_TO_START"?
The DiskIo2 is indeed a TO_START protocol, but optional.
-----Original Message-----
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
FatPkg/EnhancedFatDxe/Fat.inf | 2 +-
FatPkg/FatPei/FatPei.inf | 10 +++++++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf index e7044cd..686b371 100644
--- a/FatPkg/EnhancedFatDxe/Fat.inf
+++ b/FatPkg/EnhancedFatDxe/Fat.inf
@@ -81,7 +81,7 @@
[Protocols]
gEfiDiskIoProtocolGuid ## TO_START
- gEfiDiskIo2ProtocolGuid ## TO_START
+ gEfiDiskIo2ProtocolGuid ## SOMETIMES_CONSUMES
gEfiBlockIoProtocolGuid ## TO_START
gEfiSimpleFileSystemProtocolGuid ## BY_START
gEfiUnicodeCollationProtocolGuid ## TO_START
diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index 273f72d..c963429 100644
--- a/FatPkg/FatPei/FatPei.inf
+++ b/FatPkg/FatPei/FatPei.inf
@@ -61,9 +61,13 @@
[Ppis]
- gEfiPeiVirtualBlockIoPpiGuid ## SOMETIMES_CONSUMES PPI_NOTIFY
- gEfiPeiVirtualBlockIo2PpiGuid ## SOMETIMES_CONSUMES PPI_NOTIFY
- gEfiPeiDeviceRecoveryModulePpiGuid ## SOMETIMES_PRODUCES
+ ## NOTIFY
+ ## SOMETIMES_CONSUMES
+ gEfiPeiVirtualBlockIoPpiGuid
+ ## NOTIFY
+ ## SOMETIMES_CONSUMES
+ gEfiPeiVirtualBlockIo2PpiGuid
+ gEfiPeiDeviceRecoveryModulePpiGuid ## PRODUCES
[FeaturePcd]
--
2.8.0.windows.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
2017-09-25 12:44 ` Ni, Ruiyu
@ 2017-09-26 3:27 ` Gao, Liming
0 siblings, 0 replies; 25+ messages in thread
From: Gao, Liming @ 2017-09-26 3:27 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Ray:
There is no such key. OK, I will keep its usage to TO_START.
Thanks
Liming
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Monday, September 25, 2017 8:44 PM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
>
> Liming,
> There is no keyword such as "SOMETIMES_TO_START"?
> The DiskIo2 is indeed a TO_START protocol, but optional.
>
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, September 25, 2017 7:06 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> FatPkg/EnhancedFatDxe/Fat.inf | 2 +-
> FatPkg/FatPei/FatPei.inf | 10 +++++++---
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf index e7044cd..686b371 100644
> --- a/FatPkg/EnhancedFatDxe/Fat.inf
> +++ b/FatPkg/EnhancedFatDxe/Fat.inf
> @@ -81,7 +81,7 @@
>
> [Protocols]
> gEfiDiskIoProtocolGuid ## TO_START
> - gEfiDiskIo2ProtocolGuid ## TO_START
> + gEfiDiskIo2ProtocolGuid ## SOMETIMES_CONSUMES
> gEfiBlockIoProtocolGuid ## TO_START
> gEfiSimpleFileSystemProtocolGuid ## BY_START
> gEfiUnicodeCollationProtocolGuid ## TO_START
> diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index 273f72d..c963429 100644
> --- a/FatPkg/FatPei/FatPei.inf
> +++ b/FatPkg/FatPei/FatPei.inf
> @@ -61,9 +61,13 @@
>
>
> [Ppis]
> - gEfiPeiVirtualBlockIoPpiGuid ## SOMETIMES_CONSUMES PPI_NOTIFY
> - gEfiPeiVirtualBlockIo2PpiGuid ## SOMETIMES_CONSUMES PPI_NOTIFY
> - gEfiPeiDeviceRecoveryModulePpiGuid ## SOMETIMES_PRODUCES
> + ## NOTIFY
> + ## SOMETIMES_CONSUMES
> + gEfiPeiVirtualBlockIoPpiGuid
> + ## NOTIFY
> + ## SOMETIMES_CONSUMES
> + gEfiPeiVirtualBlockIo2PpiGuid
> + gEfiPeiDeviceRecoveryModulePpiGuid ## PRODUCES
>
>
> [FeaturePcd]
> --
> 2.8.0.windows.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
2017-09-25 11:06 ` [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file Liming Gao
2017-09-25 11:06 ` [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-09-25 12:46 ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic Liming Gao
` (7 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
.../PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
index 8b992d0..dd746a2 100644
--- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
+++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
@@ -58,8 +58,13 @@
gEfiRealTimeClockArchProtocolGuid ## PRODUCES
[Guids]
- gEfiAcpi10TableGuid ## CONSUMES ## Event
- gEfiAcpiTableGuid ## CONSUMES ## Event
+ ## SOMETIMES_CONSUMES ## Event
+ ## SOMETIMES_CONSUMES ## SystemTable
+ gEfiAcpi10TableGuid
+
+ ## SOMETIMES_CONSUMES ## Event
+ ## SOMETIMES_CONSUMES ## SystemTable
+ gEfiAcpiTableGuid
[Depex]
gEfiVariableArchProtocolGuid AND gEfiVariableWriteArchProtocolGuid
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code
2017-09-25 11:06 ` [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code Liming Gao
@ 2017-09-25 12:46 ` Ni, Ruiyu
0 siblings, 0 replies; 25+ messages in thread
From: Ni, Ruiyu @ 2017-09-25 12:46 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
-----Original Message-----
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
.../PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
index 8b992d0..dd746a2 100644
--- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
+++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
@@ -58,8 +58,13 @@
gEfiRealTimeClockArchProtocolGuid ## PRODUCES
[Guids]
- gEfiAcpi10TableGuid ## CONSUMES ## Event
- gEfiAcpiTableGuid ## CONSUMES ## Event
+ ## SOMETIMES_CONSUMES ## Event
+ ## SOMETIMES_CONSUMES ## SystemTable
+ gEfiAcpi10TableGuid
+
+ ## SOMETIMES_CONSUMES ## Event
+ ## SOMETIMES_CONSUMES ## SystemTable
+ gEfiAcpiTableGuid
[Depex]
gEfiVariableArchProtocolGuid AND gEfiVariableWriteArchProtocolGuid
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
` (2 preceding siblings ...)
2017-09-25 11:06 ` [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-09-25 12:08 ` Dong, Eric
2017-09-25 11:06 ` [Patch 05/11] ShellPkg: Update Guid usage in ShellLib " Liming Gao
` (6 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
index 39fdc07..805641b 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
@@ -63,7 +63,7 @@
[Guids]
gEfiEventExitBootServicesGuid ## CONSUMES ## Event
- gEfiEventLegacyBootGuid ## CONSUMES ## Event
+ gEfiEventLegacyBootGuid ## SOMETIMES_CONSUMES ## Event
[Pcd]
gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## CONSUMES
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic
2017-09-25 11:06 ` [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic Liming Gao
@ 2017-09-25 12:08 ` Dong, Eric
0 siblings, 0 replies; 25+ messages in thread
From: Dong, Eric @ 2017-09-25 12:08 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>
Subject: [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
index 39fdc07..805641b 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
@@ -63,7 +63,7 @@
[Guids]
gEfiEventExitBootServicesGuid ## CONSUMES ## Event
- gEfiEventLegacyBootGuid ## CONSUMES ## Event
+ gEfiEventLegacyBootGuid ## SOMETIMES_CONSUMES ## Event
[Pcd]
gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## CONSUMES
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Patch 05/11] ShellPkg: Update Guid usage in ShellLib INF to match source code logic
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
` (3 preceding siblings ...)
2017-09-25 11:06 ` [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-09-25 12:47 ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file " Liming Gao
` (5 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
index 4c1c3d3..c88aa4a 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
@@ -295,7 +295,7 @@
[Guids]
gEfiFileInfoGuid ## UNDEFINED
- gEfiShellEnvironment2ExtGuid ## CONSUMES ## GUID
+ gEfiShellEnvironment2ExtGuid ## SOMETIMES_CONSUMES ## GUID
gEfiPcAnsiGuid ## UNDEFINED
gEfiVT100Guid ## UNDEFINED
gEfiVT100PlusGuid ## UNDEFINED
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 05/11] ShellPkg: Update Guid usage in ShellLib INF to match source code logic
2017-09-25 11:06 ` [Patch 05/11] ShellPkg: Update Guid usage in ShellLib " Liming Gao
@ 2017-09-25 12:47 ` Ni, Ruiyu
0 siblings, 0 replies; 25+ messages in thread
From: Ni, Ruiyu @ 2017-09-25 12:47 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
-----Original Message-----
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [Patch 05/11] ShellPkg: Update Guid usage in ShellLib INF to match source code logic
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
index 4c1c3d3..c88aa4a 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
@@ -295,7 +295,7 @@
[Guids]
gEfiFileInfoGuid ## UNDEFINED
- gEfiShellEnvironment2ExtGuid ## CONSUMES ## GUID
+ gEfiShellEnvironment2ExtGuid ## SOMETIMES_CONSUMES ## GUID
gEfiPcAnsiGuid ## UNDEFINED
gEfiVT100Guid ## UNDEFINED
gEfiVT100PlusGuid ## UNDEFINED
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
` (4 preceding siblings ...)
2017-09-25 11:06 ` [Patch 05/11] ShellPkg: Update Guid usage in ShellLib " Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-09-26 0:41 ` Fu, Siyuan
2017-10-10 7:24 ` Wu, Jiaxin
2017-09-25 11:06 ` [Patch 07/11] SignedCapsulePkg: Update Guid " Liming Gao
` (4 subsequent siblings)
10 siblings, 2 replies; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Siyuan Fu, Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
---
NetworkPkg/HttpDxe/HttpDxe.inf | 2 +-
NetworkPkg/IScsiDxe/IScsiDxe.inf | 2 +-
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 8 ++++----
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/NetworkPkg/HttpDxe/HttpDxe.inf b/NetworkPkg/HttpDxe/HttpDxe.inf
index df2efdc..51deec5 100644
--- a/NetworkPkg/HttpDxe/HttpDxe.inf
+++ b/NetworkPkg/HttpDxe/HttpDxe.inf
@@ -73,7 +73,7 @@
gEfiTlsConfigurationProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
- gEfiTlsCaCertificateGuid ## CONSUMES ## GUID
+ gEfiTlsCaCertificateGuid ## SOMETIMES_CONSUMES ## Variable:L"TlsCaCertificate"
[Pcd]
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections ## CONSUMES
diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf
index c9b724b..01998a0 100644
--- a/NetworkPkg/IScsiDxe/IScsiDxe.inf
+++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf
@@ -115,7 +115,7 @@
gEfiIScsiInitiatorNameProtocolGuid
## PRODUCES
gEfiAuthenticationInfoProtocolGuid
- ## CONSUMES
+ ## SOMETIMES_CONSUMES
gEfiAdapterInformationProtocolGuid
[Guids]
diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
index 2a89368..3cfcdb9 100644
--- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
+++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
@@ -2,7 +2,7 @@
# Provides the capability to configure Tls Authentication in a setup browser
# By this module, user may change the content of TlsCaCertificate.
#
-# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
@@ -61,9 +61,9 @@
[Guids]
gTlsAuthConfigGuid ## PRODUCES ## GUID
- gEfiCertX509Guid ## CONSUMES ## GUID # Indicate the cert type
- gEfiIfrTianoGuid ## CONSUMES ## HII
- gEfiTlsCaCertificateGuid ## PRODUCES ## GUID
+ gEfiCertX509Guid ## SOMETIMES_CONSUMES ## GUID # Indicate the cert type
+ gEfiIfrTianoGuid ## SOMETIMES_PRODUCES ## HII
+ gEfiTlsCaCertificateGuid ## PRODUCES ## Variable:L"TlsCaCertificate"
[Depex]
gEfiHiiConfigRoutingProtocolGuid AND
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic
2017-09-25 11:06 ` [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file " Liming Gao
@ 2017-09-26 0:41 ` Fu, Siyuan
2017-10-10 7:24 ` Wu, Jiaxin
1 sibling, 0 replies; 25+ messages in thread
From: Fu, Siyuan @ 2017-09-26 0:41 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Wu, Jiaxin
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
-----Original Message-----
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
---
NetworkPkg/HttpDxe/HttpDxe.inf | 2 +-
NetworkPkg/IScsiDxe/IScsiDxe.inf | 2 +-
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 8 ++++----
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/NetworkPkg/HttpDxe/HttpDxe.inf b/NetworkPkg/HttpDxe/HttpDxe.inf
index df2efdc..51deec5 100644
--- a/NetworkPkg/HttpDxe/HttpDxe.inf
+++ b/NetworkPkg/HttpDxe/HttpDxe.inf
@@ -73,7 +73,7 @@
gEfiTlsConfigurationProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
- gEfiTlsCaCertificateGuid ## CONSUMES ## GUID
+ gEfiTlsCaCertificateGuid ## SOMETIMES_CONSUMES ## Variable:L"TlsCaCertificate"
[Pcd]
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections ## CONSUMES
diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf
index c9b724b..01998a0 100644
--- a/NetworkPkg/IScsiDxe/IScsiDxe.inf
+++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf
@@ -115,7 +115,7 @@
gEfiIScsiInitiatorNameProtocolGuid
## PRODUCES
gEfiAuthenticationInfoProtocolGuid
- ## CONSUMES
+ ## SOMETIMES_CONSUMES
gEfiAdapterInformationProtocolGuid
[Guids]
diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
index 2a89368..3cfcdb9 100644
--- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
+++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
@@ -2,7 +2,7 @@
# Provides the capability to configure Tls Authentication in a setup browser
# By this module, user may change the content of TlsCaCertificate.
#
-# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
@@ -61,9 +61,9 @@
[Guids]
gTlsAuthConfigGuid ## PRODUCES ## GUID
- gEfiCertX509Guid ## CONSUMES ## GUID # Indicate the cert type
- gEfiIfrTianoGuid ## CONSUMES ## HII
- gEfiTlsCaCertificateGuid ## PRODUCES ## GUID
+ gEfiCertX509Guid ## SOMETIMES_CONSUMES ## GUID # Indicate the cert type
+ gEfiIfrTianoGuid ## SOMETIMES_PRODUCES ## HII
+ gEfiTlsCaCertificateGuid ## PRODUCES ## Variable:L"TlsCaCertificate"
[Depex]
gEfiHiiConfigRoutingProtocolGuid AND
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic
2017-09-25 11:06 ` [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file " Liming Gao
2017-09-26 0:41 ` Fu, Siyuan
@ 2017-10-10 7:24 ` Wu, Jiaxin
1 sibling, 0 replies; 25+ messages in thread
From: Wu, Jiaxin @ 2017-10-10 7:24 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Fu, Siyuan
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, September 25, 2017 7:06 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to
> match source code logic
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> ---
> NetworkPkg/HttpDxe/HttpDxe.inf | 2 +-
> NetworkPkg/IScsiDxe/IScsiDxe.inf | 2 +-
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 8 ++++----
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/NetworkPkg/HttpDxe/HttpDxe.inf
> b/NetworkPkg/HttpDxe/HttpDxe.inf
> index df2efdc..51deec5 100644
> --- a/NetworkPkg/HttpDxe/HttpDxe.inf
> +++ b/NetworkPkg/HttpDxe/HttpDxe.inf
> @@ -73,7 +73,7 @@
> gEfiTlsConfigurationProtocolGuid ## SOMETIMES_CONSUMES
>
> [Guids]
> - gEfiTlsCaCertificateGuid ## CONSUMES ## GUID
> + gEfiTlsCaCertificateGuid ## SOMETIMES_CONSUMES ##
> Variable:L"TlsCaCertificate"
>
> [Pcd]
> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections ##
> CONSUMES
> diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf
> b/NetworkPkg/IScsiDxe/IScsiDxe.inf
> index c9b724b..01998a0 100644
> --- a/NetworkPkg/IScsiDxe/IScsiDxe.inf
> +++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf
> @@ -115,7 +115,7 @@
> gEfiIScsiInitiatorNameProtocolGuid
> ## PRODUCES
> gEfiAuthenticationInfoProtocolGuid
> - ## CONSUMES
> + ## SOMETIMES_CONSUMES
> gEfiAdapterInformationProtocolGuid
>
> [Guids]
> diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> index 2a89368..3cfcdb9 100644
> --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> @@ -2,7 +2,7 @@
> # Provides the capability to configure Tls Authentication in a setup browser
> # By this module, user may change the content of TlsCaCertificate.
> #
> -# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> # which accompanies this distribution. The full text of the license may be
> found at
> @@ -61,9 +61,9 @@
>
> [Guids]
> gTlsAuthConfigGuid ## PRODUCES ## GUID
> - gEfiCertX509Guid ## CONSUMES ## GUID # Indicate the
> cert type
> - gEfiIfrTianoGuid ## CONSUMES ## HII
> - gEfiTlsCaCertificateGuid ## PRODUCES ## GUID
> + gEfiCertX509Guid ## SOMETIMES_CONSUMES ## GUID #
> Indicate the cert type
> + gEfiIfrTianoGuid ## SOMETIMES_PRODUCES ## HII
> + gEfiTlsCaCertificateGuid ## PRODUCES ##
> Variable:L"TlsCaCertificate"
>
> [Depex]
> gEfiHiiConfigRoutingProtocolGuid AND
> --
> 2.8.0.windows.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Patch 07/11] SignedCapsulePkg: Update Guid usage in INF file to match source code logic
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
` (5 preceding siblings ...)
2017-09-25 11:06 ` [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file " Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-10-10 6:58 ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 08/11] SecurityPkg: " Liming Gao
` (3 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
.../Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
index a7c9607..a21e75c 100644
--- a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
+++ b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
@@ -3,7 +3,7 @@
#
# EDKII System Capsule library instance for DXE/PEI post memory phase.
#
-# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
@@ -53,9 +53,9 @@
gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer ## CONSUMES
[Guids]
- gEdkiiSystemFirmwareImageDescriptorFileGuid ## CONSUMES ## GUID
- gEdkiiSystemFmpCapsuleConfigFileGuid ## CONSUMES ## GUID
- gEdkiiSystemFmpCapsuleDriverFvFileGuid ## CONSUMES ## GUID
- gEfiCertPkcs7Guid ## CONSUMES ## GUID
- gEfiCertTypeRsa2048Sha256Guid ## CONSUMES ## GUID
+ gEdkiiSystemFirmwareImageDescriptorFileGuid ## SOMETIMES_CONSUMES ## GUID
+ gEdkiiSystemFmpCapsuleConfigFileGuid ## SOMETIMES_CONSUMES ## GUID
+ gEdkiiSystemFmpCapsuleDriverFvFileGuid ## SOMETIMES_CONSUMES ## GUID
+ gEfiCertPkcs7Guid ## SOMETIMES_CONSUMES ## GUID
+ gEfiCertTypeRsa2048Sha256Guid ## SOMETIMES_CONSUMES ## GUID
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 07/11] SignedCapsulePkg: Update Guid usage in INF file to match source code logic
2017-09-25 11:06 ` [Patch 07/11] SignedCapsulePkg: Update Guid " Liming Gao
@ 2017-10-10 6:58 ` Yao, Jiewen
0 siblings, 0 replies; 25+ messages in thread
From: Yao, Jiewen @ 2017-10-10 6:58 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, September 25, 2017 7:06 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch 07/11] SignedCapsulePkg: Update Guid usage in INF file to match
> source code logic
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
> .../Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
> a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> index a7c9607..a21e75c 100644
> ---
> a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> +++
> b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> @@ -3,7 +3,7 @@
> #
> # EDKII System Capsule library instance for DXE/PEI post memory phase.
> #
> -# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> # which accompanies this distribution. The full text of the license may be
> found at
> @@ -53,9 +53,9 @@
> gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer
> ## CONSUMES
>
> [Guids]
> - gEdkiiSystemFirmwareImageDescriptorFileGuid ## CONSUMES
> ## GUID
> - gEdkiiSystemFmpCapsuleConfigFileGuid ## CONSUMES
> ## GUID
> - gEdkiiSystemFmpCapsuleDriverFvFileGuid ## CONSUMES
> ## GUID
> - gEfiCertPkcs7Guid ## CONSUMES
> ## GUID
> - gEfiCertTypeRsa2048Sha256Guid ## CONSUMES
> ## GUID
> + gEdkiiSystemFirmwareImageDescriptorFileGuid ##
> SOMETIMES_CONSUMES ## GUID
> + gEdkiiSystemFmpCapsuleConfigFileGuid ##
> SOMETIMES_CONSUMES ## GUID
> + gEdkiiSystemFmpCapsuleDriverFvFileGuid ##
> SOMETIMES_CONSUMES ## GUID
> + gEfiCertPkcs7Guid ##
> SOMETIMES_CONSUMES ## GUID
> + gEfiCertTypeRsa2048Sha256Guid ##
> SOMETIMES_CONSUMES ## GUID
>
> --
> 2.8.0.windows.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Patch 08/11] SecurityPkg: Update Guid usage in INF file to match source code logic
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
` (6 preceding siblings ...)
2017-09-25 11:06 ` [Patch 07/11] SignedCapsulePkg: Update Guid " Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-10-10 8:39 ` Zhang, Chao B
2017-09-25 11:06 ` [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files Liming Gao
` (2 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
---
.../FmpAuthenticationLibRsa2048Sha256.inf | 6 +++---
.../Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
index 633f407..b190eca 100644
--- a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
+++ b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
@@ -3,7 +3,7 @@
#
# Instance of FmpAuthentication Library for DXE/PEI post memory phase.
#
-# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
@@ -49,5 +49,5 @@
gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer ## CONSUMES
[Guids]
- gEfiCertTypeRsa2048Sha256Guid ## CONSUMES ## GUID
- gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
+ gEfiCertTypeRsa2048Sha256Guid ## SOMETIMES_CONSUMES ## GUID # Unique ID for the type of the certificate.
+ gEfiHashAlgorithmSha256Guid ## SOMETIMES_CONSUMES ## GUID
diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
index eebf90e..018090b 100644
--- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
+++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
@@ -51,7 +51,7 @@
HobLib
[Guids]
- ## CONSUMES ## GUID
+ ## SOMETIMES_CONSUMES ## GUID
gZeroGuid
[Pcd]
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 08/11] SecurityPkg: Update Guid usage in INF file to match source code logic
2017-09-25 11:06 ` [Patch 08/11] SecurityPkg: " Liming Gao
@ 2017-10-10 8:39 ` Zhang, Chao B
0 siblings, 0 replies; 25+ messages in thread
From: Zhang, Chao B @ 2017-10-10 8:39 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
-----Original Message-----
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B <chao.b.zhang@intel.com>
Subject: [Patch 08/11] SecurityPkg: Update Guid usage in INF file to match source code logic
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
---
.../FmpAuthenticationLibRsa2048Sha256.inf | 6 +++---
.../Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
index 633f407..b190eca 100644
--- a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
+++ b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthentic
+++ ationLibRsa2048Sha256.inf
@@ -3,7 +3,7 @@
#
# Instance of FmpAuthentication Library for DXE/PEI post memory phase.
#
-# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2017, Intel Corporation. All rights
+reserved.<BR>
# This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -49,5 +49,5 @@
gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer ## CONSUMES
[Guids]
- gEfiCertTypeRsa2048Sha256Guid ## CONSUMES ## GUID
- gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
+ gEfiCertTypeRsa2048Sha256Guid ## SOMETIMES_CONSUMES ## GUID # Unique ID for the type of the certificate.
+ gEfiHashAlgorithmSha256Guid ## SOMETIMES_CONSUMES ## GUID
diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
index eebf90e..018090b 100644
--- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
+++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRoute
+++ rPei.inf
@@ -51,7 +51,7 @@
HobLib
[Guids]
- ## CONSUMES ## GUID
+ ## SOMETIMES_CONSUMES ## GUID
gZeroGuid
[Pcd]
--
2.8.0.windows.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
` (7 preceding siblings ...)
2017-09-25 11:06 ` [Patch 08/11] SecurityPkg: " Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-10-10 6:58 ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage " Liming Gao
2017-09-25 11:06 ` [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid " Liming Gao
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf | 3 +--
.../Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf | 6 +++---
IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf | 6 +++---
3 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf b/IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf
index 75f7ae5..a0bc375 100644
--- a/IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf
+++ b/IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf
@@ -1,8 +1,7 @@
## @file
# Component information file for the FSP notify phase PEI module.
#
-#@copyright
-# Copyright (c) 2016 Intel Corporation. All rights reserved.
+# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
diff --git a/IntelFsp2Pkg/Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf b/IntelFsp2Pkg/Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf
index bdb6744..6a77ce7 100644
--- a/IntelFsp2Pkg/Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf
+++ b/IntelFsp2Pkg/Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf
@@ -1,7 +1,7 @@
## @file
# NULL instance of Base cache as RAM.
#
-# Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -12,7 +12,7 @@
#
##
-[defines]
+[Defines]
INF_VERSION = 0x00010005
BASE_NAME = BaseCacheAsRamLibNull
FILE_GUID = 630AEB10-2106-4234-9DB3-836A3663F50D
@@ -20,7 +20,7 @@
VERSION_STRING = 1.0
LIBRARY_CLASS = CacheAsRamLib
-[sources.common]
+[Sources.common]
DisableCacheAsRamNull.c
[Packages]
diff --git a/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf b/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf
index 7b026b1..34df6ad 100644
--- a/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf
+++ b/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf
@@ -1,7 +1,7 @@
## @file
# Instance of BaseCache.
#
-# Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -12,7 +12,7 @@
#
##
-[defines]
+[Defines]
INF_VERSION = 0x00010005
BASE_NAME = BaseCacheLib
FILE_GUID = 8EF3A653-DA8B-4FFA-BB85-FF47406DB9F0
@@ -20,7 +20,7 @@
VERSION_STRING = 1.0
LIBRARY_CLASS = CacheLib
-[sources.IA32]
+[Sources.IA32]
CacheLib.c
CacheLibInternal.h
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files
2017-09-25 11:06 ` [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files Liming Gao
@ 2017-10-10 6:58 ` Yao, Jiewen
0 siblings, 0 replies; 25+ messages in thread
From: Yao, Jiewen @ 2017-10-10 6:58 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, September 25, 2017 7:06 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
> IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf | 3
> +--
> .../Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf | 6
> +++---
> IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf | 6
> +++---
> 3 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf
> b/IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf
> index 75f7ae5..a0bc375 100644
> --- a/IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf
> +++ b/IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf
> @@ -1,8 +1,7 @@
> ## @file
> # Component information file for the FSP notify phase PEI module.
> #
> -#@copyright
> -# Copyright (c) 2016 Intel Corporation. All rights reserved.
> +# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> # which accompanies this distribution. The full text of the license may be
> found at
> diff --git
> a/IntelFsp2Pkg/Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf
> b/IntelFsp2Pkg/Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf
> index bdb6744..6a77ce7 100644
> --- a/IntelFsp2Pkg/Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf
> +++
> b/IntelFsp2Pkg/Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf
> @@ -1,7 +1,7 @@
> ## @file
> # NULL instance of Base cache as RAM.
> #
> -# Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> @@ -12,7 +12,7 @@
> #
> ##
>
> -[defines]
> +[Defines]
> INF_VERSION = 0x00010005
> BASE_NAME = BaseCacheAsRamLibNull
> FILE_GUID =
> 630AEB10-2106-4234-9DB3-836A3663F50D
> @@ -20,7 +20,7 @@
> VERSION_STRING = 1.0
> LIBRARY_CLASS = CacheAsRamLib
>
> -[sources.common]
> +[Sources.common]
> DisableCacheAsRamNull.c
>
> [Packages]
> diff --git a/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf
> b/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf
> index 7b026b1..34df6ad 100644
> --- a/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf
> +++ b/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf
> @@ -1,7 +1,7 @@
> ## @file
> # Instance of BaseCache.
> #
> -# Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> @@ -12,7 +12,7 @@
> #
> ##
>
> -[defines]
> +[Defines]
> INF_VERSION = 0x00010005
> BASE_NAME = BaseCacheLib
> FILE_GUID =
> 8EF3A653-DA8B-4FFA-BB85-FF47406DB9F0
> @@ -20,7 +20,7 @@
> VERSION_STRING = 1.0
> LIBRARY_CLASS = CacheLib
>
> -[sources.IA32]
> +[Sources.IA32]
> CacheLib.c
> CacheLibInternal.h
>
> --
> 2.8.0.windows.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage in INF files
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
` (8 preceding siblings ...)
2017-09-25 11:06 ` [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-10-10 6:58 ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid " Liming Gao
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf | 6 +++---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 9 ++-------
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 6 +++---
.../Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf | 4 ++--
4 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
index 54c2cbf..ce3bfa0 100644
--- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
+++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
@@ -3,7 +3,7 @@
#
# This driver will register two callbacks to call fsp's notifies.
#
-# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -53,10 +53,10 @@
[Protocols]
gEfiPciEnumerationCompleteProtocolGuid ## CONSUMES
- gAddPerfRecordProtocolGuid ## CONSUMES
+ gAddPerfRecordProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
- gFspApiPerformanceGuid ## CONSUMES ## GUID
+ gFspApiPerformanceGuid ## SOMETIMES_CONSUMES ## GUID
gEfiEventExitBootServicesGuid ## CONSUMES ## Event
gFspHobGuid ## CONSUMES ## HOB
diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
index 0901a14..2b3d240 100644
--- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
+++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
@@ -6,7 +6,7 @@
# register TemporaryRamDonePpi to call TempRamExit API, and register MemoryDiscoveredPpi
# notify to call FspSiliconInit API.
#
-# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -64,14 +64,9 @@
[Sources]
FspmWrapperPeim.c
-[Ppis]
- gTopOfTemporaryRamPpiGuid ## PRODUCES
- gEfiEndOfPeiSignalPpiGuid ## PRODUCES
- gEfiPeiMemoryDiscoveredPpiGuid ## PRODUCES
-
[Guids]
gFspHobGuid ## PRODUCES ## HOB
- gFspApiPerformanceGuid ## CONSUMES ## GUID
+ gFspApiPerformanceGuid ## SOMETIMES_CONSUMES ## GUID
[Depex]
gEfiPeiMasterBootModePpiGuid
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
index 261278f..c858e70 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
@@ -6,7 +6,7 @@
# register TemporaryRamDonePpi to call TempRamExit API, and register MemoryDiscoveredPpi
# notify to call FspSiliconInit API.
#
-# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -63,14 +63,14 @@
gFspSiliconInitDonePpiGuid ## PRODUCES
gEfiEndOfPeiSignalPpiGuid ## PRODUCES
gEfiTemporaryRamDonePpiGuid ## PRODUCES
- gEfiPeiMemoryDiscoveredPpiGuid ## PRODUCES
+ gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
[Pcd]
gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress ## CONSUMES
[Guids]
gFspHobGuid ## CONSUMES ## HOB
- gFspApiPerformanceGuid ## CONSUMES ## GUID
+ gFspApiPerformanceGuid ## SOMETIMES_CONSUMES ## GUID
[Sources]
FspsWrapperPeim.c
diff --git a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf b/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf
index fbbcf30..1a5029b 100644
--- a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf
+++ b/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf
@@ -1,7 +1,7 @@
### @file
# Provide FSP-M wrapper API test related function.
#
-# Copyright (C) 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (C) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -53,4 +53,4 @@
HobLib
[Guids]
- gFspBootLoaderTolumHobGuid ## CONSUMES ## GUID
\ No newline at end of file
+ gFspBootLoaderTolumHobGuid ## SOMETIMES_CONSUMES ## GUID
\ No newline at end of file
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage in INF files
2017-09-25 11:06 ` [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage " Liming Gao
@ 2017-10-10 6:58 ` Yao, Jiewen
0 siblings, 0 replies; 25+ messages in thread
From: Yao, Jiewen @ 2017-10-10 6:58 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, September 25, 2017 7:06 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage in INF
> files
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
> IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf | 6
> +++---
> IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 9
> ++-------
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 6
> +++---
> .../Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf | 4 ++--
> 4 files changed, 10 insertions(+), 15 deletions(-)
>
> diff --git
> a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
> b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
> index 54c2cbf..ce3bfa0 100644
> --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
> +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
> @@ -3,7 +3,7 @@
> #
> # This driver will register two callbacks to call fsp's notifies.
> #
> -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> @@ -53,10 +53,10 @@
>
> [Protocols]
> gEfiPciEnumerationCompleteProtocolGuid ## CONSUMES
> - gAddPerfRecordProtocolGuid ## CONSUMES
> + gAddPerfRecordProtocolGuid ##
> SOMETIMES_CONSUMES
>
> [Guids]
> - gFspApiPerformanceGuid ## CONSUMES ##
> GUID
> + gFspApiPerformanceGuid ##
> SOMETIMES_CONSUMES ## GUID
> gEfiEventExitBootServicesGuid ## CONSUMES ##
> Event
> gFspHobGuid ## CONSUMES ##
> HOB
>
> diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> index 0901a14..2b3d240 100644
> --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> @@ -6,7 +6,7 @@
> # register TemporaryRamDonePpi to call TempRamExit API, and register
> MemoryDiscoveredPpi
> # notify to call FspSiliconInit API.
> #
> -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> @@ -64,14 +64,9 @@
> [Sources]
> FspmWrapperPeim.c
>
> -[Ppis]
> - gTopOfTemporaryRamPpiGuid ## PRODUCES
> - gEfiEndOfPeiSignalPpiGuid ## PRODUCES
> - gEfiPeiMemoryDiscoveredPpiGuid ## PRODUCES
> -
> [Guids]
> gFspHobGuid ## PRODUCES ## HOB
> - gFspApiPerformanceGuid ## CONSUMES ## GUID
> + gFspApiPerformanceGuid ## SOMETIMES_CONSUMES ##
> GUID
>
> [Depex]
> gEfiPeiMasterBootModePpiGuid
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> index 261278f..c858e70 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> @@ -6,7 +6,7 @@
> # register TemporaryRamDonePpi to call TempRamExit API, and register
> MemoryDiscoveredPpi
> # notify to call FspSiliconInit API.
> #
> -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> @@ -63,14 +63,14 @@
> gFspSiliconInitDonePpiGuid ## PRODUCES
> gEfiEndOfPeiSignalPpiGuid ## PRODUCES
> gEfiTemporaryRamDonePpiGuid ## PRODUCES
> - gEfiPeiMemoryDiscoveredPpiGuid ## PRODUCES
> + gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
>
> [Pcd]
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress ## CONSUMES
>
> [Guids]
> gFspHobGuid ## CONSUMES ## HOB
> - gFspApiPerformanceGuid ## CONSUMES ## GUID
> + gFspApiPerformanceGuid ## SOMETIMES_CONSUMES ##
> GUID
>
> [Sources]
> FspsWrapperPeim.c
> diff --git
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTes
> tLib.inf
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTe
> stLib.inf
> index fbbcf30..1a5029b 100644
> ---
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTes
> tLib.inf
> +++
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTe
> stLib.inf
> @@ -1,7 +1,7 @@
> ### @file
> # Provide FSP-M wrapper API test related function.
> #
> -# Copyright (C) 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (C) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> @@ -53,4 +53,4 @@
> HobLib
>
> [Guids]
> - gFspBootLoaderTolumHobGuid ## CONSUMES ## GUID
> \ No newline at end of file
> + gFspBootLoaderTolumHobGuid ## SOMETIMES_CONSUMES ##
> GUID
> \ No newline at end of file
> --
> 2.8.0.windows.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid usage in INF files
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
` (9 preceding siblings ...)
2017-09-25 11:06 ` [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage " Liming Gao
@ 2017-09-25 11:06 ` Liming Gao
2017-09-25 11:18 ` Zeng, Star
10 siblings, 1 reply; 25+ messages in thread
From: Liming Gao @ 2017-09-25 11:06 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
MdeModulePkg/Core/Dxe/DxeMain.inf | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 2 +-
.../BootMaintenanceManagerUiLib.inf | 4 +---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 8 +++++---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 8 +++++---
MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf | 10 +++++-----
MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf | 2 +-
MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 2 +-
MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf | 4 ++--
MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf | 2 +-
10 files changed, 23 insertions(+), 21 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf
index 30d5984..e29d6c8 100644
--- a/MdeModulePkg/Core/Dxe/DxeMain.inf
+++ b/MdeModulePkg/Core/Dxe/DxeMain.inf
@@ -107,7 +107,7 @@
## CONSUMES ## Event
## PRODUCES ## Event
gEfiEventExitBootServicesGuid
- gEfiHobMemoryAllocModuleGuid ## CONSUMES ## HOB
+ gEfiHobMemoryAllocModuleGuid ## SOMETIMES_CONSUMES ## HOB
gEfiFirmwareFileSystem2Guid ## CONSUMES ## GUID # Used to compare with FV's file system guid and get the FV's file system format
gEfiFirmwareFileSystem3Guid ## CONSUMES ## GUID # Used to compare with FV's file system guid and get the FV's file system format
gAprioriGuid ## SOMETIMES_CONSUMES ## File
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
index 95e34bd..49ae6fb 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
@@ -109,7 +109,7 @@
gEdkiiMemoryProfileGuid
## SOMETIMES_PRODUCES ## GUID # Install protocol
gEdkiiSmmMemoryProfileGuid
- gEdkiiPiSmmMemoryAttributesTableGuid ## SOMETIMES_PRODUCES ## SystemTable
+ gEdkiiPiSmmMemoryAttributesTableGuid ## PRODUCES ## SystemTable
## SOMETIMES_CONSUMES ## SystemTable
gLoadFixedAddressConfigurationTableGuid
## SOMETIMES_PRODUCES ## GUID # Install protocol
diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
index 1c0c0e1..def923b 100644
--- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
+++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
@@ -79,9 +79,7 @@
## SOMETIMES_CONSUMES ## Variable:L"ConIn" (The device path of console in device)
## SOMETIMES_CONSUMES ## Variable:L"ConOut" (The device path of console out device)
## SOMETIMES_CONSUMES ## Variable:L"ErrOut" (The device path of error out device)
- gEfiFileSystemVolumeLabelInfoIdGuid ## CONSUMES ## GUID (Indicate the information type is volume)
- gEfiFileInfoGuid ## CONSUMES ## GUID (Indicate the information type is file)
- gEfiIfrTianoGuid ## CONSUMES ## GUID (Extended IFR Guid Opcode)
+ gEfiIfrTianoGuid ## SOMETIMES_CONSUMES ## GUID (Extended IFR Guid Opcode)
gEfiIfrFrontPageGuid ## CONSUMES ## GUID
gEfiIfrBootMaintenanceGuid ## CONSUMES ## GUID
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
index a6cf54c..a7c3699 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
@@ -66,15 +66,17 @@
[Protocols]
gEsrtManagementProtocolGuid ## CONSUMES
- gEfiFirmwareManagementProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiFirmwareManagementProtocolGuid ## CONSUMES
gEdkiiVariableLockProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
gEfiFmpCapsuleGuid ## SOMETIMES_CONSUMES ## GUID
gWindowsUxCapsuleGuid ## SOMETIMES_CONSUMES ## GUID
gEfiSystemResourceTableGuid ## SOMETIMES_CONSUMES ## GUID
- gEfiCapsuleReportGuid ## CONSUMES ## Variable
- gEfiCapsuleVendorGuid ## CONSUMES ## Variable
+ ## SOMETIMES_CONSUMES ## Variable:L"CapsuleMax"
+ ## SOMETIMES_PRODUCES ## Variable:L"CapsuleMax"
+ gEfiCapsuleReportGuid
+ gEfiCapsuleVendorGuid ## SOMETIMES_CONSUMES ## Variable:L"CapsuleUpdateData"
gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event
[Depex]
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
index 25b7d51..4191675 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
@@ -69,15 +69,17 @@
[Protocols]
gEsrtManagementProtocolGuid ## CONSUMES
- gEfiFirmwareManagementProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiFirmwareManagementProtocolGuid ## CONSUMES
gEdkiiVariableLockProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
gEfiFmpCapsuleGuid ## SOMETIMES_CONSUMES ## GUID
gWindowsUxCapsuleGuid ## SOMETIMES_CONSUMES ## GUID
gEfiSystemResourceTableGuid ## SOMETIMES_CONSUMES ## GUID
- gEfiCapsuleReportGuid ## CONSUMES ## Variable
- gEfiCapsuleVendorGuid ## CONSUMES ## Variable
+ ## SOMETIMES_CONSUMES ## Variable:L"CapsuleMax"
+ ## SOMETIMES_PRODUCES ## Variable:L"CapsuleMax"
+ gEfiCapsuleReportGuid
+ gEfiCapsuleVendorGuid ## SOMETIMES_CONSUMES ## Variable:L"CapsuleUpdateData"
gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event
gEfiEventVirtualAddressChangeGuid ## CONSUMES ## Event
diff --git a/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf b/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
index c292aa2..75071d9 100644
--- a/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
+++ b/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
@@ -50,14 +50,14 @@
UefiHiiServicesLib
[Guids]
- gEfiFileSystemVolumeLabelInfoIdGuid ## CONSUMES ## GUID (Indicate the information type is volume)
- gEfiIfrTianoGuid ## CONSUMES ## GUID (Extended IFR Guid Opcode)
+ gEfiFileSystemVolumeLabelInfoIdGuid ## SOMETIMES_CONSUMES ## GUID (Indicate the information type is volume)
+ gEfiIfrTianoGuid ## SOMETIMES_CONSUMES ## GUID (Extended IFR Guid Opcode)
[Protocols]
- gEfiSimpleFileSystemProtocolGuid ## CONSUMES
- gEfiHiiConfigAccessProtocolGuid ## CONSUMES
+ gEfiSimpleFileSystemProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiHiiConfigAccessProtocolGuid ## PRODUCES
gEfiFormBrowser2ProtocolGuid ## CONSUMES
- gEfiDevicePathToTextProtocolGuid ## CONSUMES
+ gEfiDevicePathToTextProtocolGuid ## PRODUCES
[Depex.common.DXE_DRIVER]
gEfiFormBrowser2ProtocolGuid AND gEfiHiiDatabaseProtocolGuid
\ No newline at end of file
diff --git a/MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf b/MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
index 32c02b0..4c3d5e0 100644
--- a/MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
+++ b/MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
@@ -42,6 +42,6 @@
DevicePathLib
[Protocols]
- gEfiUnicodeCollation2ProtocolGuid ## CONSUMES
+ gEfiUnicodeCollation2ProtocolGuid ## SOMETIMES_CONSUMES
gEfiDevicePathProtocolGuid ## CONSUMES
diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf
index 2c66f15..06b3a08 100644
--- a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf
+++ b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf
@@ -58,7 +58,7 @@
[Protocols]
gEfiFirmwareManagementProtocolGuid ## SOMETIMES_CONSUMES
gEsrtManagementProtocolGuid ## PRODUCES
- gEdkiiVariableLockProtocolGuid ## CONSUMES
+ gEdkiiVariableLockProtocolGuid ## SOMETIMES_CONSUMES
[Pcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxFmpEsrtCacheNum ## CONSUMES
diff --git a/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf b/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
index 7f8f6cb..c5553a3 100644
--- a/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
+++ b/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
@@ -1,7 +1,7 @@
## @file
# This driver produces security2 and security architectural protocol based on SecurityManagementLib.
#
-# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
@@ -51,7 +51,7 @@
gEfiSecurityArchProtocolGuid ## PRODUCES
gEfiSecurity2ArchProtocolGuid ## PRODUCES
gEfiDeferredImageLoadProtocolGuid ## PRODUCES
- gEfiDxeSmmReadyToLockProtocolGuid ## CONSUMES
+ gEfiDxeSmmReadyToLockProtocolGuid ## NOTIFY
[Depex]
TRUE
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf b/MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
index fefaefe..f7b53ea 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
@@ -77,7 +77,7 @@
## NOTIFY
gEdkiiFormDisplayEngineProtocolGuid
gEdkiiFormBrowserExProtocolGuid ## PRODUCES
- gEfiRegularExpressionProtocolGuid ## CONSUMES
+ gEfiRegularExpressionProtocolGuid ## SOMETIMES_CONSUMES
[FeaturePcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport ## CONSUMES
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid usage in INF files
2017-09-25 11:06 ` [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid " Liming Gao
@ 2017-09-25 11:18 ` Zeng, Star
0 siblings, 0 replies; 25+ messages in thread
From: Zeng, Star @ 2017-09-25 11:18 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Dong, Eric, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Gao, Liming
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid usage in INF files
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
MdeModulePkg/Core/Dxe/DxeMain.inf | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 2 +-
.../BootMaintenanceManagerUiLib.inf | 4 +---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 8 +++++---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 8 +++++---
MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf | 10 +++++-----
MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf | 2 +-
MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 2 +-
MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf | 4 ++--
MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf | 2 +-
10 files changed, 23 insertions(+), 21 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf
index 30d5984..e29d6c8 100644
--- a/MdeModulePkg/Core/Dxe/DxeMain.inf
+++ b/MdeModulePkg/Core/Dxe/DxeMain.inf
@@ -107,7 +107,7 @@
## CONSUMES ## Event
## PRODUCES ## Event
gEfiEventExitBootServicesGuid
- gEfiHobMemoryAllocModuleGuid ## CONSUMES ## HOB
+ gEfiHobMemoryAllocModuleGuid ## SOMETIMES_CONSUMES ## HOB
gEfiFirmwareFileSystem2Guid ## CONSUMES ## GUID # Used to compare with FV's file system guid and get the FV's file system format
gEfiFirmwareFileSystem3Guid ## CONSUMES ## GUID # Used to compare with FV's file system guid and get the FV's file system format
gAprioriGuid ## SOMETIMES_CONSUMES ## File
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
index 95e34bd..49ae6fb 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
@@ -109,7 +109,7 @@
gEdkiiMemoryProfileGuid
## SOMETIMES_PRODUCES ## GUID # Install protocol
gEdkiiSmmMemoryProfileGuid
- gEdkiiPiSmmMemoryAttributesTableGuid ## SOMETIMES_PRODUCES ## SystemTable
+ gEdkiiPiSmmMemoryAttributesTableGuid ## PRODUCES ## SystemTable
## SOMETIMES_CONSUMES ## SystemTable
gLoadFixedAddressConfigurationTableGuid
## SOMETIMES_PRODUCES ## GUID # Install protocol
diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
index 1c0c0e1..def923b 100644
--- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
+++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceMa
+++ nagerUiLib.inf
@@ -79,9 +79,7 @@
## SOMETIMES_CONSUMES ## Variable:L"ConIn" (The device path of console in device)
## SOMETIMES_CONSUMES ## Variable:L"ConOut" (The device path of console out device)
## SOMETIMES_CONSUMES ## Variable:L"ErrOut" (The device path of error out device)
- gEfiFileSystemVolumeLabelInfoIdGuid ## CONSUMES ## GUID (Indicate the information type is volume)
- gEfiFileInfoGuid ## CONSUMES ## GUID (Indicate the information type is file)
- gEfiIfrTianoGuid ## CONSUMES ## GUID (Extended IFR Guid Opcode)
+ gEfiIfrTianoGuid ## SOMETIMES_CONSUMES ## GUID (Extended IFR Guid Opcode)
gEfiIfrFrontPageGuid ## CONSUMES ## GUID
gEfiIfrBootMaintenanceGuid ## CONSUMES ## GUID
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
index a6cf54c..a7c3699 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
@@ -66,15 +66,17 @@
[Protocols]
gEsrtManagementProtocolGuid ## CONSUMES
- gEfiFirmwareManagementProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiFirmwareManagementProtocolGuid ## CONSUMES
gEdkiiVariableLockProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
gEfiFmpCapsuleGuid ## SOMETIMES_CONSUMES ## GUID
gWindowsUxCapsuleGuid ## SOMETIMES_CONSUMES ## GUID
gEfiSystemResourceTableGuid ## SOMETIMES_CONSUMES ## GUID
- gEfiCapsuleReportGuid ## CONSUMES ## Variable
- gEfiCapsuleVendorGuid ## CONSUMES ## Variable
+ ## SOMETIMES_CONSUMES ## Variable:L"CapsuleMax"
+ ## SOMETIMES_PRODUCES ## Variable:L"CapsuleMax"
+ gEfiCapsuleReportGuid
+ gEfiCapsuleVendorGuid ## SOMETIMES_CONSUMES ## Variable:L"CapsuleUpdateData"
gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event
[Depex]
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
index 25b7d51..4191675 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
@@ -69,15 +69,17 @@
[Protocols]
gEsrtManagementProtocolGuid ## CONSUMES
- gEfiFirmwareManagementProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiFirmwareManagementProtocolGuid ## CONSUMES
gEdkiiVariableLockProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
gEfiFmpCapsuleGuid ## SOMETIMES_CONSUMES ## GUID
gWindowsUxCapsuleGuid ## SOMETIMES_CONSUMES ## GUID
gEfiSystemResourceTableGuid ## SOMETIMES_CONSUMES ## GUID
- gEfiCapsuleReportGuid ## CONSUMES ## Variable
- gEfiCapsuleVendorGuid ## CONSUMES ## Variable
+ ## SOMETIMES_CONSUMES ## Variable:L"CapsuleMax"
+ ## SOMETIMES_PRODUCES ## Variable:L"CapsuleMax"
+ gEfiCapsuleReportGuid
+ gEfiCapsuleVendorGuid ## SOMETIMES_CONSUMES ## Variable:L"CapsuleUpdateData"
gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event
gEfiEventVirtualAddressChangeGuid ## CONSUMES ## Event
diff --git a/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf b/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
index c292aa2..75071d9 100644
--- a/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
+++ b/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
@@ -50,14 +50,14 @@
UefiHiiServicesLib
[Guids]
- gEfiFileSystemVolumeLabelInfoIdGuid ## CONSUMES ## GUID (Indicate the information type is volume)
- gEfiIfrTianoGuid ## CONSUMES ## GUID (Extended IFR Guid Opcode)
+ gEfiFileSystemVolumeLabelInfoIdGuid ## SOMETIMES_CONSUMES ## GUID (Indicate the information type is volume)
+ gEfiIfrTianoGuid ## SOMETIMES_CONSUMES ## GUID (Extended IFR Guid Opcode)
[Protocols]
- gEfiSimpleFileSystemProtocolGuid ## CONSUMES
- gEfiHiiConfigAccessProtocolGuid ## CONSUMES
+ gEfiSimpleFileSystemProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiHiiConfigAccessProtocolGuid ## PRODUCES
gEfiFormBrowser2ProtocolGuid ## CONSUMES
- gEfiDevicePathToTextProtocolGuid ## CONSUMES
+ gEfiDevicePathToTextProtocolGuid ## PRODUCES
[Depex.common.DXE_DRIVER]
gEfiFormBrowser2ProtocolGuid AND gEfiHiiDatabaseProtocolGuid \ No newline at end of file diff --git a/MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf b/MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
index 32c02b0..4c3d5e0 100644
--- a/MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
+++ b/MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
@@ -42,6 +42,6 @@
DevicePathLib
[Protocols]
- gEfiUnicodeCollation2ProtocolGuid ## CONSUMES
+ gEfiUnicodeCollation2ProtocolGuid ## SOMETIMES_CONSUMES
gEfiDevicePathProtocolGuid ## CONSUMES
diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf
index 2c66f15..06b3a08 100644
--- a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf
+++ b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf
@@ -58,7 +58,7 @@
[Protocols]
gEfiFirmwareManagementProtocolGuid ## SOMETIMES_CONSUMES
gEsrtManagementProtocolGuid ## PRODUCES
- gEdkiiVariableLockProtocolGuid ## CONSUMES
+ gEdkiiVariableLockProtocolGuid ## SOMETIMES_CONSUMES
[Pcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxFmpEsrtCacheNum ## CONSUMES
diff --git a/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf b/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
index 7f8f6cb..c5553a3 100644
--- a/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
+++ b/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
@@ -1,7 +1,7 @@
## @file
# This driver produces security2 and security architectural protocol based on SecurityManagementLib.
#
-# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2017, Intel Corporation. All rights
+reserved.<BR>
# This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -51,7 +51,7 @@
gEfiSecurityArchProtocolGuid ## PRODUCES
gEfiSecurity2ArchProtocolGuid ## PRODUCES
gEfiDeferredImageLoadProtocolGuid ## PRODUCES
- gEfiDxeSmmReadyToLockProtocolGuid ## CONSUMES
+ gEfiDxeSmmReadyToLockProtocolGuid ## NOTIFY
[Depex]
TRUE
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf b/MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
index fefaefe..f7b53ea 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
@@ -77,7 +77,7 @@
## NOTIFY
gEdkiiFormDisplayEngineProtocolGuid
gEdkiiFormBrowserExProtocolGuid ## PRODUCES
- gEfiRegularExpressionProtocolGuid ## CONSUMES
+ gEfiRegularExpressionProtocolGuid ## SOMETIMES_CONSUMES
[FeaturePcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport ## CONSUMES
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread