From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EE6DA202E60E2 for ; Sun, 15 Oct 2017 23:21:33 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2017 23:25:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,385,1503385200"; d="scan'208";a="146863742" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 15 Oct 2017 23:25:06 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 15 Oct 2017 23:25:07 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 15 Oct 2017 23:25:06 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Mon, 16 Oct 2017 14:25:05 +0800 From: "Wu, Jiaxin" To: Karunakar P , "Fu, Siyuan" , "edk2-devel@lists.01.org" CC: "Ye, Ting" Thread-Topic: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attempt page even DHCP enabled. Thread-Index: AQHTQ+iwzIDKD7uhbk2BsLg0Fm5jmaLgydaAgABaqwCABN+eMA== Date: Mon, 16 Oct 2017 06:25:05 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B72741633E267@SHSMSX103.ccr.corp.intel.com> References: <1507874463-5684-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWU5YTcwOWItNzdjNi00ZjQ4LWExMGMtYjI4ZjlhM2ZmODZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFFTjQ0bTB0azdRXC9ZczlYTXdGdmJSbjJMUDhkeTdwMzYwVk11dW9uXC9wWT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attempt page even DHCP enabled. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 06:21:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Karunakar, Thanks the verification, I agree it's another iSCSI bug that exposed by thi= s patch.=20 In IScsiGetConfigData() function, The existing attempt will always trigger = the DHCP process if Initiator DHCP enabled no matter it associates with the= current NIC or not. That's incorrect and unreasonable as you overserved if= we display the InitiatorInfo in attempt page. I will send another separated but series patch to fix this issue. Thanks, Jiaxin > -----Original Message----- > From: Karunakar P [mailto:karunakarp@amiindia.co.in] > Sent: Friday, October 13, 2017 7:49 PM > To: Fu, Siyuan ; Wu, Jiaxin ; > edk2-devel@lists.01.org > Cc: Ye, Ting > Subject: RE: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attemp= t > page even DHCP enabled. >=20 > Hi Jiaxin/Siyuan, >=20 > I've verified Initiator details with this changes. >=20 > I found an issue like Initiator Details are shown for Connection less NIC >=20 > Please find below details for more details >=20 > [Issue details and steps to reproduce] > 1. SUT have 2 LAN ports > MAC XX:XX:XX:XX:XX:AA -> LAN Cable NOT connected to this port, = i.e. > Link Status is Disconnected > MAC XX:XX:XX:XX:XX:BB -> LAN Cable Connected to this port, i.e= . Link > Status is Connected >=20 > 2. I've added two attempts > a. Attempt1 added to connection less NIC (MAC XX:XX:XX:XX:XX:AA ) > b. Attempt2 added to connected NIC (MAC XX:XX:XX:XX:XX:BB ) >=20 > [Observations] > 1. Initiator IP Address and Subnet Mask displayed for both Attempt1 and > Attempt2 >=20 > Could you please comment on this observation? >=20 > Thanks, > Karunakar >=20 > -----Original Message----- > From: Fu, Siyuan [mailto:siyuan.fu@intel.com] > Sent: Friday, October 13, 2017 11:54 AM > To: Wu, Jiaxin; edk2-devel@lists.01.org > Cc: Karunakar P; Ye, Ting > Subject: RE: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attemp= t > page even DHCP enabled. >=20 > Reviewed-by: Fu Siyuan >=20 > -----Original Message----- > From: Wu, Jiaxin > Sent: Friday, October 13, 2017 2:01 PM > To: edk2-devel@lists.01.org > Cc: Karunakar P ; Ye, Ting = ; > Fu, Siyuan ; Wu, Jiaxin > Subject: [Patch] NetworkPkg/IScsiDxe: Display InitiatorInfo in attempt pa= ge > even DHCP enabled. >=20 > Cc: Karunakar P > Cc: Ye Ting > Cc: Fu Siyuan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Wu Jiaxin > --- > NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr > b/NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr > index d401419..35e8f9a 100644 > --- a/NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr > +++ b/NetworkPkg/IScsiDxe/IScsiConfigVfr.vfr > @@ -189,13 +189,14 @@ formset > flags =3D INTERACTIVE, > key =3D KEY_DHCP_ENABLE, > endcheckbox; > endif; >=20 > - suppressif ideqval ISCSI_CONFIG_IFR_NVDATA.InitiatorInfoFromDhcp =3D= =3D > 0x01 OR > - ideqval ISCSI_CONFIG_IFR_NVDATA.IpMode =3D=3D IP_MODE_IP6= OR > + suppressif ideqval ISCSI_CONFIG_IFR_NVDATA.IpMode =3D=3D IP_MODE_IP6 > OR > ideqval ISCSI_CONFIG_IFR_NVDATA.IpMode =3D=3D > IP_MODE_AUTOCONFIG; > + > + grayoutif ideqval ISCSI_CONFIG_IFR_NVDATA.InitiatorInfoFromDhcp =3D= =3D > 0x01; > string varid =3D ISCSI_CONFIG_IFR_NVDATA.LocalIp, > prompt =3D STRING_TOKEN(STR_ISCSI_LOCAL_IP_ADDRESS), > help =3D STRING_TOKEN(STR_ISCSI_IP_ADDRESS_HELP), > flags =3D INTERACTIVE, > key =3D KEY_LOCAL_IP, > @@ -218,10 +219,11 @@ formset > flags =3D INTERACTIVE, > key =3D KEY_GATE_WAY, > minsize =3D IP4_MIN_SIZE, > maxsize =3D IP4_MAX_SIZE, > endstring; > + endif; >=20 > endif; >=20 > suppressif ideqval ISCSI_CONFIG_IFR_NVDATA.IpMode =3D=3D > IP_MODE_AUTOCONFIG; > subtitle text =3D STRING_TOKEN(STR_NULL); > -- > 1.9.5.msysgit.1