Re: SCT Test crashes After HTTPS boot success.

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Hi Karunakar,

I didn't see the SCT crash issue but also see the TLS test failure you attached.

For the failure, it's related to the EFI compliant test. According the UEFI Spec, section of 2.6.2:

If the network environment requires TLS features,
EFI_TLS_SERVICE_BINDING_PROTOCOL,EFI_TLS_PROTOCOL and
EFI_TLS_CONFIGURATION_PROTOCOL are required.

So, the SCT will check the EFI_TLS_SERVICE_BINDING_PROTOCOL, EFI_TLS_PROTOCOL and EFI_TLS_CONFIGURATION_PROTOCOL, but it didn't find the EFI_TLS_PROTOCOL and EFI_TLS_CONFIGURATION_PROTOCOL because no available TLS instance is created by default since it's no driver dependency. Even you tried the HTTPS, the TLS instance will be destroyed after finishing the HTTPS boot process, that's the reason why it still fail after HTTPS boot.
  Status = gtBS->LocateProtocol (
                   &gEfiTlsConfigurationProtocolGuid,
                   NULL,
                   (VOID **) &Interface
                   );
  if (!EFI_ERROR (Status)) {
    ValueB = TRUE;
  } else {
    ValueB = FALSE;
  }

After talk with SCT expert (Jin, Eric <eric.jin@intel.com>) , we agree the Spec may need to be updated since it can mislead the caller.

Thanks,
Jiaxin


From: Karunakar P [mailto:karunakarp@amiindia.co.in]
Sent: Tuesday, November 21, 2017 7:55 PM
To: Wu, Jiaxin <jiaxin.wu@intel.com>; 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org>
Cc: Fu, Siyuan <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>
Subject: RE: SCT Test crashes After HTTPS boot success.


Hi Jiaxin,

I've done SCT Test After HTTPS Boot success(Release Mode), I'm facing the below failures


1.       GenericTest\EFICompliantTest - EFI Compliant - PXE_BC protocols and one of UNDI/SNP/MNP must be implemented if a platform supports to boot from a network device.

2.       GenericTest\EFICompliantTest - UEFI-Compliant - EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL must be implemented if a platform includes an NVM Express controller.

3.       GenericTest\EFICompliantTest - UEFI-Compliant - EFI_BLOCK_IO_PROTOCOL must be existed if the platform supports booting from a block-oriented NVM Express controller. EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL may be required.

4.       GenericTest\EFICompliantTest - EFI Compliant - SCSI_PASS_THRU protocol must be implemented if a platform includes an I/O system that uses SCSI command packets.

5.       GenericTest\EFICompliantTest - UEFI-Compliant \x13EFI_SCSI IO_PROTOCOL, EFI_Block IO_PROTOCOL and EFI_EXT_SCSI_PASS_THRU_PROTOCOL must be implemented if a platform supports booting from a SCSI peripheral device.

6.       GenericTest\EFICompliantTest - EFI Compliant - DEBUG_SUPPORT and DEBUG_PORT protocols must be implemented if a platform supports debugging capabilities.

7.       GenericTest\EFICompliantTest - UEFI-Compliant - EFI_ATA_PASS_THRU_PROTOCOL must be implemented if a platform includes an I/O subsystem that utilizes ATA command packets.

8.       GenericTest\EFICompliantTest - UEFI-Compliant - EFI_TLS_PROTOCOL, EFI_TLS_SERVICE_BINDING_PROTOCOL, EFI_TLS_CONFIGURATION_PROTOCOL must be existed if the platform supports TLS feature.

9.       GenericTest\EFICompliantTest - UEFI-Compliant - EFI_EAP_PROTOCOL, EFI_EAP_CONFIGURATION_PROTOCOL, EFI_EAP_MANAGEMENT2_PROTOCOL must be existed if the platform includes the ability to perform a wireless boot from a network device with EAP feature, and if this platform provides

10.   GenericTest\EFICompliantTest - UEFI-Compliant - EFI_BLUETOOTH_HC_PROTOCOL, EFI_BLUETOOTH_IO_PROTOCOL, EFI_BLUETOOTH_CONFIG_PROTOCOL must be existed if the platform supports classic Bluetooth.

I've attached the Test Report for reference.
Could you please provide your comments/suggestions on the failures?

Thanks,
Karunakar

From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]
Sent: Friday, November 17, 2017 12:05 PM
To: Karunakar P; 'edk2-devel@lists.01.org'
Cc: Fu, Siyuan; Ye, Ting
Subject: RE: SCT Test crashes After HTTPS boot success.

I will try to reproduce the issue with EDK2 trunk code, then feedback to you. Thanks the report.

Jiaxin

From: Karunakar P [mailto:karunakarp@amiindia.co.in]
Sent: Friday, November 17, 2017 2:32 PM
To: Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>; 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>>
Cc: Fu, Siyuan <siyuan.fu@intel.com<mailto:siyuan.fu@intel.com>>; Ye, Ting <ting.ye@intel.com<mailto:ting.ye@intel.com>>
Subject: RE: SCT Test crashes After HTTPS boot success.

Hi Jiaxin,

Below are the detailed steps for SCT test

[Steps to reproduce]
.
  5. Run SCT test

    a.  Execute the following commands to run SCT test on SUT
             sct -r

  sct -u
   b.  In Test Case Management page, Enable GenericTest
   c.  Press F9 to run the selected test case

[Observation]
synchronous exception occurred in SCT ,Attached the Log for reference.

Thanks,
Karunakar

From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]
Sent: Friday, November 17, 2017 6:01 AM
To: Karunakar P; 'edk2-devel@lists.01.org'
Cc: Fu, Siyuan; Ye, Ting
Subject: RE: SCT Test crashes After HTTPS boot success.

Hi Karunakar,

Can you provide more detailed info for the SCT test steps? The crash can happen after "Sct.efi -u" or need run any specific test case?

Thanks,
Jiaxin

From: Karunakar P [mailto:karunakarp@amiindia.co.in]
Sent: Thursday, November 16, 2017 4:48 PM
To: 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>>
Cc: Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>; Fu, Siyuan <siyuan.fu@intel.com<mailto:siyuan.fu@intel.com>>; Ye, Ting <ting.ye@intel.com<mailto:ting.ye@intel.com>>
Subject: SCT Test crashes After HTTPS boot success.

Hello All,

When I do SCT test, get the below failure
GenericTest\EFICompliantTest 0 0 CB6F7B77-0B15-43F7-A95B-8C7F9FD70B21 FAIL UEFI Compliant - TLS support is required

The reason for the failure is that the platform doesn't have TLS related protocols installed.

->if the platform supports TLS feature then, EFI_TLS_PROTOCOL, EFI_TLS_SERVICE_BINDING_PROTOCOL, EFI_TLS_CONFIGURATION_PROTOCOL must be existed.
-> According UEFI2.7 Spec - 28.10 EFI TLS Protocols(page-1787)
The TLS consumer need locate EFI_TLS_SERVICE_BINDING_PROTOCOL and call CreateChild() to create a new child of EFI_TLS_PROTOCOL instance. Then use EFI_TLS_PROTOCOL to start TLS session. After use, the TLS consumer need call DestroyChild() to destroy it.
-> Network Stack follows same in HTTPS boot.
While doing IPv4/6 HTTPS boot , will locate gEfiTlsServiceBindingProtocolGuid and call TlsServiceBindingCreateChild, So that EFI_TLS_PROTOCOL and EFI_TLS_CONFIGURATION_PROTOCOL will be installed.

So once HTTPS boot is success then TLS supported protocols exist.

And if we do SCT test after HTTPS boot is success, Then TLS related failures should NOT happen in SCT.

I've tried SCT test after HTTPS boot success, But SCT test Crashes.

[Steps to reproduce]

1.       Configure the HTTPS Server with EFI Shell as NBP file.

2.       Connect test machine and HTTPS server with LAN cable.

3.       Perform HTTPS boot in test machine

4.       Once HTTPS boot is success, It will launch Shell.

5.       Run SCT test


[Observations]

1.       SCT test was crashed and unable to continue the test.

Could you please provide your comments/Suggestion on this?


Thanks,
Karunakar