From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC28F2035BB16 for ; Wed, 22 Nov 2017 20:47:26 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Nov 2017 20:51:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,440,1505804400"; d="scan'208,217";a="176816207" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 22 Nov 2017 20:51:43 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Nov 2017 20:51:42 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Nov 2017 20:51:27 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 23 Nov 2017 12:51:25 +0800 From: "Wu, Jiaxin" To: Karunakar P , "'edk2-devel@lists.01.org'" CC: "Fu, Siyuan" , "Ye, Ting" , "Jin, Eric" Thread-Topic: SCT Test crashes After HTTPS boot success. Thread-Index: AdNetw87ERZA5RTMTjO2Kk3mB+3gDwAg7MVgAAyVDaAAADmV4ADUAOPwAAAuWBAAKMW5IAAEQ1HgACWMZcA= Date: Thu, 23 Nov 2017 04:51:24 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B72741634AD10@SHSMSX103.ccr.corp.intel.com> References: <895558F6EA4E3B41AC93A00D163B727416348F70@SHSMSX103.ccr.corp.intel.com> <895558F6EA4E3B41AC93A00D163B7274163492F8@SHSMSX103.ccr.corp.intel.com> <895558F6EA4E3B41AC93A00D163B72741634A7D0@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTBjOGYxNmEtMmRhZS00NDc5LThjZDMtMTQyYzNjYjQyYzcxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdYYURwM2xuNWh2Q1BtcUEreFVjeUVTeFVEUTV0QmdhblU3YnpNNVYzMzA9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: SCT Test crashes After HTTPS boot success. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 04:47:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Karunakar, We're going to update the below description in UEFI Spec section of 2.6.2, = not SCT Spec: If the network environment requires TLS features, EFI_TLS_SERVICE_BINDING_PROTOCOL,EFI_TLS_PROTOCOL and EFI_TLS_CONFIGURATION_PROTOCOL are required. The SCT test case was drafted by according to the above sentence that all o= f the TlsSB/TlsProtocol/TlsConfigProtocol must exist, if not, the failure h= appen. For other cases, we will review them, then feedback to you. Thanks, Jiaxin From: Karunakar P [mailto:karunakarp@amiindia.co.in] Sent: Wednesday, November 22, 2017 6:25 PM To: Wu, Jiaxin ; 'edk2-devel@lists.01.org' Cc: Fu, Siyuan ; Ye, Ting ; Jin, Er= ic Subject: RE: SCT Test crashes After HTTPS boot success. Hi Jiaxin, Thank you very much for your detailed explanation. After talk with SCT expert (Jin, Eric >) , we agree the Spec may need to be updated since it can mislead= the caller. Sorry, I didn't get the point here, whether we're going to update SCT spec = to resolve this TLS failure? And regards other failures ? The platform have SCSI module, PXE_BC protocols and one of UNDI/SNP/MNP a= re present, But still I'm getting SCT failures related to this. ? Also there are some failures in HiiTest Could you please provide your comments/Suggestions on other failures too. Thank You. Karunakar From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com] Sent: Wednesday, November 22, 2017 2:13 PM To: Karunakar P; 'edk2-devel@lists.01.org' Cc: Fu, Siyuan; Ye, Ting; Jin, Eric Subject: RE: SCT Test crashes After HTTPS boot success. Hi Karunakar, I didn't see the SCT crash issue but also see the TLS test failure you atta= ched. For the failure, it's related to the EFI compliant test. According the UEFI= Spec, section of 2.6.2: If the network environment requires TLS features, EFI_TLS_SERVICE_BINDING_PROTOCOL,EFI_TLS_PROTOCOL and EFI_TLS_CONFIGURATION_PROTOCOL are required. So, the SCT will check the EFI_TLS_SERVICE_BINDING_PROTOCOL, EFI_TLS_PROTOC= OL and EFI_TLS_CONFIGURATION_PROTOCOL, but it didn't find the EFI_TLS_PROTO= COL and EFI_TLS_CONFIGURATION_PROTOCOL because no available TLS instance is= created by default since it's no driver dependency. Even you tried the HTT= PS, the TLS instance will be destroyed after finishing the HTTPS boot proce= ss, that's the reason why it still fail after HTTPS boot. Status =3D gtBS->LocateProtocol ( &gEfiTlsConfigurationProtocolGuid, NULL, (VOID **) &Interface ); if (!EFI_ERROR (Status)) { ValueB =3D TRUE; } else { ValueB =3D FALSE; } After talk with SCT expert (Jin, Eric >) , we agree the Spec may need to be updated since it can mislead= the caller. Thanks, Jiaxin From: Karunakar P [mailto:karunakarp@amiindia.co.in] Sent: Tuesday, November 21, 2017 7:55 PM To: Wu, Jiaxin >; 'edk2-dev= el@lists.01.org' > Cc: Fu, Siyuan >; Ye, Ting = > Subject: RE: SCT Test crashes After HTTPS boot success. Hi Jiaxin, I've done SCT Test After HTTPS Boot success(Release Mode), I'm facing the b= elow failures 1. GenericTest\EFICompliantTest - EFI Compliant - PXE_BC protocols an= d one of UNDI/SNP/MNP must be implemented if a platform supports to boot fr= om a network device. 2. GenericTest\EFICompliantTest - UEFI-Compliant - EFI_NVM_EXPRESS_PA= SS_THRU_PROTOCOL must be implemented if a platform includes an NVM Express = controller. 3. GenericTest\EFICompliantTest - UEFI-Compliant - EFI_BLOCK_IO_PROTO= COL must be existed if the platform supports booting from a block-oriented = NVM Express controller. EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL may be required. 4. GenericTest\EFICompliantTest - EFI Compliant - SCSI_PASS_THRU prot= ocol must be implemented if a platform includes an I/O system that uses SCS= I command packets. 5. GenericTest\EFICompliantTest - UEFI-Compliant =13EFI_SCSI IO_PROTO= COL, EFI_Block IO_PROTOCOL and EFI_EXT_SCSI_PASS_THRU_PROTOCOL must be impl= emented if a platform supports booting from a SCSI peripheral device. 6. GenericTest\EFICompliantTest - EFI Compliant - DEBUG_SUPPORT and D= EBUG_PORT protocols must be implemented if a platform supports debugging ca= pabilities. 7. GenericTest\EFICompliantTest - UEFI-Compliant - EFI_ATA_PASS_THRU_= PROTOCOL must be implemented if a platform includes an I/O subsystem that u= tilizes ATA command packets. 8. GenericTest\EFICompliantTest - UEFI-Compliant - EFI_TLS_PROTOCOL, = EFI_TLS_SERVICE_BINDING_PROTOCOL, EFI_TLS_CONFIGURATION_PROTOCOL must be ex= isted if the platform supports TLS feature. 9. GenericTest\EFICompliantTest - UEFI-Compliant - EFI_EAP_PROTOCOL, = EFI_EAP_CONFIGURATION_PROTOCOL, EFI_EAP_MANAGEMENT2_PROTOCOL must be existe= d if the platform includes the ability to perform a wireless boot from a ne= twork device with EAP feature, and if this platform provides 10. GenericTest\EFICompliantTest - UEFI-Compliant - EFI_BLUETOOTH_HC_PROT= OCOL, EFI_BLUETOOTH_IO_PROTOCOL, EFI_BLUETOOTH_CONFIG_PROTOCOL must be exis= ted if the platform supports classic Bluetooth. I've attached the Test Report for reference. Could you please provide your comments/suggestions on the failures? Thanks, Karunakar From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com] Sent: Friday, November 17, 2017 12:05 PM To: Karunakar P; 'edk2-devel@lists.01.org' Cc: Fu, Siyuan; Ye, Ting Subject: RE: SCT Test crashes After HTTPS boot success. I will try to reproduce the issue with EDK2 trunk code, then feedback to yo= u. Thanks the report. Jiaxin From: Karunakar P [mailto:karunakarp@amiindia.co.in] Sent: Friday, November 17, 2017 2:32 PM To: Wu, Jiaxin >; 'edk2-dev= el@lists.01.org' > Cc: Fu, Siyuan >; Ye, Ting = > Subject: RE: SCT Test crashes After HTTPS boot success. Hi Jiaxin, Below are the detailed steps for SCT test [Steps to reproduce] . 5. Run SCT test a. Execute the following commands to run SCT test on SUT sct -r sct -u b. In Test Case Management page, Enable GenericTest c. Press F9 to run the selected test case [Observation] synchronous exception occurred in SCT ,Attached the Log for reference. Thanks, Karunakar From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com] Sent: Friday, November 17, 2017 6:01 AM To: Karunakar P; 'edk2-devel@lists.01.org' Cc: Fu, Siyuan; Ye, Ting Subject: RE: SCT Test crashes After HTTPS boot success. Hi Karunakar, Can you provide more detailed info for the SCT test steps? The crash can ha= ppen after "Sct.efi -u" or need run any specific test case? Thanks, Jiaxin From: Karunakar P [mailto:karunakarp@amiindia.co.in] Sent: Thursday, November 16, 2017 4:48 PM To: 'edk2-devel@lists.01.org' > Cc: Wu, Jiaxin >; Fu, Siyua= n >; Ye, Ting > Subject: SCT Test crashes After HTTPS boot success. Hello All, When I do SCT test, get the below failure GenericTest\EFICompliantTest 0 0 CB6F7B77-0B15-43F7-A95B-8C7F9FD70B21 FAIL = UEFI Compliant - TLS support is required The reason for the failure is that the platform doesn't have TLS related pr= otocols installed. ->if the platform supports TLS feature then, EFI_TLS_PROTOCOL, EFI_TLS_SERV= ICE_BINDING_PROTOCOL, EFI_TLS_CONFIGURATION_PROTOCOL must be existed. -> According UEFI2.7 Spec - 28.10 EFI TLS Protocols(page-1787) The TLS consumer need locate EFI_TLS_SERVICE_BINDING_PROTOCOL and call Crea= teChild() to create a new child of EFI_TLS_PROTOCOL instance. Then use EFI_= TLS_PROTOCOL to start TLS session. After use, the TLS consumer need call De= stroyChild() to destroy it. -> Network Stack follows same in HTTPS boot. While doing IPv4/6 HTTPS boot , will locate gEfiTlsServiceBindingProtocolGu= id and call TlsServiceBindingCreateChild, So that EFI_TLS_PROTOCOL and EFI_= TLS_CONFIGURATION_PROTOCOL will be installed. So once HTTPS boot is success then TLS supported protocols exist. And if we do SCT test after HTTPS boot is success, Then TLS related failure= s should NOT happen in SCT. I've tried SCT test after HTTPS boot success, But SCT test Crashes. [Steps to reproduce] 1. Configure the HTTPS Server with EFI Shell as NBP file. 2. Connect test machine and HTTPS server with LAN cable. 3. Perform HTTPS boot in test machine 4. Once HTTPS boot is success, It will launch Shell. 5. Run SCT test [Observations] 1. SCT test was crashed and unable to continue the test. Could you please provide your comments/Suggestion on this? Thanks, Karunakar