From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F96E221786B0 for ; Thu, 30 Nov 2017 19:40:18 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2017 19:44:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,343,1508828400"; d="scan'208";a="182266732" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 30 Nov 2017 19:44:44 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Nov 2017 19:44:44 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Nov 2017 19:44:43 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Fri, 1 Dec 2017 11:44:41 +0800 From: "Wu, Jiaxin" To: "Richardson, Brian" , Karunakar P , "Fu, Siyuan" , "Ye, Ting" , "'edk2-devel@lists.01.org'" Thread-Topic: DHCP Process Starts Even there is NO Media Connected Thread-Index: AdNkNPJlNii6MXEqST2sZcqbh3p1FwDG32fwAELhS7AAH1I1YAAyTPpQABG0g5AAGg9/MA== Date: Fri, 1 Dec 2017 03:44:41 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B72741634EB13@SHSMSX103.ccr.corp.intel.com> References: <895558F6EA4E3B41AC93A00D163B72741634DAB3@SHSMSX103.ccr.corp.intel.com> <80AC2BAA3152784F98F581129E5CF5AFA464ACA2@ORSMSX114.amr.corp.intel.com> In-Reply-To: <80AC2BAA3152784F98F581129E5CF5AFA464ACA2@ORSMSX114.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGU4MTMyMTMtNjJmOS00Nzk5LWJiZDEtYTdhN2Q1OWM1MzY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZMZmFiOGZBazcrVjRkME5xK2ZUNVJLR2FKMmlCZlVIUTBSMGdiTWJ1a1U9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: DHCP Process Starts Even there is NO Media Connected X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 03:40:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Karunakar, Per your question #3.c, I think it's *unreasonable* to check Media Status f= or EFI_IP4_CONFIG2_SET_DATA.=20 Even there is no media connected, we still need to set the data instead of = return directly. If the EFI_IP4_CONFIG2_SET_DATA.SetData() is to set the DH= CP policy, the SetData() interface will try to do the DHCP process to get o= ne valid default address, but if there is any failure happen in DHCP proces= s (e.g. no media connected), we should continue change the policy to DHCP a= nd return EFI_SUCCESS, which align with static policy. So, I don't prefer t= o check the Media Status in EFI_IP4_CONFIG2_SET_DATA.SetData().=20 I have reviewed your patch, the Dhcp4Dxe update is good to me. Can you send= out the formal patch to the EDK2 community for the review or need us do to= that? Note: don't forget to update the Dhcp6Dxe driver.=20 Also thanks Brain's reminder, please file a tracker in TianoCore Bugzilla f= or this issue. Thanks, Jiaxin > -----Original Message----- > From: Richardson, Brian > Sent: Thursday, November 30, 2017 11:02 PM > To: Karunakar P ; Wu, Jiaxin > ; Fu, Siyuan ; Ye, Ting > ; 'edk2-devel@lists.01.org' > Subject: RE: DHCP Process Starts Even there is NO Media Connected >=20 > We saw some problems running Linux UEFI Validation (LUV) at the last UEFI > Plugfest that are probably related to this issue. At the time we asked th= e LUV > team to investigate it as a test issue, but it may actually be a stack pr= oblem > based on this information. >=20 > Have you filed a tracker in TianoCore Bugzilla for this issue? >=20 > Thanks ... br > --- > Brian Richardson, Senior Technical Marketing Engineer, Intel Software > brian.richardson@intel.com -- @intel_brian (Twitter & WeChat) > https://software.intel.com/en-us/meet-the-developers/evangelists/team/bri= an- > richardson >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Karunakar P > Sent: Thursday, November 30, 2017 3:59 AM > To: Wu, Jiaxin ; Fu, Siyuan ; Y= e, > Ting ; 'edk2-devel@lists.01.org' > Subject: Re: [edk2] DHCP Process Starts Even there is NO Media Connected >=20 > Hi Jiaxin, >=20 > Please find my below comments/suggestions. >=20 >=20 > 1. Yes, Current DHCP4/6 Start() implementation doesn't check for Me= dia > Status. It will be better to implement it in order to sync with UEFI spec= . >=20 > 2. DHCP process may be initiated by HTTP/PXE/ISCSI or Assigning IP > (SetData) from Shell or using BIOS setup page. >=20 > HTTP,PXE and ISCSI is already Checking Media Presence before DHCP Start, = So > it will have NO effect if we do implementation in DHCP4/6 Start(). >=20 > 3. Current implementation of EFI_IP4_CONFIG2_SET_DATA, also NOT > handling checking Media Status. >=20 > a. UEFI Spec NOT defines EFI_NO_MEDIA status code for > EFI_IP4_CONFIG2_SET_DATA, I'm NOT sure what's reason behind it or might b= e > missing. >=20 > b. UEFI Spec defines EFI_DEVICE_ERROR status code for > EFI_IP4_CONFIG2_SET_DATA, If we can use the same status for Media > presence then no issues. >=20 > c. When there is No Media connected and if we try to assign IP over > DHCP(SetData), I guess there is no need to proceed further in > EfiIp4Config2SetData and we can return with EFI_DEVICE_ERROR. >=20 > Based on above points(1 & 3.c ), I've updated the suggested changes and > attached the same (CheckMediaStatus_V2.rar) >=20 > Could you please review and provide your comments. > Please correct if anything wrong. >=20 > Thank You, > Karunakar >=20 > From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com] > Sent: Wednesday, November 29, 2017 11:57 AM > To: Karunakar P; Fu, Siyuan; Ye, Ting > Subject: RE: DHCP Process Starts Even there is NO Media Connected >=20 > Hi Karunakar, >=20 > After talk with Siyuan, we agree it's reasonable to check the Media statu= s > before starting DHCP process, but we'd better check it in DHCP layer sinc= e the > UEFI spec defines EFI_NO_MEDIA status code for DHCP4/6.Start(), but our > current implementation doesn't check it. >=20 > What do you think? >=20 > Thanks, > Jiaxin >=20 >=20 >=20 > From: Karunakar P [mailto:karunakarp@amiindia.co.in] > Sent: Tuesday, November 28, 2017 11:18 PM > To: Wu, Jiaxin >; Fu, Siy= uan > >; Ye, Ting > > > Subject: RE: DHCP Process Starts Even there is NO Media Connected >=20 > Could you please review the attachment changes for this support. >=20 > Thanks, > Karunakar >=20 > From: Karunakar P > Sent: Monday, November 27, 2017 12:53 PM > To: 'Wu, Jiaxin'; 'Fu, Siyuan'; 'Ye, Ting' > Subject: RE: DHCP Process Starts Even there is NO Media Connected >=20 > Could you please provide your comments... >=20 > Thank You, > Karunakar >=20 > From: Karunakar P > Sent: Thursday, November 23, 2017 2:05 PM > To: 'Wu, Jiaxin'; Fu, Siyuan; Ye, Ting > Subject: DHCP Process Starts Even there is NO Media Connected >=20 > Hello All, >=20 > When we try to Assign IP to SUT using ifconfig command from Shell or IPv= 4 > Network Configuration BIOS setup page DHCP process start even there is no > LAN cable connected to specific port. >=20 > Can we add a Media presence condition check before starting DHCP service? >=20 > Could you please correct if anything is wrong. >=20 > Thanks, > Karunakar > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel