From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Liang, Vincent" <vincent.liang@intel.com>
Subject: Re: [Patch] NetworkPkg: Update IScsiDxe to pass XCODE build
Date: Tue, 5 Dec 2017 07:04:27 +0000 [thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B72741634FE10@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1511839163-6300-1-git-send-email-liming.gao@intel.com>
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
Thanks,
Jiaxin
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Tuesday, November 28, 2017 11:19 AM
> To: edk2-devel@lists.01.org
> Cc: Liang, Vincent <vincent.liang@intel.com>
> Subject: [edk2] [Patch] NetworkPkg: Update IScsiDxe to pass XCODE build
>
> Fix the warning equality comparison with extraneous parentheses
> [-Werror,-Wparentheses-equality].
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liang Vincent <vincent.liang@intel.com>
> ---
> NetworkPkg/IScsiDxe/IScsiDhcp.c | 2 +-
> NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/NetworkPkg/IScsiDxe/IScsiDhcp.c
> b/NetworkPkg/IScsiDxe/IScsiDhcp.c
> index 6587a05..309ce0d 100644
> --- a/NetworkPkg/IScsiDxe/IScsiDhcp.c
> +++ b/NetworkPkg/IScsiDxe/IScsiDhcp.c
> @@ -266,7 +266,7 @@ IScsiDhcpSelectOffer (
> break;
> }
>
> - if ((Index == OptionCount)) {
> + if (Index == OptionCount) {
> Status = EFI_NOT_READY;
> }
>
> diff --git a/NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c
> b/NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c
> index f971244..90e26d4 100644
> --- a/NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c
> +++ b/NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c
> @@ -1,7 +1,7 @@
> /** @file
> The implementation of EFI_EXT_SCSI_PASS_THRU_PROTOCOL.
>
> -Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at
> @@ -219,7 +219,7 @@ IScsiExtScsiPassThruBuildDevicePath (
> EFI_DEV_PATH *Node;
> UINTN DevPathNodeLen;
>
> - if ((DevicePath == NULL)) {
> + if (DevicePath == NULL) {
> return EFI_INVALID_PARAMETER;
> }
>
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-12-05 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 3:19 [Patch] NetworkPkg: Update IScsiDxe to pass XCODE build Liming Gao
2017-12-05 7:04 ` Wu, Jiaxin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895558F6EA4E3B41AC93A00D163B72741634FE10@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox