From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 122F720356240 for ; Mon, 4 Dec 2017 22:59:59 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2017 23:04:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,363,1508828400"; d="scan'208";a="184127690" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 04 Dec 2017 23:04:30 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Dec 2017 23:04:30 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Dec 2017 23:04:29 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Tue, 5 Dec 2017 15:04:27 +0800 From: "Wu, Jiaxin" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Liang, Vincent" Thread-Topic: [edk2] [Patch] NetworkPkg: Update IScsiDxe to pass XCODE build Thread-Index: AQHTZ/e/HbEwkHMFQ0qHeuibpwUWo6M0Xo5A Date: Tue, 5 Dec 2017 07:04:27 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B72741634FE10@SHSMSX103.ccr.corp.intel.com> References: <1511839163-6300-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1511839163-6300-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjgxMTEwODgtZTJiNS00NWM5LWIyZjktZDNiMTdiODE4ODI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtHSnQzYVFzYWVKYkhRTjRtVmV6TGlsbTZONjB3Vkc2VGhrUklaa0hCaHc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] NetworkPkg: Update IScsiDxe to pass XCODE build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 07:00:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Liming Gao > Sent: Tuesday, November 28, 2017 11:19 AM > To: edk2-devel@lists.01.org > Cc: Liang, Vincent > Subject: [edk2] [Patch] NetworkPkg: Update IScsiDxe to pass XCODE build >=20 > Fix the warning equality comparison with extraneous parentheses > [-Werror,-Wparentheses-equality]. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liang Vincent > --- > NetworkPkg/IScsiDxe/IScsiDhcp.c | 2 +- > NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiDhcp.c > b/NetworkPkg/IScsiDxe/IScsiDhcp.c > index 6587a05..309ce0d 100644 > --- a/NetworkPkg/IScsiDxe/IScsiDhcp.c > +++ b/NetworkPkg/IScsiDxe/IScsiDhcp.c > @@ -266,7 +266,7 @@ IScsiDhcpSelectOffer ( > break; > } >=20 > - if ((Index =3D=3D OptionCount)) { > + if (Index =3D=3D OptionCount) { > Status =3D EFI_NOT_READY; > } >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c > b/NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c > index f971244..90e26d4 100644 > --- a/NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c > +++ b/NetworkPkg/IScsiDxe/IScsiExtScsiPassThru.c > @@ -1,7 +1,7 @@ > /** @file > The implementation of EFI_EXT_SCSI_PASS_THRU_PROTOCOL. >=20 > -Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.
> +Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e > found at > @@ -219,7 +219,7 @@ IScsiExtScsiPassThruBuildDevicePath ( > EFI_DEV_PATH *Node; > UINTN DevPathNodeLen; >=20 > - if ((DevicePath =3D=3D NULL)) { > + if (DevicePath =3D=3D NULL) { > return EFI_INVALID_PARAMETER; > } >=20 > -- > 2.8.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel