* [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.
@ 2017-12-22 6:13 Fu Siyuan
2017-12-22 7:26 ` Wu, Jiaxin
2017-12-22 7:30 ` Wang, Fan
0 siblings, 2 replies; 3+ messages in thread
From: Fu Siyuan @ 2017-12-22 6:13 UTC (permalink / raw)
To: edk2-devel; +Cc: Ye Ting, Wu Jiaxin, Wang Fan
This patch updates the constructor of DpcLib to return error if failed to
locate DPC protocol.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Wang Fan <fan.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
MdeModulePkg/Library/DxeDpcLib/DpcLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
index 6eda8ca0fb..ddc3e0adda 100644
--- a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
+++ b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
@@ -45,7 +45,7 @@ DpcLibConstructor (
Status = gBS->LocateProtocol (&gEfiDpcProtocolGuid, NULL, (VOID **)&mDpc);
ASSERT_EFI_ERROR (Status);
- return EFI_SUCCESS;
+ return Status;
}
/**
--
2.13.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.
2017-12-22 6:13 [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol Fu Siyuan
@ 2017-12-22 7:26 ` Wu, Jiaxin
2017-12-22 7:30 ` Wang, Fan
1 sibling, 0 replies; 3+ messages in thread
From: Wu, Jiaxin @ 2017-12-22 7:26 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Ye, Ting, Wang, Fan
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu,
> Siyuan
> Sent: Friday, December 22, 2017 2:14 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Wang, Fan <fan.wang@intel.com>; Wu,
> Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to
> locate DPC protocol.
>
> This patch updates the constructor of DpcLib to return error if failed to
> locate DPC protocol.
>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Wang Fan <fan.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> ---
> MdeModulePkg/Library/DxeDpcLib/DpcLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
> b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
> index 6eda8ca0fb..ddc3e0adda 100644
> --- a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
> +++ b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
> @@ -45,7 +45,7 @@ DpcLibConstructor (
> Status = gBS->LocateProtocol (&gEfiDpcProtocolGuid, NULL, (VOID
> **)&mDpc);
> ASSERT_EFI_ERROR (Status);
>
> - return EFI_SUCCESS;
> + return Status;
> }
>
> /**
> --
> 2.13.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.
2017-12-22 6:13 [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol Fu Siyuan
2017-12-22 7:26 ` Wu, Jiaxin
@ 2017-12-22 7:30 ` Wang, Fan
1 sibling, 0 replies; 3+ messages in thread
From: Wang, Fan @ 2017-12-22 7:30 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Ye, Ting, Wu, Jiaxin
Reviewed by Wang, Fan <fan.wang@intel.com>
-----Original Message-----
From: Fu, Siyuan
Sent: Friday, December 22, 2017 2:14 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Wang, Fan <fan.wang@intel.com>
Subject: [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.
This patch updates the constructor of DpcLib to return error if failed to locate DPC protocol.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Wang Fan <fan.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
MdeModulePkg/Library/DxeDpcLib/DpcLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
index 6eda8ca0fb..ddc3e0adda 100644
--- a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
+++ b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
@@ -45,7 +45,7 @@ DpcLibConstructor (
Status = gBS->LocateProtocol (&gEfiDpcProtocolGuid, NULL, (VOID **)&mDpc);
ASSERT_EFI_ERROR (Status);
- return EFI_SUCCESS;
+ return Status;
}
/**
--
2.13.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-22 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-22 6:13 [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol Fu Siyuan
2017-12-22 7:26 ` Wu, Jiaxin
2017-12-22 7:30 ` Wang, Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox