From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E1DA222CB30D for ; Thu, 21 Dec 2017 23:22:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 23:27:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,439,1508828400"; d="scan'208";a="18103748" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 21 Dec 2017 23:27:01 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Dec 2017 23:27:01 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Fri, 22 Dec 2017 15:26:59 +0800 From: "Wu, Jiaxin" To: "Fu, Siyuan" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Wang, Fan" Thread-Topic: [edk2] [Patch] NetworkPkg: Remove redundant check in PXE driver. Thread-Index: AQHTei/mMun9qeQBoUGzjykzJhnfKaNO+BYg Date: Fri, 22 Dec 2017 07:26:59 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B727416355F8F@SHSMSX103.ccr.corp.intel.com> References: <20171221074626.372-1-siyuan.fu@intel.com> <20171221074626.372-2-siyuan.fu@intel.com> In-Reply-To: <20171221074626.372-2-siyuan.fu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTJhM2U0YzAtY2U5ZC00NDlhLWE4Y2QtZmNhNWNjM2U3MjY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikh1OW5HYzZ0TG05VG5BS3NMZjlHSW85SndvdHg0OSt2dUxvSDhcL3ZxaWt3PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] NetworkPkg: Remove redundant check in PXE driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 07:22:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiaxin Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu= , > Siyuan > Sent: Thursday, December 21, 2017 3:46 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan ; Wu, > Jiaxin > Subject: [edk2] [Patch] NetworkPkg: Remove redundant check in PXE driver. >=20 > The IP protocol has been configured to only receive ICMP packet in PXE > driver. > So this patch removes the unnecessary check for NextHeader field and > replace it > with ASSERT. >=20 > Cc: Ye Ting > Cc: Wu Jiaxin > Cc: Wang Fan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Fu Siyuan > --- > NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 24 +++++++++--------------- > 1 file changed, 9 insertions(+), 15 deletions(-) >=20 > diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c > b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c > index dfc79a067b..720287583e 100644 > --- a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c > +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c > @@ -279,14 +279,11 @@ PxeBcIcmpErrorDpcHandle ( > gBS->SignalEvent (RxData->RecycleSignal); > goto ON_EXIT; > } > - > - if (RxData->Header->Protocol !=3D EFI_IP_PROTO_ICMP) { > - // > - // The protocol value in the header of the receveid packet should be > EFI_IP_PROTO_ICMP. > - // > - gBS->SignalEvent (RxData->RecycleSignal); > - goto ON_EXIT; > - } > + > + // > + // The protocol has been configured to only receive ICMP packet. > + // > + ASSERT (RxData->Header->Protocol =3D=3D EFI_IP_PROTO_ICMP); >=20 > Type =3D *((UINT8 *) RxData->FragmentTable[0].FragmentBuffer); >=20 > @@ -416,13 +413,10 @@ PxeBcIcmp6ErrorDpcHandle ( > goto ON_EXIT; > } >=20 > - if (RxData->Header->NextHeader !=3D IP6_ICMP) { > - // > - // The nextheader in the header of the receveid packet should be > IP6_ICMP. > - // > - gBS->SignalEvent (RxData->RecycleSignal); > - goto ON_EXIT; > - } > + // > + // The protocol has been configured to only receive ICMP packet. > + // > + ASSERT (RxData->Header->NextHeader =3D=3D IP6_ICMP); >=20 > Type =3D *((UINT8 *) RxData->FragmentTable[0].FragmentBuffer); >=20 > -- > 2.13.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel