public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>, Karunakar P <karunakarp@amiindia.co.in>
Subject: Re: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.
Date: Wed, 27 Dec 2017 03:02:49 +0000	[thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B7274163572F1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <B1FF2E9001CE9041BD10B825821D5BC58B3FC788@SHSMSX103.ccr.corp.intel.com>

Thanks, Siyuan I will refine the commit log before apply the patch.

> -----Original Message-----
> From: Fu, Siyuan
> Sent: Wednesday, December 27, 2017 11:01 AM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Karunakar P <karunakarp@amiindia.co.in>
> Subject: RE: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value
> according the target info.
> 
> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> Please provide more information in the commit log.
> 
> > -----Original Message-----
> > From: Wu, Jiaxin
> > Sent: Monday, December 25, 2017 1:30 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>;
> > Karunakar P <karunakarp@amiindia.co.in>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> > Subject: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value
> according
> > the target info.
> >
> > This patch is to resolve the issue recorded @
> > https://bugzilla.tianocore.org/show_bug.cgi?id=823.
> >
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Karunakar P <karunakarp@amiindia.co.in>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > Tested-by: Karunakar P <karunakarp@amiindia.co.in>
> > ---
> >  NetworkPkg/IScsiDxe/IScsiDhcp.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/NetworkPkg/IScsiDxe/IScsiDhcp.c
> > b/NetworkPkg/IScsiDxe/IScsiDhcp.c
> > index e6f6972..e343523 100644
> > --- a/NetworkPkg/IScsiDxe/IScsiDhcp.c
> > +++ b/NetworkPkg/IScsiDxe/IScsiDhcp.c
> > @@ -132,10 +132,11 @@ IScsiDhcpExtractRootPath (
> >        return EFI_INVALID_PARAMETER;
> >      }
> >      CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);
> >      ConfigNvData->TargetUrl[Field->Len + 1] = '\0';
> >    } else {
> > +    ConfigNvData->DnsMode = FALSE;
> >      ZeroMem(ConfigNvData->TargetUrl, sizeof (ConfigNvData->TargetUrl));
> >      Status = IScsiAsciiStrToIp (Field->Str, IpMode, &Ip);
> >      CopyMem (&ConfigNvData->TargetIp, &Ip, sizeof (EFI_IP_ADDRESS));
> >
> >      if (EFI_ERROR (Status)) {
> > --
> > 1.9.5.msysgit.1



  reply	other threads:[~2017-12-27  2:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-25  5:30 [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info Jiaxin Wu
2017-12-27  3:00 ` Fu, Siyuan
2017-12-27  3:02   ` Wu, Jiaxin [this message]
2017-12-27  3:30 ` Ye, Ting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=895558F6EA4E3B41AC93A00D163B7274163572F1@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox