From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4D73122280C22 for ; Tue, 26 Dec 2017 18:57:58 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Dec 2017 19:02:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,462,1508828400"; d="scan'208";a="5098500" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 26 Dec 2017 19:02:52 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Dec 2017 19:02:52 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Dec 2017 19:02:51 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.189]) with mapi id 14.03.0319.002; Wed, 27 Dec 2017 11:02:50 +0800 From: "Wu, Jiaxin" To: "Fu, Siyuan" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , Karunakar P Thread-Topic: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info. Thread-Index: AQHTfUF4td71FEwE8UOqci4S3xjkIaNWgv2AgAAAbPA= Date: Wed, 27 Dec 2017 03:02:49 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274163572F1@SHSMSX103.ccr.corp.intel.com> References: <1514179813-660-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmYzMDAyNzctOWU1NC00NDI2LTliY2ItNjJlZDg1NWVkYzQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlwvS3lEUms2bnNvSEFqYm5BZ1wvdWFNRk15UDdOcGZKXC9aYzUwWXZsRHV6M1E9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 02:57:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, Siyuan I will refine the commit log before apply the patch. > -----Original Message----- > From: Fu, Siyuan > Sent: Wednesday, December 27, 2017 11:01 AM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Karunakar P > Subject: RE: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value > according the target info. >=20 > Reviewed-by: Fu Siyuan > Please provide more information in the commit log. >=20 > > -----Original Message----- > > From: Wu, Jiaxin > > Sent: Monday, December 25, 2017 1:30 PM > > To: edk2-devel@lists.01.org > > Cc: Ye, Ting ; Fu, Siyuan ; > > Karunakar P ; Wu, Jiaxin > > > Subject: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value > according > > the target info. > > > > This patch is to resolve the issue recorded @ > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D823. > > > > Cc: Ye Ting > > Cc: Fu Siyuan > > Cc: Karunakar P > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Wu Jiaxin > > Tested-by: Karunakar P > > --- > > NetworkPkg/IScsiDxe/IScsiDhcp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/NetworkPkg/IScsiDxe/IScsiDhcp.c > > b/NetworkPkg/IScsiDxe/IScsiDhcp.c > > index e6f6972..e343523 100644 > > --- a/NetworkPkg/IScsiDxe/IScsiDhcp.c > > +++ b/NetworkPkg/IScsiDxe/IScsiDhcp.c > > @@ -132,10 +132,11 @@ IScsiDhcpExtractRootPath ( > > return EFI_INVALID_PARAMETER; > > } > > CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len); > > ConfigNvData->TargetUrl[Field->Len + 1] =3D '\0'; > > } else { > > + ConfigNvData->DnsMode =3D FALSE; > > ZeroMem(ConfigNvData->TargetUrl, sizeof (ConfigNvData->TargetUrl))= ; > > Status =3D IScsiAsciiStrToIp (Field->Str, IpMode, &Ip); > > CopyMem (&ConfigNvData->TargetIp, &Ip, sizeof (EFI_IP_ADDRESS)); > > > > if (EFI_ERROR (Status)) { > > -- > > 1.9.5.msysgit.1