* [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.
@ 2017-12-25 5:30 Jiaxin Wu
2017-12-27 3:00 ` Fu, Siyuan
2017-12-27 3:30 ` Ye, Ting
0 siblings, 2 replies; 4+ messages in thread
From: Jiaxin Wu @ 2017-12-25 5:30 UTC (permalink / raw)
To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Karunakar P, Wu Jiaxin
This patch is to resolve the issue recorded @
https://bugzilla.tianocore.org/show_bug.cgi?id=823.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Karunakar P <karunakarp@amiindia.co.in>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Tested-by: Karunakar P <karunakarp@amiindia.co.in>
---
NetworkPkg/IScsiDxe/IScsiDhcp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/NetworkPkg/IScsiDxe/IScsiDhcp.c b/NetworkPkg/IScsiDxe/IScsiDhcp.c
index e6f6972..e343523 100644
--- a/NetworkPkg/IScsiDxe/IScsiDhcp.c
+++ b/NetworkPkg/IScsiDxe/IScsiDhcp.c
@@ -132,10 +132,11 @@ IScsiDhcpExtractRootPath (
return EFI_INVALID_PARAMETER;
}
CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);
ConfigNvData->TargetUrl[Field->Len + 1] = '\0';
} else {
+ ConfigNvData->DnsMode = FALSE;
ZeroMem(ConfigNvData->TargetUrl, sizeof (ConfigNvData->TargetUrl));
Status = IScsiAsciiStrToIp (Field->Str, IpMode, &Ip);
CopyMem (&ConfigNvData->TargetIp, &Ip, sizeof (EFI_IP_ADDRESS));
if (EFI_ERROR (Status)) {
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.
2017-12-25 5:30 [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info Jiaxin Wu
@ 2017-12-27 3:00 ` Fu, Siyuan
2017-12-27 3:02 ` Wu, Jiaxin
2017-12-27 3:30 ` Ye, Ting
1 sibling, 1 reply; 4+ messages in thread
From: Fu, Siyuan @ 2017-12-27 3:00 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Ye, Ting, Karunakar P
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Please provide more information in the commit log.
> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Monday, December 25, 2017 1:30 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>;
> Karunakar P <karunakarp@amiindia.co.in>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according
> the target info.
>
> This patch is to resolve the issue recorded @
> https://bugzilla.tianocore.org/show_bug.cgi?id=823.
>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Karunakar P <karunakarp@amiindia.co.in>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> Tested-by: Karunakar P <karunakarp@amiindia.co.in>
> ---
> NetworkPkg/IScsiDxe/IScsiDhcp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/NetworkPkg/IScsiDxe/IScsiDhcp.c
> b/NetworkPkg/IScsiDxe/IScsiDhcp.c
> index e6f6972..e343523 100644
> --- a/NetworkPkg/IScsiDxe/IScsiDhcp.c
> +++ b/NetworkPkg/IScsiDxe/IScsiDhcp.c
> @@ -132,10 +132,11 @@ IScsiDhcpExtractRootPath (
> return EFI_INVALID_PARAMETER;
> }
> CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);
> ConfigNvData->TargetUrl[Field->Len + 1] = '\0';
> } else {
> + ConfigNvData->DnsMode = FALSE;
> ZeroMem(ConfigNvData->TargetUrl, sizeof (ConfigNvData->TargetUrl));
> Status = IScsiAsciiStrToIp (Field->Str, IpMode, &Ip);
> CopyMem (&ConfigNvData->TargetIp, &Ip, sizeof (EFI_IP_ADDRESS));
>
> if (EFI_ERROR (Status)) {
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.
2017-12-27 3:00 ` Fu, Siyuan
@ 2017-12-27 3:02 ` Wu, Jiaxin
0 siblings, 0 replies; 4+ messages in thread
From: Wu, Jiaxin @ 2017-12-27 3:02 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Ye, Ting, Karunakar P
Thanks, Siyuan I will refine the commit log before apply the patch.
> -----Original Message-----
> From: Fu, Siyuan
> Sent: Wednesday, December 27, 2017 11:01 AM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Karunakar P <karunakarp@amiindia.co.in>
> Subject: RE: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value
> according the target info.
>
> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> Please provide more information in the commit log.
>
> > -----Original Message-----
> > From: Wu, Jiaxin
> > Sent: Monday, December 25, 2017 1:30 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>;
> > Karunakar P <karunakarp@amiindia.co.in>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> > Subject: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value
> according
> > the target info.
> >
> > This patch is to resolve the issue recorded @
> > https://bugzilla.tianocore.org/show_bug.cgi?id=823.
> >
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Karunakar P <karunakarp@amiindia.co.in>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > Tested-by: Karunakar P <karunakarp@amiindia.co.in>
> > ---
> > NetworkPkg/IScsiDxe/IScsiDhcp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/NetworkPkg/IScsiDxe/IScsiDhcp.c
> > b/NetworkPkg/IScsiDxe/IScsiDhcp.c
> > index e6f6972..e343523 100644
> > --- a/NetworkPkg/IScsiDxe/IScsiDhcp.c
> > +++ b/NetworkPkg/IScsiDxe/IScsiDhcp.c
> > @@ -132,10 +132,11 @@ IScsiDhcpExtractRootPath (
> > return EFI_INVALID_PARAMETER;
> > }
> > CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);
> > ConfigNvData->TargetUrl[Field->Len + 1] = '\0';
> > } else {
> > + ConfigNvData->DnsMode = FALSE;
> > ZeroMem(ConfigNvData->TargetUrl, sizeof (ConfigNvData->TargetUrl));
> > Status = IScsiAsciiStrToIp (Field->Str, IpMode, &Ip);
> > CopyMem (&ConfigNvData->TargetIp, &Ip, sizeof (EFI_IP_ADDRESS));
> >
> > if (EFI_ERROR (Status)) {
> > --
> > 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.
2017-12-25 5:30 [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info Jiaxin Wu
2017-12-27 3:00 ` Fu, Siyuan
@ 2017-12-27 3:30 ` Ye, Ting
1 sibling, 0 replies; 4+ messages in thread
From: Ye, Ting @ 2017-12-27 3:30 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Fu, Siyuan, Karunakar P
Reviewed-by: Ye Ting <ting.ye@intel.com>
-----Original Message-----
From: Wu, Jiaxin
Sent: Monday, December 25, 2017 1:30 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Karunakar P <karunakarp@amiindia.co.in>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.
This patch is to resolve the issue recorded @ https://bugzilla.tianocore.org/show_bug.cgi?id=823.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Karunakar P <karunakarp@amiindia.co.in>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Tested-by: Karunakar P <karunakarp@amiindia.co.in>
---
NetworkPkg/IScsiDxe/IScsiDhcp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/NetworkPkg/IScsiDxe/IScsiDhcp.c b/NetworkPkg/IScsiDxe/IScsiDhcp.c index e6f6972..e343523 100644
--- a/NetworkPkg/IScsiDxe/IScsiDhcp.c
+++ b/NetworkPkg/IScsiDxe/IScsiDhcp.c
@@ -132,10 +132,11 @@ IScsiDhcpExtractRootPath (
return EFI_INVALID_PARAMETER;
}
CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);
ConfigNvData->TargetUrl[Field->Len + 1] = '\0';
} else {
+ ConfigNvData->DnsMode = FALSE;
ZeroMem(ConfigNvData->TargetUrl, sizeof (ConfigNvData->TargetUrl));
Status = IScsiAsciiStrToIp (Field->Str, IpMode, &Ip);
CopyMem (&ConfigNvData->TargetIp, &Ip, sizeof (EFI_IP_ADDRESS));
if (EFI_ERROR (Status)) {
--
1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-27 3:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-25 5:30 [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info Jiaxin Wu
2017-12-27 3:00 ` Fu, Siyuan
2017-12-27 3:02 ` Wu, Jiaxin
2017-12-27 3:30 ` Ye, Ting
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox