public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] NetworkPkg: Correct HttpTlsCipherList.h file format to DOS
@ 2018-03-26  2:10 Liming Gao
  2018-03-26  3:02 ` Fu, Siyuan
  2018-03-26  3:27 ` Wu, Jiaxin
  0 siblings, 2 replies; 3+ messages in thread
From: Liming Gao @ 2018-03-26  2:10 UTC (permalink / raw)
  To: edk2-devel; +Cc: Wu Jiaxin, Fu Siyuan

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
---
 NetworkPkg/Include/Guid/HttpTlsCipherList.h | 76 ++++++++++++++---------------
 1 file changed, 38 insertions(+), 38 deletions(-)

diff --git a/NetworkPkg/Include/Guid/HttpTlsCipherList.h b/NetworkPkg/Include/Guid/HttpTlsCipherList.h
index bbfe488..bd30231 100644
--- a/NetworkPkg/Include/Guid/HttpTlsCipherList.h
+++ b/NetworkPkg/Include/Guid/HttpTlsCipherList.h
@@ -1,38 +1,38 @@
-/** @file
-  This file defines the HttpTlsCipherList variable for HTTPS to configure Tls Cipher List.
-
-Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
-This program and the accompanying materials are licensed and made available under
-the terms and conditions of the BSD License that accompanies this distribution.
-The full text of the license may be found at
-http://opensource.org/licenses/bsd-license.php.
-
-THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#ifndef __HTTP_TLS_CIPHER_LIST_H__
-#define __HTTP_TLS_CIPHER_LIST_H__
-
-//
-// Private Variable for HTTPS to configure Tls Cipher List.
-// The valid contents of variable must follow the TLS CipherList format defined in RFC 5246. 
-// The valid length of variable must be an integral multiple of 2.
-// For example, if below cipher suites are preferred:
-// 	 CipherSuite TLS_RSA_WITH_AES_128_CBC_SHA256 = {0x00,0x3C}
-//   CipherSuite TLS_RSA_WITH_AES_256_CBC_SHA256 = {0x00,0x3D}
-// Then, the contents of variable should be:
-//   {0x00,0x3C,0x00,0x3D}
-//
-#define EDKII_HTTP_TLS_CIPHER_LIST_GUID \
-  { \
-    0x46ddb415, 0x5244, 0x49c7, { 0x93, 0x74, 0xf0, 0xe2, 0x98, 0xe7, 0xd3, 0x86 } \
-  }
-  
-#define EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE       L"HttpTlsCipherList"
-
-extern EFI_GUID gEdkiiHttpTlsCipherListGuid;
-
-#endif
-
+/** @file
+  This file defines the HttpTlsCipherList variable for HTTPS to configure Tls Cipher List.
+
+Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+This program and the accompanying materials are licensed and made available under
+the terms and conditions of the BSD License that accompanies this distribution.
+The full text of the license may be found at
+http://opensource.org/licenses/bsd-license.php.
+
+THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#ifndef __HTTP_TLS_CIPHER_LIST_H__
+#define __HTTP_TLS_CIPHER_LIST_H__
+
+//
+// Private Variable for HTTPS to configure Tls Cipher List.
+// The valid contents of variable must follow the TLS CipherList format defined in RFC 5246. 
+// The valid length of variable must be an integral multiple of 2.
+// For example, if below cipher suites are preferred:
+// 	 CipherSuite TLS_RSA_WITH_AES_128_CBC_SHA256 = {0x00,0x3C}
+//   CipherSuite TLS_RSA_WITH_AES_256_CBC_SHA256 = {0x00,0x3D}
+// Then, the contents of variable should be:
+//   {0x00,0x3C,0x00,0x3D}
+//
+#define EDKII_HTTP_TLS_CIPHER_LIST_GUID \
+  { \
+    0x46ddb415, 0x5244, 0x49c7, { 0x93, 0x74, 0xf0, 0xe2, 0x98, 0xe7, 0xd3, 0x86 } \
+  }
+  
+#define EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE       L"HttpTlsCipherList"
+
+extern EFI_GUID gEdkiiHttpTlsCipherListGuid;
+
+#endif
+
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Patch] NetworkPkg: Correct HttpTlsCipherList.h file format to DOS
  2018-03-26  2:10 [Patch] NetworkPkg: Correct HttpTlsCipherList.h file format to DOS Liming Gao
@ 2018-03-26  3:02 ` Fu, Siyuan
  2018-03-26  3:27 ` Wu, Jiaxin
  1 sibling, 0 replies; 3+ messages in thread
From: Fu, Siyuan @ 2018-03-26  3:02 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Wu, Jiaxin

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Sunday, March 25, 2018 7:10 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [Patch] NetworkPkg: Correct HttpTlsCipherList.h file
> format to DOS
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> ---
>  NetworkPkg/Include/Guid/HttpTlsCipherList.h | 76 ++++++++++++++----------
> -----
>  1 file changed, 38 insertions(+), 38 deletions(-)
> 
> diff --git a/NetworkPkg/Include/Guid/HttpTlsCipherList.h
> b/NetworkPkg/Include/Guid/HttpTlsCipherList.h
> index bbfe488..bd30231 100644
> --- a/NetworkPkg/Include/Guid/HttpTlsCipherList.h
> +++ b/NetworkPkg/Include/Guid/HttpTlsCipherList.h
> @@ -1,38 +1,38 @@
> -/** @file
> -  This file defines the HttpTlsCipherList variable for HTTPS to configure
> Tls Cipher List.
> -
> -Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
> -This program and the accompanying materials are licensed and made
> available under
> -the terms and conditions of the BSD License that accompanies this
> distribution.
> -The full text of the license may be found at
> -http://opensource.org/licenses/bsd-license.php.
> -
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.
> -
> -**/
> -
> -#ifndef __HTTP_TLS_CIPHER_LIST_H__
> -#define __HTTP_TLS_CIPHER_LIST_H__
> -
> -//
> -// Private Variable for HTTPS to configure Tls Cipher List.
> -// The valid contents of variable must follow the TLS CipherList format
> defined in RFC 5246.
> -// The valid length of variable must be an integral multiple of 2.
> -// For example, if below cipher suites are preferred:
> -// 	 CipherSuite TLS_RSA_WITH_AES_128_CBC_SHA256 = {0x00,0x3C}
> -//   CipherSuite TLS_RSA_WITH_AES_256_CBC_SHA256 = {0x00,0x3D}
> -// Then, the contents of variable should be:
> -//   {0x00,0x3C,0x00,0x3D}
> -//
> -#define EDKII_HTTP_TLS_CIPHER_LIST_GUID \
> -  { \
> -    0x46ddb415, 0x5244, 0x49c7, { 0x93, 0x74, 0xf0, 0xe2, 0x98, 0xe7,
> 0xd3, 0x86 } \
> -  }
> -
> -#define EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE       L"HttpTlsCipherList"
> -
> -extern EFI_GUID gEdkiiHttpTlsCipherListGuid;
> -
> -#endif
> -
> +/** @file
> +  This file defines the HttpTlsCipherList variable for HTTPS to configure
> Tls Cipher List.
> +
> +Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
> +This program and the accompanying materials are licensed and made
> available under
> +the terms and conditions of the BSD License that accompanies this
> distribution.
> +The full text of the license may be found at
> +http://opensource.org/licenses/bsd-license.php.
> +
> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.
> +
> +**/
> +
> +#ifndef __HTTP_TLS_CIPHER_LIST_H__
> +#define __HTTP_TLS_CIPHER_LIST_H__
> +
> +//
> +// Private Variable for HTTPS to configure Tls Cipher List.
> +// The valid contents of variable must follow the TLS CipherList format
> defined in RFC 5246.
> +// The valid length of variable must be an integral multiple of 2.
> +// For example, if below cipher suites are preferred:
> +// 	 CipherSuite TLS_RSA_WITH_AES_128_CBC_SHA256 = {0x00,0x3C}
> +//   CipherSuite TLS_RSA_WITH_AES_256_CBC_SHA256 = {0x00,0x3D}
> +// Then, the contents of variable should be:
> +//   {0x00,0x3C,0x00,0x3D}
> +//
> +#define EDKII_HTTP_TLS_CIPHER_LIST_GUID \
> +  { \
> +    0x46ddb415, 0x5244, 0x49c7, { 0x93, 0x74, 0xf0, 0xe2, 0x98, 0xe7,
> 0xd3, 0x86 } \
> +  }
> +
> +#define EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE       L"HttpTlsCipherList"
> +
> +extern EFI_GUID gEdkiiHttpTlsCipherListGuid;
> +
> +#endif
> +
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] NetworkPkg: Correct HttpTlsCipherList.h file format to DOS
  2018-03-26  2:10 [Patch] NetworkPkg: Correct HttpTlsCipherList.h file format to DOS Liming Gao
  2018-03-26  3:02 ` Fu, Siyuan
@ 2018-03-26  3:27 ` Wu, Jiaxin
  1 sibling, 0 replies; 3+ messages in thread
From: Wu, Jiaxin @ 2018-03-26  3:27 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Fu, Siyuan

Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Monday, March 26, 2018 10:10 AM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [Patch] NetworkPkg: Correct HttpTlsCipherList.h file format
> to DOS
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> ---
>  NetworkPkg/Include/Guid/HttpTlsCipherList.h | 76 ++++++++++++++--------
> -------
>  1 file changed, 38 insertions(+), 38 deletions(-)
> 
> diff --git a/NetworkPkg/Include/Guid/HttpTlsCipherList.h
> b/NetworkPkg/Include/Guid/HttpTlsCipherList.h
> index bbfe488..bd30231 100644
> --- a/NetworkPkg/Include/Guid/HttpTlsCipherList.h
> +++ b/NetworkPkg/Include/Guid/HttpTlsCipherList.h
> @@ -1,38 +1,38 @@
> -/** @file
> -  This file defines the HttpTlsCipherList variable for HTTPS to configure Tls
> Cipher List.
> -
> -Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
> -This program and the accompanying materials are licensed and made
> available under
> -the terms and conditions of the BSD License that accompanies this
> distribution.
> -The full text of the license may be found at
> -http://opensource.org/licenses/bsd-license.php.
> -
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> -
> -**/
> -
> -#ifndef __HTTP_TLS_CIPHER_LIST_H__
> -#define __HTTP_TLS_CIPHER_LIST_H__
> -
> -//
> -// Private Variable for HTTPS to configure Tls Cipher List.
> -// The valid contents of variable must follow the TLS CipherList format
> defined in RFC 5246.
> -// The valid length of variable must be an integral multiple of 2.
> -// For example, if below cipher suites are preferred:
> -// 	 CipherSuite TLS_RSA_WITH_AES_128_CBC_SHA256 = {0x00,0x3C}
> -//   CipherSuite TLS_RSA_WITH_AES_256_CBC_SHA256 = {0x00,0x3D}
> -// Then, the contents of variable should be:
> -//   {0x00,0x3C,0x00,0x3D}
> -//
> -#define EDKII_HTTP_TLS_CIPHER_LIST_GUID \
> -  { \
> -    0x46ddb415, 0x5244, 0x49c7, { 0x93, 0x74, 0xf0, 0xe2, 0x98, 0xe7, 0xd3,
> 0x86 } \
> -  }
> -
> -#define EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE       L"HttpTlsCipherList"
> -
> -extern EFI_GUID gEdkiiHttpTlsCipherListGuid;
> -
> -#endif
> -
> +/** @file
> +  This file defines the HttpTlsCipherList variable for HTTPS to configure Tls
> Cipher List.
> +
> +Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
> +This program and the accompanying materials are licensed and made
> available under
> +the terms and conditions of the BSD License that accompanies this
> distribution.
> +The full text of the license may be found at
> +http://opensource.org/licenses/bsd-license.php.
> +
> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +
> +**/
> +
> +#ifndef __HTTP_TLS_CIPHER_LIST_H__
> +#define __HTTP_TLS_CIPHER_LIST_H__
> +
> +//
> +// Private Variable for HTTPS to configure Tls Cipher List.
> +// The valid contents of variable must follow the TLS CipherList format
> defined in RFC 5246.
> +// The valid length of variable must be an integral multiple of 2.
> +// For example, if below cipher suites are preferred:
> +// 	 CipherSuite TLS_RSA_WITH_AES_128_CBC_SHA256 = {0x00,0x3C}
> +//   CipherSuite TLS_RSA_WITH_AES_256_CBC_SHA256 = {0x00,0x3D}
> +// Then, the contents of variable should be:
> +//   {0x00,0x3C,0x00,0x3D}
> +//
> +#define EDKII_HTTP_TLS_CIPHER_LIST_GUID \
> +  { \
> +    0x46ddb415, 0x5244, 0x49c7, { 0x93, 0x74, 0xf0, 0xe2, 0x98, 0xe7, 0xd3,
> 0x86 } \
> +  }
> +
> +#define EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE       L"HttpTlsCipherList"
> +
> +extern EFI_GUID gEdkiiHttpTlsCipherListGuid;
> +
> +#endif
> +
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-26  3:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-26  2:10 [Patch] NetworkPkg: Correct HttpTlsCipherList.h file format to DOS Liming Gao
2018-03-26  3:02 ` Fu, Siyuan
2018-03-26  3:27 ` Wu, Jiaxin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox