From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2C5DD210C2787 for ; Mon, 30 Jul 2018 18:43:53 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2018 18:43:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,425,1526367600"; d="scan'208";a="71877088" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 30 Jul 2018 18:43:52 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 30 Jul 2018 18:43:52 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 30 Jul 2018 18:43:52 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Tue, 31 Jul 2018 09:43:50 +0800 From: "Wu, Jiaxin" To: Sivaraman Nainar , "Ye, Ting" , Laszlo Ersek , "edk2-devel@lists.01.org" Thread-Topic: [edk2] reg: HTTP Request Failure over Internet Thread-Index: AdQjRfAWnSCx4+HvRV6Kq9SvrqNFLf//hc4A//41h0D//FOIIP/vwuJA Date: Tue, 31 Jul 2018 01:43:49 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B727416479D8A@SHSMSX103.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjc4M2E2ZjMtNDg0Mi00ZjY3LWE1ODEtZGJkZTg2MDM5ZTM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZFd0WURVd09tSFVjZ0o2OFBDczBLZmdzZnlHRkJSazZTQzVGSVlsa01RU1J0MGc3M0RUck1xdjVKOWYxcG5VeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: reg: HTTP Request Failure over Internet X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 01:43:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Siva, Thanks the report.=20 >>From the code review, it does the problem for HTTP protocol to route the pa= ckage over Internet.=20 But I'm confused with your patch that how can you get the RouterAddr since = there is no interface for HTTP protocol to get the RouterAddr?=20 > + HttpInstance->Tcp4->Routes ( > + HttpInstance->Tcp4, > + FALSE, > + &HttpInstance->RemoteAddr, > + &Tcp4AP->SubnetMask, > + &HttpInstance->RouterAddr > + ); > + So, I prefer it's the UEFI Spec limitation that HTTP protocol doesn't provi= de us the interface to set the router info instead of setting it during HTT= P configuration. To mitigate the issue, below two solution/workaround can = be tried: 1) Ip4Config2 protocol can be leveraged by your HTTP application to registe= r one valid Ip4Gateway into the default route table (just like HttpBootDxe = -- HttpBootRegisterIp4Gateway()). The IP policy will route the packet by us= ing the instance's route table first, if not found, the default route table= will be tried.=20 2) Set the static Ip4Gateway via ifconfig shell command. The Ip4Gateway add= ress also will be set to default route table. Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Sivaraman Nainar > Sent: Wednesday, July 25, 2018 5:29 PM > To: Ye, Ting ; Laszlo Ersek ; edk2- > devel@lists.01.org > Subject: Re: [edk2] reg: HTTP Request Failure over Internet >=20 > Ting: >=20 > Please find the patch for reference. >=20 > Index: HttpProto.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D > --- HttpProto.c > +++ HttpProto.c > @@ -622,12 +622,20 @@ > Status =3D HttpInstance->Tcp4->Configure (HttpInstance->Tcp4, Tcp4CfgD= ata); > if (EFI_ERROR (Status)) { > DEBUG ((EFI_D_ERROR, "HttpConfigureTcp4 - %r\n", Status)); > return Status; > } >=20 > + HttpInstance->Tcp4->Routes ( > + HttpInstance->Tcp4, > + FALSE, > + &HttpInstance->RemoteAddr, > + &Tcp4AP->SubnetMask, > + &HttpInstance->RouterAddr > + ); > + > Status =3D HttpCreateTcp4ConnCloseEvent (HttpInstance); > if (EFI_ERROR (Status)) { > return Status; > } >=20 > Status =3D HttpCreateTcp4TxEvent (Wrap); >=20 > -Siva > -----Original Message----- > From: Ye, Ting [mailto:ting.ye@intel.com] > Sent: Wednesday, July 25, 2018 1:36 PM > To: Laszlo Ersek; Sivaraman Nainar; edk2-devel@lists.01.org > Subject: RE: [edk2] reg: HTTP Request Failure over Internet >=20 > Hi Siva, >=20 > I didn't receive your patch either. Thanks for reporting the issue, we wi= ll try > to reproduce it firstly. >=20 > Thanks, > Ting >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, July 24, 2018 8:43 PM > To: Sivaraman Nainar ; edk2-devel@lists.01.org > Subject: Re: [edk2] reg: HTTP Request Failure over Internet >=20 > On 07/24/18 14:05, Sivaraman Nainar wrote: > > Hello all, > > > > When an application tried to download the remote file over internet wit= h > the HTTP Get Request it getting failed. If we try via the Intranet then > application downloads the target file. > > > > The remote file is available in the Apache server. With the attached pa= tch > the download works fine in Internet and Intranet. > > > > Could you review the solution and feedback? >=20 > The edk2-devel list software does not reflect attachments to subscribers. >=20 > While I disagree with that practice in general -- it breaks conversations= where > people justifiedly post small attachments, such as PNG screenshots, > compressed log files and such --, for posting patches specifically, pleas= e use > git-format-patch and git-send-email. The patch should be in the body of t= he > email (please do not copy&paste the patch though; that is guaranteed not = to > work -- please use the git tools). >=20 > Official guidelines: >=20 > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development- > Process >=20 > Personal ones from yours truly: >=20 > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-gi= t- > guide-for-edk2-contributors-and-maintainers >=20 > Thanks, > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel