From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 72687210FC38B for ; Tue, 18 Sep 2018 19:21:40 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 19:21:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,392,1531810800"; d="scan'208";a="91767318" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 18 Sep 2018 19:21:39 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 19:21:39 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 19:21:38 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Wed, 19 Sep 2018 10:21:36 +0800 From: "Wu, Jiaxin" To: "Fu, Siyuan" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Shao, Ming" Thread-Topic: [Patch 4/5] MdeModulePkg/MdeModulePkg.dec: Define one PCD for PXE to specify MTFTP windowsize. Thread-Index: AQHUTkl8wOJOoIu9UUer3Iya8dvymKT2P2IAgACiy9A= Date: Wed, 19 Sep 2018 02:21:36 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B727416494140@SHSMSX103.ccr.corp.intel.com> References: <20180917054348.19228-1-Jiaxin.wu@intel.com> <20180917054348.19228-5-Jiaxin.wu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTUyYzMzNWEtMTQyZi00MDljLWFhZWUtNDAyZjcxNTM3OTM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYU1JcDNFc3llSGU2SDdPNDlzTVFORGxFeEdLVURCMk0xOWt0YnhXU2lrQkdESmsrN3BONDV2UDhDMktyOUtRYiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 4/5] MdeModulePkg/MdeModulePkg.dec: Define one PCD for PXE to specify MTFTP windowsize. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 02:21:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Siyuan, I will rename the PCD name for better understanding. > -----Original Message----- > From: Fu, Siyuan > Sent: Wednesday, September 19, 2018 8:38 AM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Shao, Ming > Subject: RE: [Patch 4/5] MdeModulePkg/MdeModulePkg.dec: Define one > PCD for PXE to specify MTFTP windowsize. >=20 > Hi, Jiaxin >=20 > I think we should also update the comments for PcdTftpWindowSize usage. > And could we change the name to PcdPxeTftpWindowSize since it only > impacts the PXE tftp download? >=20 > BestRegards > Fu Siyuan >=20 > > -----Original Message----- > > From: Wu, Jiaxin > > Sent: Monday, September 17, 2018 1:44 PM > > To: edk2-devel@lists.01.org > > Cc: Ye, Ting ; Fu, Siyuan ; Sha= o, > > Ming ; Wu, Jiaxin > > Subject: [Patch 4/5] MdeModulePkg/MdeModulePkg.dec: Define one PCD > for PXE > > to specify MTFTP windowsize. > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D886 > > > > This patch is to define one new PCD for PXE driver to specify MTFTP > > windowsize so as > > to improve the PXE download performance. The default value is set to 4. > > > > Cc: Ye Ting > > Cc: Fu Siyuan > > Cc: Shao Ming > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Wu Jiaxin > > --- > > MdeModulePkg/MdeModulePkg.dec | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > > index 74a699cbb7..bfc63e5fcb 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -1203,10 +1203,11 @@ > > ## This setting can override the default TFTP block size. A value of= 0 > > computes > > # the default from MTU information. A non-zero value will be used as > > block size > > # in bytes. > > # @Prompt TFTP block size. > > > gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize|0x0|UINT64|0x30001 > 026 > > + > gEfiMdeModulePkgTokenSpaceGuid.PcdTftpWindowSize|0x4|UINT64|0x30 > 00102A > > > > ## Maximum address that the DXE Core will allocate the > > EFI_SYSTEM_TABLE_POINTER > > # structure. The default value for this PCD is 0, which means that = the > > DXE Core > > # will allocate the buffer from the EFI_SYSTEM_TABLE_POINTER struct= ure > > on a 4MB > > # boundary as close to the top of memory as feasible. If this PCD = is > > set to a > > -- > > 2.17.1.windows.2