Re: [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in MdeModulePkg.

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Thanks the correction, I will refine all the patches according your comments before committing the patches. 

Best Regards!
Jiaxin


> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, September 25, 2018 6:31 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: Re: [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification
> compared to UefiPxeBcDxe in MdeModulePkg.
> 
> On 09/25/18 05:44, Jiaxin Wu wrote:
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> >
> > This patch is to add the driver usage/difference clarification
> > compared to UefiPxeBcDxe in MdeModulePkg.
> >
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > ---
> >  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > index e2a0eb44b1..f2ec34df93 100644
> > --- a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > +++ b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > @@ -1,12 +1,17 @@
> >  ## @file
> >  #  Access PXE-compatible devices for network access and network booting.
> >  #
> >  #  This driver provides PXE Base Code Protocol which is used to accessing
> > -#  PXE-compatible device for network access or booting. It could work
> together
> > -#  with an IPv4 stack, an IPv6 stack or both.
> > +#  PXE-compatible device for network access or booting. This driver
> supports
> > +#  both IPv4 and IPv6 network stack.
> >  #
> > +#  Notes:
> > +#  1) This driver can't co-work with the UefiPxeBcDxe driver in
> MdeModulePkg.
> > +#  2) This driver includes more bugs fix and supports more features (e.g.
> IPv6,
> > +#     MTFTP windowsize) than the UefiPxeBcDxe driver in MdeModulePkg.
> So, we
> > +#     recommand to use this driver even both of them can be used.
> >  #
> >  #  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> >  #
> >  #  This program and the accompanying materials
> >  #  are licensed and made available under the terms and conditions of the
> BSD License
> >
> 
> Same comments as for patch #4. With those updates:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks,
> Laszlo