public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>,
	"Fu, Siyuan" <siyuan.fu@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [Patch] ShellPkg/TftpDynamicCommand: Fix the potentially uninitialized local variable used.
Date: Fri, 28 Sep 2018 02:51:01 +0000	[thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B7274164B42A2@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BBF4697@shsmsx102.ccr.corp.intel.com>

Thanks Star, I have committed the patch since it resolves the VS2012 build error.

 

> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, September 28, 2018 10:31 AM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Carsey,
> Jaben <jaben.carsey@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [Patch] ShellPkg/TftpDynamicCommand: Fix the potentially
> uninitialized local variable used.
> 
> Reviewed-by: Star Zeng <star.zeng@intel.com>
> 
> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Thursday, September 27, 2018 10:42 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Carsey,
> Jaben <jaben.carsey@intel.com>; Zeng, Star <star.zeng@intel.com>; Wu,
> Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch] ShellPkg/TftpDynamicCommand: Fix the potentially
> uninitialized local variable used.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1217
> 
> Local variable 'Mtftp4Token' might be uninitialized when error happen. This
> patch is to resolve the issue.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Carsey Jaben <jaben.carsey@intel.com>
> Cc: Zeng Star <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> index c66be6b9d9..d4391b9f33 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> @@ -934,10 +934,12 @@ DownloadFile (
>    DOWNLOAD_CONTEXT      *TftpContext;
>    EFI_MTFTP4_TOKEN      Mtftp4Token;
>    UINT8                 BlksizeBuf[10];
>    UINT8                 WindowsizeBuf[10];
> 
> +  ZeroMem (&Mtftp4Token, sizeof (EFI_MTFTP4_TOKEN));
> +
>    // Downloaded file can be large. BS.AllocatePages() is more faster
>    // than AllocatePool() and avoid fragmentation.
>    // The downloaded file could be an EFI application. Marking the
>    // allocated page as EfiBootServicesCode would allow to execute a
>    // potential downloaded EFI application.
> @@ -959,11 +961,10 @@ DownloadFile (
>    }
>    TftpContext->FileSize = FileSize;
>    TftpContext->DownloadedNbOfBytes   = 0;
>    TftpContext->LastReportedNbOfBytes = 0;
> 
> -  ZeroMem (&Mtftp4Token, sizeof (EFI_MTFTP4_TOKEN));
>    Mtftp4Token.Filename    = (UINT8*)AsciiFilePath;
>    Mtftp4Token.BufferSize  = FileSize;
>    Mtftp4Token.Buffer      = Buffer;
>    Mtftp4Token.CheckPacket = CheckPacket;
>    Mtftp4Token.Context     = (VOID*)TftpContext;
> --
> 2.17.1.windows.2



      reply	other threads:[~2018-09-28  2:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 14:42 [Patch] ShellPkg/TftpDynamicCommand: Fix the potentially uninitialized local variable used Jiaxin Wu
2018-09-28  2:30 ` Zeng, Star
2018-09-28  2:51   ` Wu, Jiaxin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=895558F6EA4E3B41AC93A00D163B7274164B42A2@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox