Re: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>


> -----Original Message-----
> From: Vijayenthiran Subramaniam
> [mailto:vijayenthiran.subramaniam@arm.com]
> Sent: Wednesday, November 21, 2018 11:36 PM
> To: edk2-devel@lists.01.org; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> Cc: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> Subject: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable
> attempts
> 
> Add debug messages for failed attempts to write to a variable.
> 
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com>
> ---
> Made the log messages bit more useful.
> 
> Thanks,
> Vijayenthiran
> 
>  NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
> index dd0d32dcda16..7bed95a8fba3 100644
> --- a/NetworkPkg/IScsiDxe/IScsiMisc.c
> +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
> @@ -845,6 +845,10 @@ IScsiCreateAttempts (
>                      );
>      FreePool (AttemptConfigOrder);
>      if (EFI_ERROR (Status)) {
> +      DEBUG ((DEBUG_ERROR,
> +        "%a: Failed to set 'InitialAttemptOrder' with Guid (%g): "
> +        "%r\n",
> +        __FUNCTION__, &gIScsiConfigGuid, Status));
>        return Status;
>      }
> 
> @@ -887,6 +891,10 @@ IScsiCreateAttempts (
>                      );
>      FreePool (AttemptConfigData);
>      if (EFI_ERROR (Status)) {
> +        DEBUG ((DEBUG_ERROR,
> +          "%a: Failed to set variable (mPrivate->PortString) with Guid (%g): "
> +          "%r\n",
> +          __FUNCTION__, &gEfiIScsiInitiatorNameProtocolGuid, Status));
>        return Status;
>      }
>    }
> --
> 2.17.1