From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4537B21194891 for ; Thu, 22 Nov 2018 22:51:36 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Nov 2018 22:51:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,268,1539673200"; d="scan'208";a="110636070" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 22 Nov 2018 22:51:35 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 22 Nov 2018 22:51:34 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 22 Nov 2018 22:51:34 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Fri, 23 Nov 2018 14:51:33 +0800 From: "Wu, Jiaxin" To: Vijayenthiran Subramaniam , "edk2-devel@lists.01.org" , "Fu, Siyuan" Thread-Topic: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts Thread-Index: AQHUga/5aoFKC4/exEK+5NMSc+7F0KVc7n6A Date: Fri, 23 Nov 2018 06:51:32 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B7274164F6924@SHSMSX103.ccr.corp.intel.com> References: <20181121153559.12134-1-vijayenthiran.subramaniam@arm.com> In-Reply-To: <20181121153559.12134-1-vijayenthiran.subramaniam@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTgyMjkzZTctYjRlNC00MGNkLTg3N2YtMGNiNmVhNjdiYWVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0dPRTBJR2pVbkdpbmE1bFRNWHlHMVBoRjgwN1dnVXQwckh4Uzd2NElmRkZTSzBhUkhtZ2pHWnIwQlVjT0xBVyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 06:51:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiaxin Wu > -----Original Message----- > From: Vijayenthiran Subramaniam > [mailto:vijayenthiran.subramaniam@arm.com] > Sent: Wednesday, November 21, 2018 11:36 PM > To: edk2-devel@lists.01.org; Fu, Siyuan ; Wu, Jiaxin > > Cc: Vijayenthiran Subramaniam > Subject: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVar= iable > attempts >=20 > Add debug messages for failed attempts to write to a variable. >=20 > Cc: Siyuan Fu > Cc: Jiaxin Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam > > --- > Made the log messages bit more useful. >=20 > Thanks, > Vijayenthiran >=20 > NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiM= isc.c > index dd0d32dcda16..7bed95a8fba3 100644 > --- a/NetworkPkg/IScsiDxe/IScsiMisc.c > +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c > @@ -845,6 +845,10 @@ IScsiCreateAttempts ( > ); > FreePool (AttemptConfigOrder); > if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: Failed to set 'InitialAttemptOrder' with Guid (%g): " > + "%r\n", > + __FUNCTION__, &gIScsiConfigGuid, Status)); > return Status; > } >=20 > @@ -887,6 +891,10 @@ IScsiCreateAttempts ( > ); > FreePool (AttemptConfigData); > if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: Failed to set variable (mPrivate->PortString) with Guid (= %g): " > + "%r\n", > + __FUNCTION__, &gEfiIScsiInitiatorNameProtocolGuid, Status)); > return Status; > } > } > -- > 2.17.1