public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH v2 0/6] Delete TCP, PXE, iSCSI driver in MdeModulePkg
Date: Fri, 21 Dec 2018 04:00:40 +0000	[thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B72741650CDF1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181220014920.18124-1-siyuan.fu@intel.com>

Series Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>



> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Siyuan Fu
> Sent: Thursday, December 20, 2018 9:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>;
> Zeng, Star <star.zeng@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [PATCH v2 0/6] Delete TCP, PXE, iSCSI driver in
> MdeModulePkg
> 
> Delete TCP, PXE, iSCSI driver in MdeModulePkg
> 
> This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe
> drivers in MdeModulePkg. These drivers will not be maintained and can't
> co-work with the dual-stack drivers in NetworkPkg.
> 
> In future, people should use below NetworkPkg drivers instead:
>   NetworkPkg/IScsiDxe/IScsiDxe.inf
>   NetworkPkg/TcpDxe/TcpDxe.inf
>   NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> These drivers are actively maintained with more bug fixes and new feature
> support.
> 
> All edk2 platforms DSC/FDF have already been updated to use the
> NetworkPkg
> drivers in privious patch.
> 
> Bugzilla link: https://bugzilla.tianocore.org/show_bug.cgi?id=1278
> 
> v2:
> Break original patch to separate commits per module.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> 
> Siyuan Fu (6):
>   MdeModulePkg: Delete Tcp4Dxe in MdeModulePkg.
>   NetworkPkg: Remove some clarification from TcpDxe.inf
>   MdeModulePkg: Delete IScsiDxe in MdeModulePkg.
>   NetworkPkg: Remove some clarification from IScsiDxe.inf
>   MdeModulePkg: Delete UefiPxeBcDxe in MdeModulePkg.
>   NetworkPkg: Remove some clarification from UefiPxeBcDxe.inf
> 
>  .../Network/IScsiDxe/ComponentName.c          |  283 --
>  .../Universal/Network/IScsiDxe/IScsiCHAP.c    |  430 ---
>  .../Universal/Network/IScsiDxe/IScsiConfig.c  | 1264 -------
>  .../Universal/Network/IScsiDxe/IScsiDhcp.c    |  472 ---
>  .../Universal/Network/IScsiDxe/IScsiDriver.c  |  676 ----
>  .../Network/IScsiDxe/IScsiExtScsiPassThru.c   |  412 ---
>  .../Universal/Network/IScsiDxe/IScsiIbft.c    |  539 ---
>  .../Network/IScsiDxe/IScsiInitiatorName.c     |  116 -
>  .../Universal/Network/IScsiDxe/IScsiMisc.c    |  948 ------
>  .../Universal/Network/IScsiDxe/IScsiProto.c   | 2799 ---------------
>  .../Universal/Network/IScsiDxe/IScsiTcp4Io.c  |  487 ---
>  MdeModulePkg/Universal/Network/IScsiDxe/Md5.c |  350 --
>  .../Universal/Network/Tcp4Dxe/ComponentName.c |  433 ---
>  .../Universal/Network/Tcp4Dxe/SockImpl.c      | 1201 -------
>  .../Universal/Network/Tcp4Dxe/SockInterface.c |  990 ------
>  .../Network/Tcp4Dxe/Tcp4Dispatcher.c          |  717 ----
>  .../Universal/Network/Tcp4Dxe/Tcp4Driver.c    |  782 -----
>  .../Universal/Network/Tcp4Dxe/Tcp4Input.c     | 1497 ---------
>  .../Universal/Network/Tcp4Dxe/Tcp4Io.c        |  112 -
>  .../Universal/Network/Tcp4Dxe/Tcp4Main.c      |  674 ----
>  .../Universal/Network/Tcp4Dxe/Tcp4Misc.c      |  940 ------
>  .../Universal/Network/Tcp4Dxe/Tcp4Option.c    |  352 --
>  .../Universal/Network/Tcp4Dxe/Tcp4Output.c    | 1238 -------
>  .../Universal/Network/Tcp4Dxe/Tcp4Timer.c     |  584 ----
>  .../Network/UefiPxeBcDxe/ComponentName.c      |  365 --
>  .../Network/UefiPxeBcDxe/PxeBcDhcp.c          | 1999 -----------
>  .../Network/UefiPxeBcDxe/PxeBcDriver.c        |  665 ----
>  .../Network/UefiPxeBcDxe/PxeBcImpl.c          | 2989 -----------------
>  .../Network/UefiPxeBcDxe/PxeBcMtftp.c         |  454 ---
>  .../Network/UefiPxeBcDxe/PxeBcSupport.c       |  221 --
>  MdeModulePkg/MdeModulePkg.dsc                 |    3 -
>  .../Network/IScsiDxe/ComponentName.h          |  165 -
>  .../Universal/Network/IScsiDxe/IScsi4Dxe.uni  |   25 -
>  .../Network/IScsiDxe/IScsi4DxeExtra.uni       |   20 -
>  .../Universal/Network/IScsiDxe/IScsiCHAP.h    |  106 -
>  .../Universal/Network/IScsiDxe/IScsiCommon.h  |   22 -
>  .../Universal/Network/IScsiDxe/IScsiConfig.h  |  166 -
>  .../Network/IScsiDxe/IScsiConfigDxe.vfr       |  219 --
>  .../IScsiDxe/IScsiConfigDxeStrings.uni        |   62 -
>  .../Network/IScsiDxe/IScsiConfigNVDataStruc.h |  109 -
>  .../Universal/Network/IScsiDxe/IScsiDhcp.h    |   55 -
>  .../Universal/Network/IScsiDxe/IScsiDriver.h  |  140 -
>  .../Universal/Network/IScsiDxe/IScsiDxe.inf   |  134 -
>  .../Network/IScsiDxe/IScsiExtScsiPassThru.h   |   22 -
>  .../Universal/Network/IScsiDxe/IScsiIbft.h    |   38 -
>  .../Universal/Network/IScsiDxe/IScsiImpl.h    |  168 -
>  .../Network/IScsiDxe/IScsiInitiatorName.h     |   74 -
>  .../Universal/Network/IScsiDxe/IScsiMisc.h    |  317 --
>  .../Universal/Network/IScsiDxe/IScsiProto.h   | 1005 ------
>  .../Universal/Network/IScsiDxe/IScsiTcp4Io.h  |  142 -
>  MdeModulePkg/Universal/Network/IScsiDxe/Md5.h |   80 -
>  .../Universal/Network/Tcp4Dxe/SockImpl.h      |  131 -
>  .../Universal/Network/Tcp4Dxe/Socket.h        |  954 ------
>  .../Universal/Network/Tcp4Dxe/Tcp4Driver.h    |  342 --
>  .../Universal/Network/Tcp4Dxe/Tcp4Dxe.inf     |   94 -
>  .../Universal/Network/Tcp4Dxe/Tcp4Dxe.uni     |   23 -
>  .../Network/Tcp4Dxe/Tcp4DxeExtra.uni          |   20 -
>  .../Universal/Network/Tcp4Dxe/Tcp4Func.h      |  781 -----
>  .../Universal/Network/Tcp4Dxe/Tcp4Main.h      |  494 ---
>  .../Universal/Network/Tcp4Dxe/Tcp4Option.h    |  130 -
>  .../Universal/Network/Tcp4Dxe/Tcp4Proto.h     |  357 --
>  .../Network/UefiPxeBcDxe/PxeBcDhcp.h          |  502 ---
>  .../Network/UefiPxeBcDxe/PxeBcDriver.h        |  102 -
>  .../Network/UefiPxeBcDxe/PxeBcImpl.h          |  189 --
>  .../Network/UefiPxeBcDxe/PxeBcMtftp.h         |  137 -
>  .../Network/UefiPxeBcDxe/PxeBcSupport.h       |  134 -
>  .../Network/UefiPxeBcDxe/UefiPxe4BcDxe.uni    |   25 -
>  .../UefiPxeBcDxe/UefiPxe4BcDxeExtra.uni       |   20 -
>  .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf     |  102 -
>  NetworkPkg/IScsiDxe/IScsiDxe.inf              |   10 -
>  NetworkPkg/TcpDxe/TcpDxe.inf                  |    6 -
>  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf      |    6 -
>  72 files changed, 32620 deletions(-)
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/ComponentName.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiInitiatorName.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.c
>  delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/Md5.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/ComponentName.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dispatcher.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Driver.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c
>  delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Io.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Output.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Timer.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/ComponentName.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDriver.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.c
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/ComponentName.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsi4Dxe.uni
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsi4DxeExtra.uni
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiCommon.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigDxe.vfr
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigDxeStrings.uni
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigNVDataStruc.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiInitiatorName.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.h
>  delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/Md5.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.h
>  delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Driver.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.uni
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4DxeExtra.uni
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Func.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Proto.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDriver.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.h
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxe4BcDxe.uni
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxe4BcDxeExtra.uni
>  delete mode 100644
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> 
> --
> 2.19.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-12-21  4:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20  1:49 [PATCH v2 0/6] Delete TCP, PXE, iSCSI driver in MdeModulePkg Siyuan Fu
2018-12-21  4:00 ` Wu, Jiaxin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-12-20  1:41 Siyuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=895558F6EA4E3B41AC93A00D163B72741650CDF1@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox