From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Gao, Liming" <liming.gao@intel.com>
Cc: "Fu, Siyuan" <siyuan.fu@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Ye, Ting" <ting.ye@intel.com>
Subject: Re: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.
Date: Sun, 20 Jan 2019 18:25:54 +0000 [thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B727416EC6CD7@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <70bb0ff8-09fe-42c9-0152-ffed039033bd@redhat.com>
> >> This is my idea to avoid the duplicated mail. I also include Ard and Laszlo to
> collect the feedback on how to handle the partial update in the patchset.
> >>
> >
> > Laszlo may disagree with me, but I think that it is not always
> > necessary to resend the entire series when only a single patch
> > changes. It does depend on the situation, though: if it is a trivial
> > patch in a more complicated series then it might make little sense. In
> > other case, just resending the whole thing is probably better.
>
> I think resending one patch can be acceptable, but the subject line
> (patch nr) and the threading have to be correct. Also, I don't think
> this approach scales beyond exactly one patch-update; it's easy to lose
> track of version numbers etc. So "use sparingly" I guess? :)
>
Thanks all of your comments, to avoid the missing version track, I have resent the whole patch to version 3:).
Best Regard!
Jiaxin
next prev parent reply other threads:[~2019-01-20 18:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 5:16 [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check Jiaxin Wu
2019-01-18 5:22 ` Wu, Hao A
2019-01-18 5:29 ` Fu, Siyuan
2019-01-18 5:31 ` Wu, Jiaxin
2019-01-18 5:38 ` Gao, Liming
2019-01-18 11:09 ` Ard Biesheuvel
2019-01-19 1:17 ` Laszlo Ersek
2019-01-20 18:25 ` Wu, Jiaxin [this message]
2019-01-21 12:53 ` Gao, Liming
2019-01-21 13:26 ` Philippe Mathieu-Daudé
2019-01-21 21:21 ` Laszlo Ersek
2019-01-21 22:47 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895558F6EA4E3B41AC93A00D163B727416EC6CD7@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox