From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82F7D21B02822 for ; Fri, 25 Jan 2019 00:44:21 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2019 00:44:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,520,1539673200"; d="scan'208";a="110965579" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 25 Jan 2019 00:44:20 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 25 Jan 2019 00:44:18 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 25 Jan 2019 00:44:17 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.162]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.194]) with mapi id 14.03.0415.000; Fri, 25 Jan 2019 16:44:12 +0800 From: "Wu, Jiaxin" To: "Tomas Pilar (tpilar)" , Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Ye, Ting" Thread-Topic: [edk2] Network Stack Budgeting Thread-Index: AQHUswuSsrPW2aNDW0SiTKzGhxIJZ6W8f6AAgAAFHoCAAGJEgIAA3z4AgAANYgCAAAkvAIAAB4QAgAA46ICAAA8rAIABfOPg Date: Fri, 25 Jan 2019 08:44:11 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B727416ECCDAA@SHSMSX107.ccr.corp.intel.com> References: <6029fb15-3820-0f05-f02a-577e99592bbc@solarflare.com> <32137552-e2b0-4392-17c7-dedaa1f05244@redhat.com> <09017041-d418-1186-9942-dfa70d82c4d6@solarflare.com> <67f8fb4a-5e1b-8bbc-90d4-670ff7e3bfe8@redhat.com> <5185c0b2-031f-ec50-b273-2665d83ef38a@solarflare.com> <923ebd9f-ef26-c96d-37cc-5cc76f88fea1@solarflare.com> <770c5b55-32b1-c2f3-f3de-b25de5f2b37d@solarflare.com> <841c4437-ad73-64d5-0eb8-cfc0220cc55d@solarflare.com> In-Reply-To: <841c4437-ad73-64d5-0eb8-cfc0220cc55d@solarflare.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGJmNGFkMTQtYTczMS00ZmMwLWEyN2EtNTc2YjU3ZWMyZTRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUlp5bnF4aW9HZ2g5b2duXC9ENVV5Y2pxVnhLTWpvWVc4M1NZakJcL29jT2FOUUYycTJmVXkwcXFHUERMaXk4SmdnIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: Network Stack Budgeting X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 08:44:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Tom, One thing I want to highlight is that our design of network stack is not on= ly for the PXE/HTTP boot trigged in BootManager, but also to make sure it's= workable once there is any MNP instance configured by upper drivers (ARP/I= Pv4/IPv6).=20 Take ARP/IP as an example, once ARP/IP are started, we need a heartbeat to = process any ARP requests, which is required by ARP functionality. In such a= case, SNP must be started to make ARP/IP drivers works well.=20 Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Tomas Pilar (tpilar) > Sent: Friday, January 25, 2019 1:43 AM > To: Laszlo Ersek ; edk2-devel@lists.01.org > Subject: Re: [edk2] Network Stack Budgeting >=20 >=20 >=20 > On 24/01/2019 16:49, Laszlo Ersek wrote: > > On 01/24/19 14:25, Tomas Pilar (tpilar) wrote: > >> Hmm, > >> > >> Mnp->Configure() will eventually call MnpStartSnp(). > >> > >> A grep for Mnp->Configure shows that: > >> * ArpDxe performs this on DriverBinding.Start() > >> * Ip6Dxe performs this on DriverBinding.Start() > >> > >> Ipv4 and DnsDhcp do this as a part of their Configure() they expose in= the > API. > > Yes, that makes sense. All of the above drivers are UEFI drivers that > > follow the UEFI driver model, AIUI. As long as the controller is not > > connected from BDS, no BindingStart() function should be called in thes= e. > Ah, but I would expect the BDS to call ConnectController() on the NIC, bu= t I > would not expect the network stack to be started unless the device is > actually chosen for PXE booting. In other words, the above protocols shou= ld > follow the example of EFI_DNS4_PROTOCOL that binds against the device > during BDS but .Configure() is not automatically called by > DriverBinding.Start(). >=20 > .Configure() should be called by the BootManager if networking is actuall= y to > be done. That in turn will configure Mnp and start Snp. >=20 > Cheers, > Tom >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel