Re: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration during driver start.

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Looks it's enough to add the warning debug message. I have sent the version 2 patch to do that.

Thanks,
Jiaxin 


> -----Original Message-----
> From: Fu, Siyuan
> Sent: Tuesday, February 12, 2019 8:28 AM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>
> Cc: edk2-devel@lists.01.org; Mike Turner <Michael.Turner@microsoft.com>;
> Ye, Ting <ting.ye@intel.com>
> Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6
> configuration during driver start.
> 
> Yes, Jiaxin. You should not use popup messages unless you 100 percent sure
> the code is running in setup browser.
> 
> BestRegards
> Fu Siyuan
> 
> 
> > -----Original Message-----
> > From: Mike Turner [mailto:Michael.Turner@microsoft.com]
> > Sent: Monday, February 11, 2019 11:10 PM
> > To: Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>; edk2-
> > devel@lists.01.org
> > Cc: Fu, Siyuan <siyuan.fu@intel.com>
> > Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6
> > configuration during driver start.
> >
> > I haven't seen any patch for a popup, but message popups during driver
> binding
> > start are not a good thing.
> >
> > Michael R Turner
> > Surface UEFI Development
> > Microsoft Corporation
> > One Redmond Way
> > Redmond WA 98052
> >
> > 425-705-0928
> >
> > This email message may contain confidential and privileged
> information.  Any
> > unauthorized use is prohibited.  If you are not the intended recipient,
> please
> > contact the sender by reply email and destroy all copies of the original
> > message.
> >
> >
> > -----Original Message-----
> > From: Wu, Jiaxin <jiaxin.wu@intel.com>
> > Sent: Sunday, February 10, 2019 7:10 PM
> > To: Ye, Ting <ting.ye@intel.com>; edk2-devel@lists.01.org
> > Cc: Mike Turner <Michael.Turner@microsoft.com>; Fu, Siyuan
> > <siyuan.fu@intel.com>
> > Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6
> > configuration during driver start.
> >
> > Agree, thanks the comment. I will update the patch.
> >
> >
> >
> > > -----Original Message-----
> > > From: Ye, Ting
> > > Sent: Monday, February 11, 2019 11:09 AM
> > > To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> > > Cc: Michael Turner <Michael.Turner@microsoft.com>; Fu, Siyuan
> > > <siyuan.fu@intel.com>
> > > Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6
> > > configuration during driver start.
> > >
> > > Hi Jiaxin,
> > >
> > > I agree we need start IPv6 stack no matter the configuration is valid or not.
> > > However I would suggest to add more comments and pop up warning
> > > messages to let user know we continue to start IPv6 stack without
> > > using previously saved configuration.
> > >
> > > Thanks,
> > > Ting
> > >
> > > -----Original Message-----
> > > From: Wu, Jiaxin
> > > Sent: Sunday, February 3, 2019 2:24 PM
> > > To: edk2-devel@lists.01.org
> > > Cc: Michael Turner <Michael.Turner@microsoft.com>; Ye, Ting
> > > <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> > > <jiaxin.wu@intel.com>
> > > Subject: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6
> > > configuration during driver start.
> > >
> > > REF:
> > >
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> > >
> illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D1448&amp;data=02%7C01%7C
> Micha
> > >
> el.Turner%40microsoft.com%7C93fb5d7f003b48c6561d08d68fce66f4%7C72f9
> 88b
> > >
> f86f141af91ab2d7cd011db47%7C1%7C0%7C636854514000398927&amp;sdata
> =bCAbT
> > > njjX9bmuRiASoCkPiZtdqUY14BDMgyLd%2BYNNx4%3D&amp;reserved=0
> > >
> > > This patch is to clean the invalid data and continue to start IP6 driver.
> > >
> > > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > > Cc: Ye Ting <ting.ye@intel.com>
> > > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > > Signed-off-by: Michael Turner <Michael.Turner@microsoft.com>
> > > ---
> > >  NetworkPkg/Ip6Dxe/Ip6Driver.c | 20 ++++++++++++++++++--
> > >  1 file changed, 18 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/NetworkPkg/Ip6Dxe/Ip6Driver.c
> > > b/NetworkPkg/Ip6Dxe/Ip6Driver.c index 4c607125a6..1bd1c61da8 100644
> > > --- a/NetworkPkg/Ip6Dxe/Ip6Driver.c
> > > +++ b/NetworkPkg/Ip6Dxe/Ip6Driver.c
> > > @@ -586,11 +586,19 @@ Ip6DriverBindingStart (
> > >                         Ip6ConfigDataTypeManualAddress,
> > >                         DataItem->DataSize,
> > >                         DataItem->Data.Ptr
> > >                         );
> > >      if (EFI_ERROR(Status) && Status != EFI_NOT_READY) {
> > > -      goto UNINSTALL_PROTOCOL;
> > > +      //
> > > +      // Clean the invalid ManualAddress configuration.
> > > +      //
> > > +      Status = Ip6Cfg->SetData (
> > > +                         Ip6Cfg,
> > > +                         Ip6ConfigDataTypeManualAddress,
> > > +                         0,
> > > +                         NULL
> > > +                         );
> > >      }
> > >    }
> > >
> > >    //
> > >    // If there is any default gateway address, set it.
> > > @@ -602,11 +610,19 @@ Ip6DriverBindingStart (
> > >                         Ip6ConfigDataTypeGateway,
> > >                         DataItem->DataSize,
> > >                         DataItem->Data.Ptr
> > >                         );
> > >      if (EFI_ERROR(Status)) {
> > > -      goto UNINSTALL_PROTOCOL;
> > > +      //
> > > +      // Clean the invalid Gateway configuration.
> > > +      //
> > > +      Status = Ip6Cfg->SetData (
> > > +                         Ip6Cfg,
> > > +                         Ip6ConfigDataTypeGateway,
> > > +                         0,
> > > +                         NULL
> > > +                         );
> > >      }
> > >    }
> > >
> > >    //
> > >    // ready to go: start the receiving and timer
> > > --
> > > 2.17.1.windows.2