From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0C7BC2194EB70 for ; Mon, 11 Feb 2019 16:48:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2019 16:48:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,361,1544515200"; d="scan'208";a="146042752" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 11 Feb 2019 16:48:12 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 11 Feb 2019 16:48:12 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 11 Feb 2019 16:48:11 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.162]) by shsmsx102.ccr.corp.intel.com ([169.254.2.207]) with mapi id 14.03.0415.000; Tue, 12 Feb 2019 08:48:09 +0800 From: "Wu, Jiaxin" To: "Fu, Siyuan" CC: "edk2-devel@lists.01.org" , Mike Turner , "Ye, Ting" Thread-Topic: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration during driver start. Thread-Index: AQHUu4kH3vP/BUsduEeSS/yCVujCeaXZcQMAgACGRUCAAENUgIAAm9EAgACGQNA= Date: Tue, 12 Feb 2019 00:48:08 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B727416ED03C3@SHSMSX107.ccr.corp.intel.com> References: <20190203062345.996-1-Jiaxin.wu@intel.com> <895558F6EA4E3B41AC93A00D163B727416ECFF52@SHSMSX107.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzkzM2JhYTQtY2M0Mi00MjQ3LTkyZGYtYTE3NDIyOGI3MTBiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0tXd25uVFBQczZUUnJpaWFBekMra2hjTU4yZG96UlA5d0NDUnJpcWlEaGlzaFdETHB5MUZQcmF6Z1VvNkxGZCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration during driver start. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 00:48:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Looks it's enough to add the warning debug message. I have sent the version= 2 patch to do that. Thanks, Jiaxin=20 > -----Original Message----- > From: Fu, Siyuan > Sent: Tuesday, February 12, 2019 8:28 AM > To: Wu, Jiaxin > Cc: edk2-devel@lists.01.org; Mike Turner ; > Ye, Ting > Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 > configuration during driver start. >=20 > Yes, Jiaxin. You should not use popup messages unless you 100 percent sur= e > the code is running in setup browser. >=20 > BestRegards > Fu Siyuan >=20 >=20 > > -----Original Message----- > > From: Mike Turner [mailto:Michael.Turner@microsoft.com] > > Sent: Monday, February 11, 2019 11:10 PM > > To: Wu, Jiaxin ; Ye, Ting ; edk= 2- > > devel@lists.01.org > > Cc: Fu, Siyuan > > Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 > > configuration during driver start. > > > > I haven't seen any patch for a popup, but message popups during driver > binding > > start are not a good thing. > > > > Michael R Turner > > Surface UEFI Development > > Microsoft Corporation > > One Redmond Way > > Redmond WA 98052 > > > > 425-705-0928 > > > > This email message may contain confidential and privileged > information.=A0 Any > > unauthorized use is prohibited.=A0 If you are not the intended recipien= t, > please > > contact the sender by reply email and destroy all copies of the origina= l > > message. > > > > > > -----Original Message----- > > From: Wu, Jiaxin > > Sent: Sunday, February 10, 2019 7:10 PM > > To: Ye, Ting ; edk2-devel@lists.01.org > > Cc: Mike Turner ; Fu, Siyuan > > > > Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 > > configuration during driver start. > > > > Agree, thanks the comment. I will update the patch. > > > > > > > > > -----Original Message----- > > > From: Ye, Ting > > > Sent: Monday, February 11, 2019 11:09 AM > > > To: Wu, Jiaxin ; edk2-devel@lists.01.org > > > Cc: Michael Turner ; Fu, Siyuan > > > > > > Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 > > > configuration during driver start. > > > > > > Hi Jiaxin, > > > > > > I agree we need start IPv6 stack no matter the configuration is valid= or not. > > > However I would suggest to add more comments and pop up warning > > > messages to let user know we continue to start IPv6 stack without > > > using previously saved configuration. > > > > > > Thanks, > > > Ting > > > > > > -----Original Message----- > > > From: Wu, Jiaxin > > > Sent: Sunday, February 3, 2019 2:24 PM > > > To: edk2-devel@lists.01.org > > > Cc: Michael Turner ; Ye, Ting > > > ; Fu, Siyuan ; Wu, Jiaxin > > > > > > Subject: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 > > > configuration during driver start. > > > > > > REF: > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugz > > > > illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D1448&data=3D02%7C01%7C > Micha > > > > el.Turner%40microsoft.com%7C93fb5d7f003b48c6561d08d68fce66f4%7C72f9 > 88b > > > > f86f141af91ab2d7cd011db47%7C1%7C0%7C636854514000398927&sdata > =3DbCAbT > > > njjX9bmuRiASoCkPiZtdqUY14BDMgyLd%2BYNNx4%3D&reserved=3D0 > > > > > > This patch is to clean the invalid data and continue to start IP6 dri= ver. > > > > > > Cc: Michael Turner > > > Cc: Ye Ting > > > Cc: Fu Siyuan > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Wu Jiaxin > > > Signed-off-by: Michael Turner > > > --- > > > NetworkPkg/Ip6Dxe/Ip6Driver.c | 20 ++++++++++++++++++-- > > > 1 file changed, 18 insertions(+), 2 deletions(-) > > > > > > diff --git a/NetworkPkg/Ip6Dxe/Ip6Driver.c > > > b/NetworkPkg/Ip6Dxe/Ip6Driver.c index 4c607125a6..1bd1c61da8 100644 > > > --- a/NetworkPkg/Ip6Dxe/Ip6Driver.c > > > +++ b/NetworkPkg/Ip6Dxe/Ip6Driver.c > > > @@ -586,11 +586,19 @@ Ip6DriverBindingStart ( > > > Ip6ConfigDataTypeManualAddress, > > > DataItem->DataSize, > > > DataItem->Data.Ptr > > > ); > > > if (EFI_ERROR(Status) && Status !=3D EFI_NOT_READY) { > > > - goto UNINSTALL_PROTOCOL; > > > + // > > > + // Clean the invalid ManualAddress configuration. > > > + // > > > + Status =3D Ip6Cfg->SetData ( > > > + Ip6Cfg, > > > + Ip6ConfigDataTypeManualAddress, > > > + 0, > > > + NULL > > > + ); > > > } > > > } > > > > > > // > > > // If there is any default gateway address, set it. > > > @@ -602,11 +610,19 @@ Ip6DriverBindingStart ( > > > Ip6ConfigDataTypeGateway, > > > DataItem->DataSize, > > > DataItem->Data.Ptr > > > ); > > > if (EFI_ERROR(Status)) { > > > - goto UNINSTALL_PROTOCOL; > > > + // > > > + // Clean the invalid Gateway configuration. > > > + // > > > + Status =3D Ip6Cfg->SetData ( > > > + Ip6Cfg, > > > + Ip6ConfigDataTypeGateway, > > > + 0, > > > + NULL > > > + ); > > > } > > > } > > > > > > // > > > // ready to go: start the receiving and timer > > > -- > > > 2.17.1.windows.2