From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiaxin.wu@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Wed, 22 May 2019 18:47:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 18:47:49 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 22 May 2019 18:47:49 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 18:47:49 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 18:47:48 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.7]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.10]) with mapi id 14.03.0415.000; Thu, 23 May 2019 09:47:44 +0800 From: "Wu, Jiaxin" To: "devel@edk2.groups.io" , "Gao, Liming" CC: "Fu, Siyuan" Subject: Re: [edk2-devel] [Patch 2/3] NetworkPkg: Move Network library header file from MdeModulePkg to NetworkPkg Thread-Topic: [edk2-devel] [Patch 2/3] NetworkPkg: Move Network library header file from MdeModulePkg to NetworkPkg Thread-Index: AQHVCxYZsW3nBXVmvUeZ2gqZN/dEKqZ3/MUQ Date: Thu, 23 May 2019 01:47:44 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B727416EFA9CC@SHSMSX107.ccr.corp.intel.com> References: <20190515120220.1112-1-liming.gao@intel.com> <20190515120220.1112-3-liming.gao@intel.com> In-Reply-To: <20190515120220.1112-3-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzU2YzRhMDItMmNlZC00NjI3LWFlOGQtZWNhNGI0MTk3MmI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibEsxTXFIZ0VEWEFLR0hYaENXc1NVajhTRkZqaWNZMXpZYU51OVBwMGFaVHQrakF3WHJINWlvT2dGdWxVMEJGSiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiaxin.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiaxin Wu > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Wednesday, May 15, 2019 8:02 PM > To: devel@edk2.groups.io > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [edk2-devel] [Patch 2/3] NetworkPkg: Move Network library heade= r > file from MdeModulePkg to NetworkPkg >=20 > Signed-off-by: Liming Gao > Cc: Siyuan Fu > Cc: Jiaxin Wu > --- > NetworkPkg/Application/VConfig/VConfig.inf | 1 + > NetworkPkg/ArpDxe/ArpDxe.inf | 1 + > NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf | 1 + > NetworkPkg/DnsDxe/DnsDxe.inf | 1 + > NetworkPkg/DpcDxe/DpcDxe.inf | 1 + > NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf | 1 + > .../Include/Library/DpcLib.h | 0 > .../Include/Library/HttpLib.h | 0 > .../Include/Library/IpIoLib.h | 0 > .../Include/Library/NetLib.h | 0 > .../Include/Library/TcpIoLib.h | 0 > .../Include/Library/UdpIoLib.h | 0 > NetworkPkg/Ip4Dxe/Ip4Dxe.inf | 1 + > NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf | 1 + > NetworkPkg/Library/DxeHttpLib/DxeHttpLib.inf | 1 + > NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.inf | 1 + > NetworkPkg/Library/DxeNetLib/DxeNetLib.inf | 1 + > NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf | 1 + > NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf | 1 + > NetworkPkg/MnpDxe/MnpDxe.inf | 1 + > NetworkPkg/Mtftp4Dxe/Mtftp4Dxe.inf | 1 + > NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf | 1 + > NetworkPkg/NetworkPkg.dec | 24 +++++++++++++++= +++++++ > NetworkPkg/SnpDxe/SnpDxe.inf | 1 + > NetworkPkg/TcpDxe/TcpDxe.inf | 1 + > NetworkPkg/TlsDxe/TlsDxe.inf | 1 + > NetworkPkg/Udp4Dxe/Udp4Dxe.inf | 1 + > NetworkPkg/Udp6Dxe/Udp6Dxe.inf | 1 + > NetworkPkg/VlanConfigDxe/VlanConfigDxe.inf | 1 + > 29 files changed, 46 insertions(+) > rename {MdeModulePkg =3D> NetworkPkg}/Include/Library/DpcLib.h (100%) > rename {MdeModulePkg =3D> NetworkPkg}/Include/Library/HttpLib.h (100%) > rename {MdeModulePkg =3D> NetworkPkg}/Include/Library/IpIoLib.h (100%) > rename {MdeModulePkg =3D> NetworkPkg}/Include/Library/NetLib.h (100%) > rename {MdeModulePkg =3D> NetworkPkg}/Include/Library/TcpIoLib.h (100%) > rename {MdeModulePkg =3D> NetworkPkg}/Include/Library/UdpIoLib.h > (100%) >=20 > diff --git a/NetworkPkg/Application/VConfig/VConfig.inf > b/NetworkPkg/Application/VConfig/VConfig.inf > index 2e6cd1aef3..1d7a81201e 100644 > --- a/NetworkPkg/Application/VConfig/VConfig.inf > +++ b/NetworkPkg/Application/VConfig/VConfig.inf > @@ -35,6 +35,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec > ShellPkg/ShellPkg.dec >=20 > [LibraryClasses] > diff --git a/NetworkPkg/ArpDxe/ArpDxe.inf > b/NetworkPkg/ArpDxe/ArpDxe.inf > index 78344edf90..2ff74895a6 100644 > --- a/NetworkPkg/ArpDxe/ArpDxe.inf > +++ b/NetworkPkg/ArpDxe/ArpDxe.inf > @@ -42,6 +42,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf > b/NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf > index 62883518b2..e34aab0a6b 100644 > --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf > +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf > @@ -44,6 +44,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/DnsDxe/DnsDxe.inf > b/NetworkPkg/DnsDxe/DnsDxe.inf > index 6298aadc8c..3a66bdd13a 100644 > --- a/NetworkPkg/DnsDxe/DnsDxe.inf > +++ b/NetworkPkg/DnsDxe/DnsDxe.inf > @@ -21,6 +21,7 @@ [Defines] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [Sources] > ComponentName.c > diff --git a/NetworkPkg/DpcDxe/DpcDxe.inf > b/NetworkPkg/DpcDxe/DpcDxe.inf > index 8c241d7f46..1462de28a2 100644 > --- a/NetworkPkg/DpcDxe/DpcDxe.inf > +++ b/NetworkPkg/DpcDxe/DpcDxe.inf > @@ -29,6 +29,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > UefiDriverEntryPoint > diff --git a/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > b/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > index fe08d542b8..e12c3cc922 100644 > --- a/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > +++ b/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > @@ -22,6 +22,7 @@ [Defines] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [Sources] > HttpUtilitiesDxe.h > diff --git a/MdeModulePkg/Include/Library/DpcLib.h > b/NetworkPkg/Include/Library/DpcLib.h > similarity index 100% > rename from MdeModulePkg/Include/Library/DpcLib.h > rename to NetworkPkg/Include/Library/DpcLib.h > diff --git a/MdeModulePkg/Include/Library/HttpLib.h > b/NetworkPkg/Include/Library/HttpLib.h > similarity index 100% > rename from MdeModulePkg/Include/Library/HttpLib.h > rename to NetworkPkg/Include/Library/HttpLib.h > diff --git a/MdeModulePkg/Include/Library/IpIoLib.h > b/NetworkPkg/Include/Library/IpIoLib.h > similarity index 100% > rename from MdeModulePkg/Include/Library/IpIoLib.h > rename to NetworkPkg/Include/Library/IpIoLib.h > diff --git a/MdeModulePkg/Include/Library/NetLib.h > b/NetworkPkg/Include/Library/NetLib.h > similarity index 100% > rename from MdeModulePkg/Include/Library/NetLib.h > rename to NetworkPkg/Include/Library/NetLib.h > diff --git a/MdeModulePkg/Include/Library/TcpIoLib.h > b/NetworkPkg/Include/Library/TcpIoLib.h > similarity index 100% > rename from MdeModulePkg/Include/Library/TcpIoLib.h > rename to NetworkPkg/Include/Library/TcpIoLib.h > diff --git a/MdeModulePkg/Include/Library/UdpIoLib.h > b/NetworkPkg/Include/Library/UdpIoLib.h > similarity index 100% > rename from MdeModulePkg/Include/Library/UdpIoLib.h > rename to NetworkPkg/Include/Library/UdpIoLib.h > diff --git a/NetworkPkg/Ip4Dxe/Ip4Dxe.inf b/NetworkPkg/Ip4Dxe/Ip4Dxe.inf > index ff9f32174e..852932f3c3 100644 > --- a/NetworkPkg/Ip4Dxe/Ip4Dxe.inf > +++ b/NetworkPkg/Ip4Dxe/Ip4Dxe.inf > @@ -66,6 +66,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > UefiLib > diff --git a/NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf > b/NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf > index 1c23729ce3..3fb8718f1e 100644 > --- a/NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf > +++ b/NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf > @@ -28,6 +28,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > DebugLib > diff --git a/NetworkPkg/Library/DxeHttpLib/DxeHttpLib.inf > b/NetworkPkg/Library/DxeHttpLib/DxeHttpLib.inf > index c613dc1718..984a24ffd3 100644 > --- a/NetworkPkg/Library/DxeHttpLib/DxeHttpLib.inf > +++ b/NetworkPkg/Library/DxeHttpLib/DxeHttpLib.inf > @@ -30,6 +30,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > BaseLib > diff --git a/NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.inf > b/NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.inf > index a789d80de6..bfd631a31d 100644 > --- a/NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.inf > +++ b/NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.inf > @@ -28,6 +28,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.inf > b/NetworkPkg/Library/DxeNetLib/DxeNetLib.inf > index 35a8247517..40e855695b 100644 > --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.inf > +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.inf > @@ -31,6 +31,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > b/NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > index 66873d7837..4dcf34429a 100644 > --- a/NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > +++ b/NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > @@ -28,6 +28,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > b/NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > index 483c2cda02..7614faa959 100644 > --- a/NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > +++ b/NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > @@ -28,6 +28,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/MnpDxe/MnpDxe.inf > b/NetworkPkg/MnpDxe/MnpDxe.inf > index d4685b3e6a..e399232415 100644 > --- a/NetworkPkg/MnpDxe/MnpDxe.inf > +++ b/NetworkPkg/MnpDxe/MnpDxe.inf > @@ -44,6 +44,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > BaseLib > diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Dxe.inf > b/NetworkPkg/Mtftp4Dxe/Mtftp4Dxe.inf > index 6e5335ca23..25cbdc185d 100644 > --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Dxe.inf > +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Dxe.inf > @@ -46,6 +46,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > b/NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > index 827b6e7706..7a1af34f94 100644 > --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > @@ -47,6 +47,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec > index 25964539ed..b260ea5b77 100644 > --- a/NetworkPkg/NetworkPkg.dec > +++ b/NetworkPkg/NetworkPkg.dec > @@ -20,6 +20,30 @@ [Defines] > [Includes] > Include >=20 > +[LibraryClasses] > + ## @libraryclass IpIo layer upon EFI IP4 Protocol. > + # This library is only intended to be used by UEFI network stack mo= dules. > + IpIoLib|Include/Library/IpIoLib.h > + > + ## @libraryclass Basic function for UEFI network stack. > + # This library is only intended to be used by UEFI network stack mo= dules. > + NetLib|Include/Library/NetLib.h > + > + ## @libraryclass The helper routines to access UDP service. > + # This library is only intended to be used by UEFI network stack mo= dules. > + UdpIoLib|Include/Library/UdpIoLib.h > + > + ## @libraryclass The helper routines to access TCP service. > + # This library is only intended to be used by UEFI network stack mo= dules. > + TcpIoLib|Include/Library/TcpIoLib.h > + > + ## @libraryclass The helper routines to access HTTP service. > + # This library is only intended to be used by UEFI network stack mo= dules. > + HttpLib|Include/Library/HttpLib.h > + > + ## @libraryclass Library for Deferred Procedure Calls. > + DpcLib|Include/Library/DpcLib.h > + > [Guids] > ## Network package token space guid. > # Include/Guid/NetworkPkgTokenSpace.h > diff --git a/NetworkPkg/SnpDxe/SnpDxe.inf > b/NetworkPkg/SnpDxe/SnpDxe.inf > index eab97d2e9e..9a37b12e53 100644 > --- a/NetworkPkg/SnpDxe/SnpDxe.inf > +++ b/NetworkPkg/SnpDxe/SnpDxe.inf > @@ -53,6 +53,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/TcpDxe/TcpDxe.inf > b/NetworkPkg/TcpDxe/TcpDxe.inf > index 7b6f9ecd67..4865acb0d7 100644 > --- a/NetworkPkg/TcpDxe/TcpDxe.inf > +++ b/NetworkPkg/TcpDxe/TcpDxe.inf > @@ -52,6 +52,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/TlsDxe/TlsDxe.inf b/NetworkPkg/TlsDxe/TlsDxe.inf > index 9d642a66c2..f640461809 100644 > --- a/NetworkPkg/TlsDxe/TlsDxe.inf > +++ b/NetworkPkg/TlsDxe/TlsDxe.inf > @@ -29,6 +29,7 @@ [Defines] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec > CryptoPkg/CryptoPkg.dec >=20 > [Sources] > diff --git a/NetworkPkg/Udp4Dxe/Udp4Dxe.inf > b/NetworkPkg/Udp4Dxe/Udp4Dxe.inf > index ba623a6637..6a71ed7019 100644 > --- a/NetworkPkg/Udp4Dxe/Udp4Dxe.inf > +++ b/NetworkPkg/Udp4Dxe/Udp4Dxe.inf > @@ -41,6 +41,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 >=20 > [LibraryClasses] > diff --git a/NetworkPkg/Udp6Dxe/Udp6Dxe.inf > b/NetworkPkg/Udp6Dxe/Udp6Dxe.inf > index c3d4031645..7830d2de26 100644 > --- a/NetworkPkg/Udp6Dxe/Udp6Dxe.inf > +++ b/NetworkPkg/Udp6Dxe/Udp6Dxe.inf > @@ -38,6 +38,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > BaseLib > diff --git a/NetworkPkg/VlanConfigDxe/VlanConfigDxe.inf > b/NetworkPkg/VlanConfigDxe/VlanConfigDxe.inf > index 72af88d695..700cd881fd 100644 > --- a/NetworkPkg/VlanConfigDxe/VlanConfigDxe.inf > +++ b/NetworkPkg/VlanConfigDxe/VlanConfigDxe.inf > @@ -36,6 +36,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > BaseLib > -- > 2.13.0.windows.1 >=20 >=20 >=20