* [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of FixedPcdGetBool in Snp.c
@ 2019-10-29 1:41 Siyuan, Fu
2019-10-29 1:43 ` Wu, Jiaxin
0 siblings, 1 reply; 2+ messages in thread
From: Siyuan, Fu @ 2019-10-29 1:41 UTC (permalink / raw)
To: devel; +Cc: Jiaxin Wu
This patch fixes a problem introduced by commit
61bb6eeb4d93c0a34c1995d87914ab41398f9550.
The PcdSnpCreateExitBootServicesEvent is not guaranteed to be FixedAtBuild,
so use PcdGetBool() to supports both fixed and patchable PCD.
Change-Id: Ic1791bb598306e9251792113797c3bad317d0dda
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
---
NetworkPkg/SnpDxe/Snp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NetworkPkg/SnpDxe/Snp.c b/NetworkPkg/SnpDxe/Snp.c
index 9fb007f7ae..1099dbfa6a 100644
--- a/NetworkPkg/SnpDxe/Snp.c
+++ b/NetworkPkg/SnpDxe/Snp.c
@@ -647,7 +647,7 @@ SimpleNetworkDriverStart (
PxeShutdown (Snp);
PxeStop (Snp);
- if (FixedPcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
+ if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
//
// Create EXIT_BOOT_SERIVES Event
//
@@ -780,7 +780,7 @@ SimpleNetworkDriverStop (
return Status;
}
- if (FixedPcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
+ if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
//
// Close EXIT_BOOT_SERIVES Event
//
--
2.19.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of FixedPcdGetBool in Snp.c
2019-10-29 1:41 [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of FixedPcdGetBool in Snp.c Siyuan, Fu
@ 2019-10-29 1:43 ` Wu, Jiaxin
0 siblings, 0 replies; 2+ messages in thread
From: Wu, Jiaxin @ 2019-10-29 1:43 UTC (permalink / raw)
To: Fu, Siyuan, devel@edk2.groups.io
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
> -----Original Message-----
> From: Fu, Siyuan <siyuan.fu@intel.com>
> Sent: Tuesday, October 29, 2019 9:41 AM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of
> FixedPcdGetBool in Snp.c
>
> This patch fixes a problem introduced by commit
> 61bb6eeb4d93c0a34c1995d87914ab41398f9550.
>
> The PcdSnpCreateExitBootServicesEvent is not guaranteed to be
> FixedAtBuild,
> so use PcdGetBool() to supports both fixed and patchable PCD.
>
> Change-Id: Ic1791bb598306e9251792113797c3bad317d0dda
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> ---
> NetworkPkg/SnpDxe/Snp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/NetworkPkg/SnpDxe/Snp.c b/NetworkPkg/SnpDxe/Snp.c
> index 9fb007f7ae..1099dbfa6a 100644
> --- a/NetworkPkg/SnpDxe/Snp.c
> +++ b/NetworkPkg/SnpDxe/Snp.c
> @@ -647,7 +647,7 @@ SimpleNetworkDriverStart (
> PxeShutdown (Snp);
> PxeStop (Snp);
>
> - if (FixedPcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
> + if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
> //
> // Create EXIT_BOOT_SERIVES Event
> //
> @@ -780,7 +780,7 @@ SimpleNetworkDriverStop (
> return Status;
> }
>
> - if (FixedPcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
> + if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
> //
> // Close EXIT_BOOT_SERIVES Event
> //
> --
> 2.19.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-29 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 1:41 [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of FixedPcdGetBool in Snp.c Siyuan, Fu
2019-10-29 1:43 ` Wu, Jiaxin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox