From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by mx.groups.io with SMTP id smtpd.web09.18024.1574147636154066851
 for <devel@edk2.groups.io>;
 Mon, 18 Nov 2019 23:13:56 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiaxin.wu@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 23:13:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; 
   d="scan'208";a="237226297"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
  by fmsmga002.fm.intel.com with ESMTP; 18 Nov 2019 23:13:55 -0800
Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 18 Nov 2019 23:13:54 -0800
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 18 Nov 2019 23:13:54 -0800
Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.63]) by
 SHSMSX104.ccr.corp.intel.com ([169.254.5.127]) with mapi id 14.03.0439.000;
 Tue, 19 Nov 2019 15:13:52 +0800
From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Fu, Siyuan" <siyuan.fu@intel.com>, "Rabeda, Maciej"
	<maciej.rabeda@intel.com>
Subject: Re: [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for PCD
Thread-Topic: [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for
 PCD
Thread-Index: AQHVmuFFJcNvCod7pkSuFmMANo3NbaeSG+2Q
Date: Tue, 19 Nov 2019 07:13:52 +0000
Message-ID: <895558F6EA4E3B41AC93A00D163B727416FA59B9@SHSMSX107.ccr.corp.intel.com>
References: <20191114114644.5504-1-shenglei.zhang@intel.com>
 <20191114114644.5504-5-shenglei.zhang@intel.com>
In-Reply-To: <20191114114644.5504-5-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmQ4ZjQ2ZmMtNTg1Yi00NzA4LWE4YmMtN2VjMzcyZTZhM2I1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibVMxVkI3NHpyeVViSTluZlVcL3hIQmtub1pXQkU1Z2MydU1TRjRGeWhETldKZ0dyRUN4NkJ3MjFvVTdqcHhUaEEifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: jiaxin.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>



> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 7:47 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej
> <maciej.rabeda@intel.com>
> Subject: [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for
> PCD
>=20
> From: Shenglei Zhang <shenglei.zhang@intel.com>
>=20
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  NetworkPkg/NetworkPkg.uni | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni
> index 19e57a4a60de..328d8cb54a6e 100644
> --- a/NetworkPkg/NetworkPkg.uni
> +++ b/NetworkPkg/NetworkPkg.uni
> @@ -61,6 +61,13 @@
>                                                                          =
                  "TRUE  - Certificate
> Authentication feature is enabled.<BR>\n"
>                                                                          =
                  "FALSE - Does not support
> Certificate Authentication.<BR>"
>=20
> +#string
> STR_gEfiNetworkPkgTokenSpaceGuid_PcdSnpCreateExitBootServicesEvent_
> PROMPT  #language en-US "Indicates whether SnpDxe creates event for
> ExitBootServices() call."
> +
> +#string
> STR_gEfiNetworkPkgTokenSpaceGuid_PcdSnpCreateExitBootServicesEvent_
> HELP  #language en-US "Indicates whether SnpDxe driver will create an
> event that will be notified<BR><BR>\n"
> +                                                                        =
                         "upon gBS-
> >ExitBootServices() call.<BR>\n"
> +                                                                        =
                         "TRUE - Event being
> triggered upon ExitBootServices call will be created<BR>\n"
> +                                                                        =
                         "FALSE - Event being
> triggered upon ExitBootServices call will NOT be created<BR>"
> +
>  #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdDhcp6UidType_PROMPT
> #language en-US "Type Value of Dhcp6 Unique Identifier (DUID)."
>=20
>  #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdDhcp6UidType_HELP
> #language en-US "IPv6 DHCP Unique Identifier (DUID) Type configuration
> (From RFCs 3315 and 6355).\n"
> --
> 2.18.0.windows.1