Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg: Fixes to static code analysis hits

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Maciej
> Rabeda
> Sent: Thursday, November 28, 2019 10:46 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] NetworkPkg: Fixes to static code
> analysis hits
> 
> Introducing fixes to memory leak issues identified by static code analysis
> tool.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> ---
>  NetworkPkg/Dhcp6Dxe/Dhcp6Io.c     | 1 +
>  NetworkPkg/Ip4Dxe/Ip4If.c         | 6 +++++-
>  NetworkPkg/TcpDxe/TcpDispatcher.c | 1 +
>  3 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
> b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
> index 4f8393cb36ce..613b42149cc1 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
> @@ -203,6 +203,7 @@ Dhcp6EnqueueRetry (
>      //
> 
>      // Unexpected message type.
> 
>      //
> 
> +    FreePool(TxCb);
> 
>      return EFI_DEVICE_ERROR;
> 
>    }
> 
> 
> 
> diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c
> index 53a333037f94..348f2e076aed 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4If.c
> +++ b/NetworkPkg/Ip4Dxe/Ip4If.c
> @@ -491,9 +491,13 @@ Ip4CreateInterface (
>    IP4_INTERFACE             *Interface;
> 
>    EFI_SIMPLE_NETWORK_MODE   SnpMode;
> 
> 
> 
> +  if (Mnp == NULL) {
> 
> +    return NULL;
> 
> +  }
> 
> +
> 
>    Interface = AllocatePool (sizeof (IP4_INTERFACE));
> 
> 
> 
> -  if ((Interface == NULL) || (Mnp == NULL)) {
> 
> +  if (Interface == NULL) {
> 
>      return NULL;
> 
>    }
> 
> 
> 
> diff --git a/NetworkPkg/TcpDxe/TcpDispatcher.c
> b/NetworkPkg/TcpDxe/TcpDispatcher.c
> index 86beaf8cc513..9ae08ccc1c56 100644
> --- a/NetworkPkg/TcpDxe/TcpDispatcher.c
> +++ b/NetworkPkg/TcpDxe/TcpDispatcher.c
> @@ -390,6 +390,7 @@ TcpAttachPcb (
>                    );
> 
>    if (EFI_ERROR (Status)) {
> 
>      IpIoRemoveIp (IpIo, Tcb->IpInfo);
> 
> +    FreePool (Tcb);
> 
>      return Status;
> 
>    }
> 
> 
> 
> --
> 2.24.0.windows.2
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#51464): https://edk2.groups.io/g/devel/message/51464
> Mute This Topic: https://groups.io/mt/64137254/1787330
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [jiaxin.wu@intel.com]
> -=-=-=-=-=-=