From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"sivaramann@amiindia.co.in" <sivaramann@amiindia.co.in>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Bi, Dandan" <dandan.bi@intel.com>,
"Rabeda, Maciej" <maciej.rabeda@intel.com>
Cc: Ramesh R. <rameshr@ami.com>
Subject: Re: reg: Remove Framework HII "class\subclass" in all VFR
Date: Fri, 27 Dec 2019 08:20:33 +0000 [thread overview]
Message-ID: <895558F6EA4E3B41AC93A00D163B727416FC8621@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <B4DE137BDB63634BAC03BD9DE765F197029AE5A3DF@VENUS1.in.megatrends.com>
[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]
According to below comments:
class/subclass is the obseleted key word in VFR file. It is designed in framework HII. After convert to UEFI HII, it is not used any longer. Now remove them from VFR Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17493 6f19259b-4bc3-4df7-8a09-765794883524
It looks like the bug in edk2 network. Loop in HII expert(Bi Dandan) to confirm that. If yes, please report Bugzilla for that.
Thanks,
Jiaxin
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sivaraman Nainar
Sent: Tuesday, December 24, 2019 5:45 PM
To: Fu, Siyuan <siyuan.fu@intel.com>; devel@edk2.groups.io; Wu, Jiaxin <jiaxin.wu@intel.com>
Cc: Ramesh R. <rameshr@ami.com>
Subject: [edk2-devel] reg: Remove Framework HII "class\subclass" in all VFR
Hello Jiaxin:
Edk2 older branch removed the "class\subclass" in all VFR in the Network Stack modules. (IP4, IP6 and ISCSI) Refer below commit.
https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b1fa2c2ed8bd8#diff-3d9f695b702160a70a74145d12121272
But when we upload the Initial IP4Dxe the changes are reverted. But IP6Config and ISCSI modules are not having those.
https://github.com/tianocore/edk2/commit/1f6729ffe98095107ce82e67a4a0209674601a90#diff-6788a5f6871902342bd0ea72eb123df4
Do we have any specific reason behind that.
-Siva
[-- Attachment #2: Type: text/html, Size: 6016 bytes --]
next prev parent reply other threads:[~2019-12-27 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 9:44 reg: Remove Framework HII "class\subclass" in all VFR Sivaraman Nainar
2019-12-27 8:20 ` Wu, Jiaxin [this message]
2019-12-27 8:47 ` Dandan Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895558F6EA4E3B41AC93A00D163B727416FC8621@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox