From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.29120.1577434838253180674 for ; Fri, 27 Dec 2019 00:20:38 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jiaxin.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2019 00:20:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,362,1571727600"; d="scan'208,217";a="269028382" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 27 Dec 2019 00:20:37 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Dec 2019 00:20:37 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Dec 2019 00:20:36 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.164]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.214]) with mapi id 14.03.0439.000; Fri, 27 Dec 2019 16:20:34 +0800 From: "Wu, Jiaxin" To: "devel@edk2.groups.io" , "sivaramann@amiindia.co.in" , "Fu, Siyuan" , "Bi, Dandan" , "Rabeda, Maciej" CC: Ramesh R. Subject: Re: reg: Remove Framework HII "class\subclass" in all VFR Thread-Topic: reg: Remove Framework HII "class\subclass" in all VFR Thread-Index: AdW6Pm+7Y6LeLsuHTOCpjI7iCCTxzACT6w1Q Date: Fri, 27 Dec 2019 08:20:33 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B727416FC8621@SHSMSX107.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTdmN2U1NDctNDU5Mi00MWRjLWI5YzQtYWJkNjZhY2Q3M2I4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidklnOG1LdXNiNXljSkdKZXVcL0lqbXk2NFJvT0N6RjZONUtDMmxCdWZWV2VQbldwZHZmOWR1ak5VU2ZSNVRBemYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiaxin.wu@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_895558F6EA4E3B41AC93A00D163B727416FC8621SHSMSX107ccrcor_" --_000_895558F6EA4E3B41AC93A00D163B727416FC8621SHSMSX107ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable According to below comments: class/subclass is the obseleted key word in VFR file. It is designed in fr= amework HII. After convert to UEFI HII, it is not used any longer. Now remo= ve them from VFR Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17493 6f19259b-= 4bc3-4df7-8a09-765794883524 It looks like the bug in edk2 network. Loop in HII expert(Bi Dandan) to co= nfirm that. If yes, please report Bugzilla for that. Thanks, Jiaxin From: devel@edk2.groups.io On Behalf Of Sivaraman N= ainar Sent: Tuesday, December 24, 2019 5:45 PM To: Fu, Siyuan ; devel@edk2.groups.io; Wu, Jiaxin Cc: Ramesh R. Subject: [edk2-devel] reg: Remove Framework HII "class\subclass" in all VF= R Hello Jiaxin: Edk2 older branch removed the "class\subclass" in all VFR in the Network S= tack modules. (IP4, IP6 and ISCSI) Refer below commit. https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b1fa2c= 2ed8bd8#diff-3d9f695b702160a70a74145d12121272 But when we upload the Initial IP4Dxe the changes are reverted. But IP6Con= fig and ISCSI modules are not having those. https://github.com/tianocore/edk2/commit/1f6729ffe98095107ce82e67a4a020967= 4601a90#diff-6788a5f6871902342bd0ea72eb123df4 Do we have any specific reason behind that. -Siva --_000_895558F6EA4E3B41AC93A00D163B727416FC8621SHSMSX107ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

According to below comments:

 

class/subclass is the obseleted key word in VFR file. It i= s designed in framework HII. After convert to UEFI HII, it is not used any = longer. Now remove them from VFR Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Dandan Bi <dandan.bi@intel.com>

Reviewed-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17493= 6f19259b-4bc3-4df7-8a09-765794883524

It looks like the bug in edk2 network. Loop in HII = expert(Bi Dandan) to confirm that. If yes, please report Bugzilla for that.=

 

Thanks,

Jiaxin

 

 

From: de= vel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sivaraman Nainar
Sent: Tuesday, December 24, 2019 5:45 PM
To: Fu, Siyuan <siyuan.fu@intel.com>; devel@edk2.groups.io; W= u, Jiaxin <jiaxin.wu@intel.com>
Cc: Ramesh R. <rameshr@ami.com>
Subject: [edk2-devel] reg: Remove Framework HII "class\subclas= s" in all VFR

 

Hello Jiaxin:

 

Edk2 older branch removed the "class\subclass&= quot; in all VFR in the Network Stack modules. (IP4, IP6 and ISCSI) Refer b= elow commit.

 

https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b= 1fa2c2ed8bd8#diff-3d9f695b702160a70a74145d12121272

 

But when we upload the Initial IP4Dxe the changes a= re reverted. But IP6Config and ISCSI modules are not having those.

 

https://github.com/tianocore/edk2/commit/1f6729ffe98095107ce82e67a4a0= 209674601a90#diff-6788a5f6871902342bd0ea72eb123df4

 

Do we have any specific reason behind that.

 

-Siva

--_000_895558F6EA4E3B41AC93A00D163B727416FC8621SHSMSX107ccrcor_--