From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.5770.1581925196366942611 for ; Sun, 16 Feb 2020 23:39:56 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiaxin.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Feb 2020 23:39:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,451,1574150400"; d="scan'208";a="238994180" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 16 Feb 2020 23:39:55 -0800 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Feb 2020 23:39:54 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Feb 2020 23:39:54 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.46]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.158]) with mapi id 14.03.0439.000; Mon, 17 Feb 2020 15:39:52 +0800 From: "Wu, Jiaxin" To: "devel@edk2.groups.io" , "Wu, Jiaxin" CC: "Fu, Siyuan" Subject: Re: [edk2-devel] [PATCH v1] MdeModulePkg/Ip4Dxe: Check the received package length (CVE-2019-14559). Thread-Topic: [edk2-devel] [PATCH v1] MdeModulePkg/Ip4Dxe: Check the received package length (CVE-2019-14559). Thread-Index: AQHV5WTmDbtx3mCfk0624OY6OSVFFage/6mg Date: Mon, 17 Feb 2020 07:39:51 +0000 Message-ID: <895558F6EA4E3B41AC93A00D163B72741701C214@SHSMSX107.ccr.corp.intel.com> References: <15F4205BB8F7C9F2.5373@groups.io> In-Reply-To: <15F4205BB8F7C9F2.5373@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzk1NmEzZDgtOWVjYS00YzI0LTk4NWQtYWIwZWQ1NzNhNDc0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFhFUWUyWEIyd2pxc3NPUWQzQ0hQVGN6NU5IUzZwMCtRcExGTFpFcmNzOGJPbktsNW8xVXZoa1hFZnBjb3l5aSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiaxin.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 U29ycnksIHBsZWFzZSBpZ25vcmUgdGhpcyBwYXRjaCwgSSB3aWxsIGNvcnJlY3QgdGhlIGNvbW1p dCBsb2cgbGF0ZXIuDQoNClRoYW5rcywNCkppYXhpbg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn ZS0tLS0tDQo+IEZyb206IGRldmVsQGVkazIuZ3JvdXBzLmlvIDxkZXZlbEBlZGsyLmdyb3Vwcy5p bz4gT24gQmVoYWxmIE9mIFd1LA0KPiBKaWF4aW4NCj4gU2VudDogTW9uZGF5LCBGZWJydWFyeSAx NywgMjAyMCAzOjM2IFBNDQo+IFRvOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbw0KPiBDYzogRnUsIFNp eXVhbiA8c2l5dWFuLmZ1QGludGVsLmNvbT47IFd1LCBKaWF4aW4gPGppYXhpbi53dUBpbnRlbC5j b20+DQo+IFN1YmplY3Q6IFtlZGsyLWRldmVsXSBbUEFUQ0ggdjFdIE1kZU1vZHVsZVBrZy9JcDRE eGU6IENoZWNrIHRoZQ0KPiByZWNlaXZlZCBwYWNrYWdlIGxlbmd0aCAoQ1ZFLTIwMTktMTQ1NTkp Lg0KPiANCj4gVGhpcyBwYXRjaCBpcyB0byBjaGVjayB0aGUgcmVjZWl2ZWQgcGFja2FnZSBsZW5n dGggdG8gbWFrZSBzdXJlIHRoZSBwYWNrYWdlDQo+IGhhcyBhIHZhbGlkIGxlbmd0aCBmaWVsZC4N Cj4gDQo+IENjOiBGdSBTaXl1YW4gPHNpeXVhbi5mdUBpbnRlbC5jb20+DQo+IENj77yaTWFjaWVq IFJhYmVkYSA8bWFjaWVqLnJhYmVkYUBsaW51eC5pbnRlbC5jb20+DQo+IENvbnRyaWJ1dGVkLXVu ZGVyOiBUaWFub0NvcmUgQ29udHJpYnV0aW9uIEFncmVlbWVudCAxLjENCj4gU2lnbmVkLW9mZi1i eTogV3UgSmlheGluIDxqaWF4aW4ud3VAaW50ZWwuY29tPg0KPiBSZXZpZXdlZC1ieTogU2l5dWFu IEZ1IDxzaXl1YW4uZnVAaW50ZWwuY29tPg0KPiAtLS0NCj4gIE5ldHdvcmtQa2cvSXA0RHhlL0lw NElucHV0LmMgfCA0Ng0KPiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0p DQo+IA0KPiBkaWZmIC0tZ2l0IGEvTmV0d29ya1BrZy9JcDREeGUvSXA0SW5wdXQuYyBiL05ldHdv cmtQa2cvSXA0RHhlL0lwNElucHV0LmMNCj4gaW5kZXggZmVjMjQyYzcxZi4uM2ZkMDhhNTIzMSAx MDA2NDQNCj4gLS0tIGEvTmV0d29ya1BrZy9JcDREeGUvSXA0SW5wdXQuYw0KPiArKysgYi9OZXR3 b3JrUGtnL0lwNER4ZS9JcDRJbnB1dC5jDQo+IEBAIC0xLDkgKzEsOSBAQA0KPiAgLyoqIEBmaWxl DQo+ICAgIElQNCBpbnB1dCBwcm9jZXNzLg0KPiANCj4gLUNvcHlyaWdodCAoYykgMjAwNSAtIDIw MTgsIEludGVsIENvcnBvcmF0aW9uLiBBbGwgcmlnaHRzIHJlc2VydmVkLjxCUj4NCj4gK0NvcHly aWdodCAoYykgMjAwNSAtIDIwMTksIEludGVsIENvcnBvcmF0aW9uLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLjxCUj4NCj4gIChDKSBDb3B5cmlnaHQgMjAxNSBIZXdsZXR0LVBhY2thcmQgRGV2ZWxvcG1l bnQgQ29tcGFueSwgTC5QLjxCUj4NCj4gDQo+ICBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogQlNE LTItQ2xhdXNlLVBhdGVudA0KPiANCj4gICoqLw0KPiBAQCAtNzA5LDE0ICs3MDksMTAgQEAgSXA0 UHJlUHJvY2Vzc1BhY2tldCAoDQo+ICAgIFVJTlQxNiAgICAgICAgICAgICAgICAgICAgQ2hlY2tz dW07DQo+IA0KPiAgICAvLw0KPiAgICAvLyBDaGVjayBpZiB0aGUgSVA0IGhlYWRlciBpcyBjb3Jy ZWN0bHkgZm9ybWF0dGVkLg0KPiAgICAvLw0KPiAtICBpZiAoKCpQYWNrZXQpLT5Ub3RhbFNpemUg PCBJUDRfTUlOX0hFQURMRU4pIHsNCj4gLSAgICByZXR1cm4gRUZJX0lOVkFMSURfUEFSQU1FVEVS Ow0KPiAtICB9DQo+IC0NCj4gICAgSGVhZExlbiAgPSAoSGVhZC0+SGVhZExlbiA8PCAyKTsNCj4g ICAgVG90YWxMZW4gPSBOVE9IUyAoSGVhZC0+VG90YWxMZW4pOw0KPiANCj4gICAgLy8NCj4gICAg Ly8gTW5wIG1heSBkZWxpdmVyIGZyYW1lIHRyYWlsZXIgc2VxdWVuY2UgdXAsIHRyaW0gaXQgb2Zm Lg0KPiBAQCAtODA2LDEwICs4MDIsMzQgQEAgSXA0UHJlUHJvY2Vzc1BhY2tldCAoDQo+ICAgIH0N Cj4gDQo+ICAgIHJldHVybiBFRklfU1VDQ0VTUzsNCj4gIH0NCj4gDQo+ICsvKioNCj4gKyAgVGhp cyBmdW5jdGlvbiBjaGVja3MgdGhlIElQdjQgcGFja2V0IGxlbmd0aC4NCj4gKw0KPiArICBAcGFy YW1baW5dICAgICAgIFBhY2tldCAgICAgICAgICBQb2ludGVyIHRvIHRoZSBJUHY0IFBhY2tldCB0 byBiZSBjaGVja2VkLg0KPiArDQo+ICsgIEByZXR2YWwgVFJVRSAgICAgICAgICAgICAgICAgICBU aGUgaW5wdXQgSVB2NCBwYWNrZXQgbGVuZ3RoIGlzIHZhbGlkLg0KPiArICBAcmV0dmFsIEZBTFNF ICAgICAgICAgICAgICAgICAgVGhlIGlucHV0IElQdjQgcGFja2V0IGxlbmd0aCBpcyBpbnZhbGlk Lg0KPiArDQo+ICsqKi8NCj4gK0JPT0xFQU4NCj4gK0lwNElzVmFsaWRQYWNrZXRMZW5ndGggKA0K PiArICBJTiBORVRfQlVGICAgICAgICAqUGFja2V0DQo+ICsgICkNCj4gK3sNCj4gKyAgLy8NCj4g KyAgLy8gQ2hlY2sgdGhlIElQNCBwYWNrZXQgbGVuZ3RoLg0KPiArICAvLw0KPiArICBpZiAoUGFj a2V0LT5Ub3RhbFNpemUgPCBJUDRfTUlOX0hFQURMRU4pIHsNCj4gKyAgICByZXR1cm4gRkFMU0U7 DQo+ICsgIH0NCj4gKw0KPiArICByZXR1cm4gVFJVRTsNCj4gK30NCj4gKw0KPiAgLyoqDQo+ICAg IFRoZSBJUDQgaW5wdXQgcm91dGluZS4gSXQgaXMgY2FsbGVkIGJ5IHRoZSBJUDRfSU5URVJGQUNF IHdoZW4gYQ0KPiAgICBJUDQgZnJhZ21lbnQgaXMgcmVjZWl2ZWQgZnJvbSBNTlAuDQo+IA0KPiAg ICBAcGFyYW1baW5dICBJcDRJbnN0YW5jZSAgICAgICAgVGhlIElQNCBjaGlsZCB0aGF0IHJlcXVl c3QgdGhlIHJlY2VpdmUsIG1vc3QNCj4gbGlrZQ0KPiBAQCAtODQyLDEwICs4NjIsMTQgQEAgSXA0 QWNjcGV0RnJhbWUgKA0KPiANCj4gICAgaWYgKEVGSV9FUlJPUiAoSW9TdGF0dXMpIHx8IChJcFNi LT5TdGF0ZSA9PSBJUDRfU0VSVklDRV9ERVNUUk9ZKSkgew0KPiAgICAgIGdvdG8gRFJPUDsNCj4g ICAgfQ0KPiANCj4gKyAgaWYgKCFJcDRJc1ZhbGlkUGFja2V0TGVuZ3RoIChQYWNrZXQpKSB7DQo+ ICsgICAgZ290byBSRVNUQVJUOw0KPiArICB9DQo+ICsNCj4gICAgSGVhZCAgICAgID0gKElQNF9I RUFEICopIE5ldGJ1ZkdldEJ5dGUgKFBhY2tldCwgMCwgTlVMTCk7DQo+ICAgIEFTU0VSVCAoSGVh ZCAhPSBOVUxMKTsNCj4gICAgT3B0aW9uTGVuID0gKEhlYWQtPkhlYWRMZW4gPDwgMikgLSBJUDRf TUlOX0hFQURMRU47DQo+ICAgIGlmIChPcHRpb25MZW4gPiAwKSB7DQo+ICAgICAgT3B0aW9uID0g KFVJTlQ4ICopIChIZWFkICsgMSk7DQo+IEBAIC04ODgsMTQgKzkxMiwxOCBAQCBJcDRBY2NwZXRG cmFtZSAoDQo+ICAgIC8vDQo+ICAgIC8vIElmIHRoZSBwYWNrZXQgaXMgcHJvdGVjdGVkIGJ5IHR1 bm5lbCBtb2RlLCBwYXJzZSB0aGUgaW5uZXIgSXAgUGFja2V0Lg0KPiAgICAvLw0KPiAgICBaZXJv TWVtICgmWmVyb0hlYWQsIHNpemVvZiAoSVA0X0hFQUQpKTsNCj4gICAgaWYgKDAgPT0gQ29tcGFy ZU1lbSAoSGVhZCwgJlplcm9IZWFkLCBzaXplb2YgKElQNF9IRUFEKSkpIHsNCj4gLSAgLy8gUGFj a2V0IG1heSBoYXZlIGJlZW4gY2hhbmdlZC4gSGVhZCwgSGVhZExlbiwgVG90YWxMZW4sIGFuZA0K PiAtICAvLyBpbmZvIG11c3QgYmUgcmVsb2FkZWQgYmVmb3JlIHVzZS4gVGhlIG93bmVyc2hpcCBv ZiB0aGUgcGFja2V0DQo+IC0gIC8vIGlzIHRyYW5zZmVycmVkIHRvIHRoZSBwYWNrZXQgcHJvY2Vz cyBsb2dpYy4NCj4gLSAgLy8NCj4gKyAgICAvLyBQYWNrZXQgbWF5IGhhdmUgYmVlbiBjaGFuZ2Vk LiBIZWFkLCBIZWFkTGVuLCBUb3RhbExlbiwgYW5kDQo+ICsgICAgLy8gaW5mbyBtdXN0IGJlIHJl bG9hZGVkIGJlZm9yZSB1c2UuIFRoZSBvd25lcnNoaXAgb2YgdGhlIHBhY2tldA0KPiArICAgIC8v IGlzIHRyYW5zZmVycmVkIHRvIHRoZSBwYWNrZXQgcHJvY2VzcyBsb2dpYy4NCj4gKyAgICAvLw0K PiArICAgIGlmICghSXA0SXNWYWxpZFBhY2tldExlbmd0aCAoUGFja2V0KSkgew0KPiArICAgICAg Z290byBSRVNUQVJUOw0KPiArICAgIH0NCj4gKw0KPiAgICAgIEhlYWQgPSAoSVA0X0hFQUQgKikg TmV0YnVmR2V0Qnl0ZSAoUGFja2V0LCAwLCBOVUxMKTsNCj4gICAgICBBU1NFUlQgKEhlYWQgIT0g TlVMTCk7DQo+ICAgICAgU3RhdHVzID0gSXA0UHJlUHJvY2Vzc1BhY2tldCAoDQo+ICAgICAgICAg ICAgICAgICBJcFNiLA0KPiAgICAgICAgICAgICAgICAgJlBhY2tldCwNCj4gLS0NCj4gMi4xNi4y LndpbmRvd3MuMQ0KPiANCj4gDQo+IA0KDQo=