public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ashish Singhal <ashishsingha@nvidia.com>
To: <edk2-devel@lists.01.org>
Cc: <Sami.Mujawar@arm.com>, <Alexei.Fedorov@arm.com>,
	Ashish Singhal <ashishsingha@nvidia.com>
Subject: [PATCH 2/2] DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.
Date: Thu, 21 Feb 2019 11:38:57 -0700	[thread overview]
Message-ID: <8960abcec179f116cc195523ae826eecc2968d4a.1550773480.git.ashishsingha@nvidia.com> (raw)
In-Reply-To: <cover.1550773480.git.ashishsingha@nvidia.com>

Add support for 16550 UART to ACPI SPCR table as it is a
supported UART type by HLOS.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
---
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
index 23d3a50..a4654ac 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
@@ -189,6 +189,8 @@ BuildSpcrTable (
       (SerialPortInfo->PortSubtype !=
       EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART) &&
       (SerialPortInfo->PortSubtype !=
+      EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550) &&
+      (SerialPortInfo->PortSubtype !=
       EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC)) {
     Status = EFI_INVALID_PARAMETER;
     DEBUG ((
-- 
2.7.4



  parent reply	other threads:[~2019-02-21 18:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 18:38 [PATCH 0/2] DynamicTablesPkg Updates Ashish Singhal
2019-02-21 18:38 ` [PATCH 1/2] DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX Ashish Singhal
2019-02-21 18:38 ` Ashish Singhal [this message]
2019-02-25 13:38 ` [PATCH 0/2] DynamicTablesPkg Updates Sami Mujawar
2019-02-25 13:46   ` Alexei Fedorov
2019-02-25 19:30 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8960abcec179f116cc195523ae826eecc2968d4a.1550773480.git.ashishsingha@nvidia.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox