From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.9702.1619455264537943594 for ; Mon, 26 Apr 2021 09:41:05 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B9E91FB; Mon, 26 Apr 2021 09:40:54 -0700 (PDT) Received: from [192.168.1.169] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 588043F73B; Mon, 26 Apr 2021 09:40:53 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec To: devel@edk2.groups.io, brbarkel@microsoft.com References: <20210421122048.11729-4-Pierre.Gondois@arm.com> <17614.1619032416748367718@groups.io> From: "PierreGondois" Message-ID: <898503a9-99dd-e813-5e4d-322143328142@arm.com> Date: Mon, 26 Apr 2021 17:40:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <17614.1619032416748367718@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Hi Bret, Ok I will do that in a V2. Do these patches look ok to you ? [PATCH v1 08/12] .pytool: Enable CI for ArmPkg [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg Regards, Pierre On 4/21/21 8:13 PM, brbarkel via groups.io wrote: > > 1) To expedite the required reviews, you may want to add CC to the > package maintainers for ArmPkg to this commit message and email. I > know a lot of people filter based on direct mention vs mailing list. > > 2) Generally, other packages have a brief description of the lib in > the DEC, as well. Example: > https://github.com/tianocore/edk2/blob/d3b0d007a135284981fa750612a47234b83976f9/MdeModulePkg/MdeModulePkg.dec#L55 > > However, I see that this has not historically been maintained in this > package, so I'm not going to make a big deal of it. > > Reviewed-by: Bret Barkelew > >