From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ml01.01.org (Postfix) with ESMTP id 476DB1A1DF1 for ; Thu, 28 Jul 2016 19:31:39 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 28 Jul 2016 19:31:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,437,1464678000"; d="scan'208";a="147295318" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 28 Jul 2016 19:31:39 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 28 Jul 2016 19:31:38 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 28 Jul 2016 19:31:38 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.8]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.150]) with mapi id 14.03.0248.002; Fri, 29 Jul 2016 10:31:37 +0800 From: "Wei, David" To: "Lu, ShifeiX A" , "edk2-devel@lists.01.org" CC: "Wei, David" Thread-Topic: [Patch] Vlv2TbltDevicePkg:Signal EndOfDxe Event. Thread-Index: AQHR6UDDvxyFL8o/b0SGIQxS3JVq2KAur+KA Date: Fri, 29 Jul 2016 02:31:36 +0000 Message-ID: <89954A0B46707A448411A627AD4EEE3437D7D51C@SHSMSX101.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTZmMmU3MDItYzU5Yi00ODQ0LWFmNTktZDNkYjJkMjAxZGM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVydktiMGlpemFxTXc4Y2FDcGNpMUpVRUdqTlFBNWlzZFMwY3M5UlJGd3M9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] Vlv2TbltDevicePkg:Signal EndOfDxe Event. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2016 02:31:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: David Wei Thanks, David Wei =20 Intel SSG BIOS Team -----Original Message----- From: Lu, ShifeiX A=20 Sent: Friday, July 29, 2016 10:27 AM To: edk2-devel@lists.01.org Cc: Wei; Wei, David Subject: [Patch] Vlv2TbltDevicePkg:Signal EndOfDxe Event. According to PI spec,EndOfDxe Event should be signaled before DxeSmmReadyToLock protocol installation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- .../Library/PlatformBdsLib/BdsPlatform.c | 37 ++++++++++++++++++= +++- .../Library/PlatformBdsLib/PlatformBdsLib.inf | 3 +- 2 files changed, 38 insertions(+), 2 deletions(-) diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c b/Vlv2T= bltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c index 195d734..5df3396 100644 --- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c +++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c @@ -1,8 +1,8 @@ /** @file =20 - Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.
= =20 This program and the accompanying materials are licensed and made availa= ble under the terms and conditions of the BSD License that accompanies this distri= bution. =20 The full text of the license may be found at = =20 http://opensource.org/licenses/bsd-license.php. = =20 @@ -203,10 +203,29 @@ ShellImageCallback ( { BdsSetConsoleMode (TRUE); DEBUG ((EFI_D_INFO, "BdsEntry ShellImageCallback \n")); } =20 +/** + An empty function to pass error checking of CreateEventEx (). + + @param Event Event whose notification function is being invoked. + @param Context Pointer to the notification function's context, + which is implementation-dependent. + +**/ +STATIC +VOID +EFIAPI +EmptyCallbackFunction ( + IN EFI_EVENT Event, + IN VOID *Context + ) +{ + return; +} + // // BDS Platform Functions // /** Platform Bds init. Incude the platform firmware vendor, revision @@ -223,12 +242,28 @@ PlatformBdsInit ( VOID ) { EFI_STATUS Status; EFI_EVENT ShellImageEvent; + EFI_EVENT EndOfDxeEvent; EFI_GUID ShellEnvProtocol =3D SHELL_ENVIRONMENT_INTERFACE_PROTOCOL; =20 + // + // Signal EndOfDxe PI Event + // + Status =3D gBS->CreateEventEx ( + EVT_NOTIFY_SIGNAL, + TPL_CALLBACK, + EmptyCallbackFunction, + NULL, + &gEfiEndOfDxeEventGroupGuid, + &EndOfDxeEvent + ); + if (!EFI_ERROR (Status)) { + gBS->SignalEvent (EndOfDxeEvent); + } + #ifdef __GNUC__ SerialPortWrite((UINT8 *)">>>>BdsEntry[GCC]\r\n", 19); #else SerialPortWrite((UINT8 *)">>>>BdsEntry\r\n", 14); #endif diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf b/= Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf index 45578e8..c64bab9 100644 --- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf +++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf @@ -1,9 +1,9 @@ #/** @file # Component name for module PlatformBootManagerLib # -# Copyright (c) 2008 - 2015, Intel Corporation. All rights reserved.
+# Copyright (c) 2008 - 2016, Intel Corporation. All rights reserved.
# = =20 # This program and the accompanying materials are licensed and made availa= ble under # the terms and conditions of the BSD License that accompanies this distri= bution. =20 # The full text of the license may be found at = =20 # http://opensource.org/licenses/bsd-license.php. = =20 @@ -95,10 +95,11 @@ gEfiMemoryTypeInformationGuid gEfiCapsuleVendorGuid gEfiGlobalVariableGuid gEfiNormalSetupGuid gEfiPartTypeSystemPartGuid + gEfiEndOfDxeEventGroupGuid =20 [Pcd] gPlatformModuleTokenSpaceGuid.PcdFlashFvRecovery2Base gPlatformModuleTokenSpaceGuid.PcdFlashFvMainBase gPlatformModuleTokenSpaceGuid.PcdFlashFvRecoveryBase --=20 2.6.2.windows.1