Re: [PATCH] Update ReadMe.MD file.

["Wei, David" <david.wei@intel.com>]

Hi Mang,

Below two sentences are not much clear. Could you rewrite them?

+   BraswellPlatformPkg hash is f71cf3bf29aa216bc72f703815a7f96fb2ca0592(2016-08-05 release):
+   https://firmware.intel.com/sites/default/files/BraswellPlatformPkg_2016-08-05.zip
+   BraswellPlatformPkg hash is 471674c0aa4350c48e5e9e8f2d8962883f582275(2016-06-15 release):
+   https://firmware.intel.com/sites/default/files/BraswellPlatformPkg_2016-06-15.zip

Reviewed-by: David Wei <david.wei@intel.com>


Thanks,
David  Wei                                 
-----Original Message-----
From: Guo, Mang 
Sent: Tuesday, August 09, 2016 2:04 PM
To: edk2-devel@lists.01.org
Cc: Wei, David <david.wei@intel.com>
Subject: [PATCH] Update ReadMe.MD file.

Update ReadMe.MD file because code structure of BraswellPlatformPkg was changed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Mang <mang.guo@intel.com>
---
 ReadMe.MD | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/ReadMe.MD b/ReadMe.MD
index c2d5772..0ed15ab 100644
--- a/ReadMe.MD
+++ b/ReadMe.MD
@@ -43,13 +43,23 @@ This code combines elements from github, intel.com/fsp and firmware.intel.com
    (BSW_MR1) from http://intel.com/fsp
    
 5) Run the Intel� FSP installer and copy the following files into the Workspace:
-   a. Copy FspUpdVpd.h into the "C:\MyWorkspace\edk2-platforms\ChvFspBinPkg\Include" directory.
-   b. Create the "FspBinary" sub-directory under the "C:\MyWorkspace\edk2-platforms\ChvFspBinPkg"
+   a. Default install directory: "C:\Program Files (x86)\Braswell FSP Kit MR1\FSP" 
+   b. Copy FspUpdVpd.h into the "C:\MyWorkspace\edk2-platforms\ChvFspBinPkg\Include" directory.
+   c. Create the "FspBinary" sub-directory under the "C:\MyWorkspace\edk2-platforms\ChvFspBinPkg"
       directory, if it does not exist ("C:\MyWorkspace\edk2-platforms\ChvFspBinPkg\FspBinary").
-   c. Copy BSWFSP.fd into the "C:\MyWorkspace\edk2-platforms\ChvFspBinPkg\FspBinary" directory.
+   d. Copy BSWFSP.fd into the "C:\MyWorkspace\edk2-platforms\ChvFspBinPkg\FspBinary" directory.
    
 6) Download the 'BraswellPlatformPkg' package from firmware.intel.com:
    https://firmware.intel.com/projects/braswell-uefi
+   NOTE: The directory structure of BraswellPlatformPkg changed between the 2016-06-15
+   and 2016-08-05 releases. Check your BraswellPlatformPkg git hash to determine which 
+   version to download.
+   BraswellPlatformPkg hash is f71cf3bf29aa216bc72f703815a7f96fb2ca0592(2016-08-05 release):
+   https://firmware.intel.com/sites/default/files/BraswellPlatformPkg_2016-08-05.zip
+   BraswellPlatformPkg hash is 471674c0aa4350c48e5e9e8f2d8962883f582275(2016-06-15 release):
+   https://firmware.intel.com/sites/default/files/BraswellPlatformPkg_2016-06-15.zip
+
+   
 
 7) Unzip the 'BraswellPlatformPkg' package and move the contents into the Workspace:
    a. Copy the "BraswellPlatformPkg" sub-directory over the existing directory
@@ -95,7 +105,7 @@ OS Configuration:
       (/vs08 = Visual Studio 2008; /vs10 = Visual Studio 2010; /vs13 = Visual Studio 2013) 
                
    3) After the build successfully completes, the 8MB firmware binary image
-      will be located in "C:\MyWorkspace\edk2-platforms\BraswellPlatformPkg\Stitch\"      
+      will be located in "C:\MyWorkspace\edk2-platforms\Build\"  
 
 3b. Build Steps (64-bit)
    1) To build a 64-bit release version
@@ -111,13 +121,13 @@ OS Configuration:
       (/vs08 = Visual Studio 2008; /vs10 = Visual Studio 2010; /vs13 = Visual Studio 2013) 
                
    3) After the build successfully completes, the 8MB firmware binary image
-      will be located in "C:\MyWorkspace\edk2-platforms\BraswellPlatformPkg\Stitch\"      
+      will be located in "C:\MyWorkspace\edk2-platforms\Build\"      
       
 ================================================================================
                            VALIDATED OS
 ================================================================================ 
 1. Yocto Revision 1.8 (x64)
-2. Microsoft Windows 10 Enterprise, Build 10586 (x64 [64-bit] and x86 [32-bit])
+2. Microsoft Windows 10 Enterprise, Build 10240 (x64 [64-bit] and x86 [32-bit])
 3. Ubuntu 15.10 Desktop (x64)
 
 ================================================================================
@@ -133,6 +143,12 @@ https://github.com/mangguo321/Braswell/blob/master/Documents/Open_Braswell_Platf
 https://www.yoctoproject.org/downloads/bsps/fido18/cherry-hill-bsp-braswell
 
 ================================================================================
+                                  KNOWN ISSUES
+================================================================================
+
+1. Linux build environments are not currently supported.
+
+================================================================================
                                   MAINTAINERS
 ================================================================================
 david.wei@intel.com
-- 
2.8.1.windows.1