public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wei, David" <david.wei@intel.com>
To: Gary Lin <glin@suse.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wei, David" <david.wei@intel.com>
Subject: Re: [PATCH 33/33] Vlv2TbltDevicePkg: Fix typos in comments
Date: Mon, 24 Oct 2016 01:33:50 +0000	[thread overview]
Message-ID: <89954A0B46707A448411A627AD4EEE346638F8D8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20161019070138.16424-34-glin@suse.com>

Reviewed-by: David Wei <david.wei@intel.com>

Thanks,
David  Wei                                 

-----Original Message-----
From: Gary Lin [mailto:glin@suse.com] 
Sent: Wednesday, October 19, 2016 3:02 PM
To: edk2-devel@lists.01.org
Cc: Wei, David <david.wei@intel.com>
Subject: [PATCH 33/33] Vlv2TbltDevicePkg: Fix typos in comments

- TURE -> TRUE
- stardard -> standard
- aligments -> alignments
- a a -> a
- stoping -> stopping
- defalut -> default
- excute -> execute
- Incude -> Include
- futhure -> future
- Predfined -> Predefined
- minimue -> minimum
- predeined -> predefined
- dirver -> driver
- paramter -> parameter
- funciton -> function
- immediatly -> immediately

Cc: David Wei <david.wei@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
---
 Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c                                  |  2 +-
 Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecTempRamSupport.c |  4 ++--
 Vlv2TbltDevicePkg/Include/Library/CpuIA32.h                                       |  2 +-
 Vlv2TbltDevicePkg/Include/Protocol/GlobalNvsArea.h                                |  2 +-
 Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c                            | 16 ++++++++--------
 Vlv2TbltDevicePkg/PlatformDxe/PciBus.h                                            | 14 +++++++-------
 Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c                           |  4 ++--
 Vlv2TbltDevicePkg/PlatformInitPei/PlatformInfoInit.c                              |  2 +-
 Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c                             |  4 ++--
 9 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c b/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c
index 55f758c..af7b968 100644
--- a/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c
+++ b/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c
@@ -251,7 +251,7 @@ BootScriptPciCfg2ReadWrite (
 }
 
 /**
-  Internal function to add smbus excute opcode to the table.
+  Internal function to add smbus execute opcode to the table.
 
   @param  Marker                The variable argument list to get the opcode
                                 and associated attributes.
diff --git a/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecTempRamSupport.c b/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecTempRamSupport.c
index e505d71..72488f8 100644
--- a/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecTempRamSupport.c
+++ b/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecTempRamSupport.c
@@ -140,8 +140,8 @@ SecTemporaryRamSupport (
 
   //
   // SecSwitchStack function must be invoked after the memory migration
-  // immediatly, also we need fixup the stack change caused by new call into
-  // permenent memory.
+  // immediately, also we need fixup the stack change caused by new call into
+  // permanent memory.
   //
   SecSwitchStack (
     (UINT32) (UINTN) OldStack,
diff --git a/Vlv2TbltDevicePkg/Include/Library/CpuIA32.h b/Vlv2TbltDevicePkg/Include/Library/CpuIA32.h
index b8c53c9..7615781 100644
--- a/Vlv2TbltDevicePkg/Include/Library/CpuIA32.h
+++ b/Vlv2TbltDevicePkg/Include/Library/CpuIA32.h
@@ -180,7 +180,7 @@ EfiInvd (
   );
 
 /**
-  Get the Cpu info by excute the CPUID instruction
+  Get the Cpu info by execute the CPUID instruction
 
   @param[in] RegisterInEax The input value to put into register EAX
   @param[in] Regs          The Output value
diff --git a/Vlv2TbltDevicePkg/Include/Protocol/GlobalNvsArea.h b/Vlv2TbltDevicePkg/Include/Protocol/GlobalNvsArea.h
index 8f9948c..e4cbd4a 100644
--- a/Vlv2TbltDevicePkg/Include/Protocol/GlobalNvsArea.h
+++ b/Vlv2TbltDevicePkg/Include/Protocol/GlobalNvsArea.h
@@ -216,7 +216,7 @@ typedef struct {
   UINT8       TpmEnable;              // 121 TPM Enable
 
   UINT8       MorData;                // 122 Memory Overwrite Request Data
-  UINT8       TcgParamter;            // 123 Used for save the Mor and/or physical presence paramter
+  UINT8       TcgParamter;            // 123 Used for save the Mor and/or physical presence parameter
   UINT32      PPResponse;             // 124 Physical Presence request operation response
   UINT8       PPRequest;              // 128 Physical Presence request operation
   UINT8       LastPPRequest;          // 129 Last Physical Presence request operation
diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
index e1f3524..135ed21 100644
--- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
+++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
@@ -214,7 +214,7 @@ ShellImageCallback (
 // BDS Platform Functions
 //
 /**
-  Platform Bds init. Incude the platform firmware vendor, revision
+  Platform Bds init. Include the platform firmware vendor, revision
   and so crc check.
 
   @param VOID
@@ -310,7 +310,7 @@ GetGopDevicePath (
   }
 
   //
-  // Try to connect this handle, so that GOP dirver could start on this
+  // Try to connect this handle, so that GOP driver could start on this
   // device and create child handles with GraphicsOutput Protocol installed
   // on them, then we get device paths of these child handles and select
   // them as possible console device.
@@ -427,7 +427,7 @@ GetGopDevicePath (
         // In current implementation, we only enable one of the child handles
         // as console device, i.e. sotre one of the child handle's device
         // path to variable "ConOut"
-        // In futhure, we could select all child handles to be console device
+        // In future, we could select all child handles to be console device
         //
         *GopDevicePath = TempDevicePath;
       }
@@ -780,7 +780,7 @@ UpdateConsoleResolution(
   Connect the predefined platform default console device. Always try to find
   and enable the vga device if have.
 
-  @param PlatformConsole    Predfined platform default console device array.
+  @param PlatformConsole    Predefined platform default console device array.
 
   @retval EFI_SUCCESS       Success connect at least one ConIn and ConOut
                             device, there must have one ConOut device is
@@ -819,7 +819,7 @@ PlatformBdsConnectConsole (
   if (VarConout == NULL || VarConin == NULL) {
     //
     // Have chance to connect the platform default console,
-    // the platform default console is the minimue device group
+    // the platform default console is the minimum device group
     // the platform should support
     //
     while (PlatformConsole[Index].DevicePath != NULL) {
@@ -866,7 +866,7 @@ PlatformBdsConnectConsole (
 }
 
 /**
-  Connect with predeined platform connect sequence,
+  Connect with predefined platform connect sequence,
   the OEM/IBV can customize with their own connect sequence.
 
   @param None.
@@ -1568,7 +1568,7 @@ PlatformBdsLibEnumerateAllBootOption (
 
 /**
 
-  The function will excute with as the platform policy, current policy
+  The function will execute with as the platform policy, current policy
   is driven by boot mode. IBV/OEM can customize this code for their specific
   policy action.
 
@@ -2839,7 +2839,7 @@ PlatformBdsConnectSimpleConsole (
   if (VarConout == NULL || VarConin == NULL) {
     //
     // Have chance to connect the platform default console,
-    // the platform default console is the minimue device group
+    // the platform default console is the minimum device group
     // the platform should support
     //
     while (PlatformConsole[Index].DevicePath != NULL) {
diff --git a/Vlv2TbltDevicePkg/PlatformDxe/PciBus.h b/Vlv2TbltDevicePkg/PlatformDxe/PciBus.h
index 89e31d2..412e9f1 100644
--- a/Vlv2TbltDevicePkg/PlatformDxe/PciBus.h
+++ b/Vlv2TbltDevicePkg/PlatformDxe/PciBus.h
@@ -187,7 +187,7 @@ struct _PCI_IO_DEVICE {
   LIST_ENTRY                                ChildList;
 
   //
-  // TURE if the PCI bus driver creates the handle for this PCI device
+  // TRUE if the PCI bus driver creates the handle for this PCI device
   //
   BOOLEAN                                   Registered;
 
@@ -266,7 +266,7 @@ struct _PCI_IO_DEVICE {
 
   //
   // Per PCI to PCI Bridge spec, I/O window is 4K aligned,
-  // but some chipsets support non-stardard I/O window aligments less than 4K.
+  // but some chipsets support non-standard I/O window alignments less than 4K.
   // This field is used to support this case.
   //
   UINT16                                    BridgeIoAlignment;
@@ -308,8 +308,8 @@ extern BOOLEAN                                      mReserveVgaAliases;
 
   @param  _p      Specified device.
 
-  @retval TRUE    Device is a a GFX device.
-  @retval FALSE   Device is not a a GFX device.
+  @retval TRUE    Device is a GFX device.
+  @retval FALSE   Device is not a GFX device.
 
 **/
 #define IS_PCI_GFX(_p)     IS_CLASS2 (_p, PCI_CLASS_DISPLAY, PCI_CLASS_DISPLAY_OTHER)
@@ -320,7 +320,7 @@ extern BOOLEAN                                      mReserveVgaAliases;
 
   @param  This                Protocol instance pointer.
   @param  Controller          Handle of device to test.
-  @param  RemainingDevicePath Optional parameter use to pick a specific child.
+  @param  RemainingDevicePath Optional parameter use to pick a specific child
                               device to start.
 
   @retval EFI_SUCCESS         This driver supports this device.
@@ -342,7 +342,7 @@ PciBusDriverBindingSupported (
 
   @param  This                 Protocol instance pointer.
   @param  Controller           Handle of device to bind driver to.
-  @param  RemainingDevicePath  Optional parameter use to pick a specific child.
+  @param  RemainingDevicePath  Optional parameter use to pick a specific child
                                device to start.
 
   @retval EFI_SUCCESS          This driver is added to ControllerHandle.
@@ -359,7 +359,7 @@ PciBusDriverBindingStart (
   );
 
 /**
-  Stop this driver on ControllerHandle. Support stoping any child handles
+  Stop this driver on ControllerHandle. Support stopping any child handles
   created by this driver.
 
   @param  This              Protocol instance pointer.
diff --git a/Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c b/Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c
index 3ad6b57..035f7b5 100644
--- a/Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c
+++ b/Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c
@@ -33,7 +33,7 @@ PLATFORM_GOP_POLICY_PROTOCOL  mPlatformGOPPolicy;
 //
 
 /**
-  The function will excute with as the platform policy, and gives
+  The function will execute with as the platform policy, and gives
   the Platform Lid Status. IBV/OEM can customize this code for their specific
   policy action.
 
@@ -54,7 +54,7 @@ GetPlatformLidStatus (
 }
 
 /**
-  The function will excute and gives the Video Bios Table Size and Address.
+  The function will execute and gives the Video Bios Table Size and Address.
 
   @param VbtAddress  Gives the Physical Address of Video BIOS Table
 
diff --git a/Vlv2TbltDevicePkg/PlatformInitPei/PlatformInfoInit.c b/Vlv2TbltDevicePkg/PlatformInitPei/PlatformInfoInit.c
index 48d69a3..f6bb826 100644
--- a/Vlv2TbltDevicePkg/PlatformInitPei/PlatformInfoInit.c
+++ b/Vlv2TbltDevicePkg/PlatformInitPei/PlatformInfoInit.c
@@ -79,7 +79,7 @@ CheckOsSelection (
       SystemConfiguration->ReservedO   = OsSelectionHob->OsSelection;
 
       //
-      // Load LPSS and SCC defalut configurations
+      // Load LPSS and SCC default configurations
       //
       OsSelectionHob->LpssData.LpsseMMCEnabled            = FALSE;
       OsSelectionHob->LpssData.LpssSdioEnabled            = TRUE;
diff --git a/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c b/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
index de7830f..47ede35 100644
--- a/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
+++ b/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
@@ -126,7 +126,7 @@ LoadLpssDefaultValues (
   )
 {
   //
-  // Load LPSS and SCC defalut configurations for Android
+  // Load LPSS and SCC default configurations for Android
   //
   Private->FakeNvData.LpsseMMCEnabled            = FALSE;
   Private->FakeNvData.LpssSdioEnabled            = TRUE;
@@ -780,7 +780,7 @@ SystemConfigCallback (
 
 
 /**
-  The driver Entry Point. The funciton will export a disk device class formset and
+  The driver Entry Point. The function will export a disk device class formset and
   its callback function to hii database.
 
   @param  ImageHandle    The firmware allocated handle for the EFI image.
-- 
2.10.1



  reply	other threads:[~2016-10-24  1:33 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19  7:01 [PATCH 00/33] Fix typos in comments and variables Gary Lin
2016-10-19  7:01 ` [PATCH 01/33] ArmPkg: Fix typos in comments Gary Lin
2016-10-19 15:09   ` Ard Biesheuvel
2016-10-19 15:15     ` Laszlo Ersek
2016-10-19 15:33       ` Leif Lindholm
2016-10-19  7:01 ` [PATCH 02/33] BaseTools: Fix typos in comments and variables Gary Lin
2016-10-19  7:30   ` Gao, Liming
2016-10-19  7:36   ` Zhu, Yonghong
2016-10-19  7:01 ` [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments Gary Lin
2016-10-26 18:50   ` Ma, Maurice
2016-10-19  7:01 ` [PATCH 04/33] CorebootModulePkg: " Gary Lin
2016-10-26 18:41   ` Ma, Maurice
2016-10-19  7:01 ` [PATCH 05/33] CryptoPkg: " Gary Lin
2016-10-26  3:00   ` Long, Qin
2016-10-19  7:01 ` [PATCH 06/33] DuetPkg: " Gary Lin
2016-10-19  7:46   ` Ni, Ruiyu
2016-10-19  7:01 ` [PATCH 07/33] EdkCompatibilityPkg: " Gary Lin
2016-10-19  8:19   ` Gao, Liming
2016-10-19  7:01 ` [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables Gary Lin
2016-10-19 20:37   ` Jordan Justen
2016-10-20  8:16     ` Laszlo Ersek
2016-10-19  7:01 ` [PATCH 09/33] EmbeddedPkg: Fix typos in comments Gary Lin
2016-10-19 15:09   ` Ard Biesheuvel
2016-10-19  7:01 ` [PATCH 10/33] IntelFrameworkModulePkg: " Gary Lin
2016-10-20  1:08   ` Fan, Jeff
2016-10-19  7:01 ` [PATCH 11/33] IntelFrameworkPkg: " Gary Lin
2016-10-20  1:08   ` Fan, Jeff
2016-10-19  7:01 ` [PATCH 12/33] IntelFspPkg: " Gary Lin
2016-10-19  7:06   ` Yao, Jiewen
2016-10-19  7:01 ` [PATCH 13/33] IntelFspWrapperPkg: " Gary Lin
2016-10-19  7:08   ` Yao, Jiewen
2016-10-19  7:01 ` [PATCH 14/33] IntelFsp2Pkg: " Gary Lin
2016-10-19  7:06   ` Yao, Jiewen
2016-10-19  7:12   ` Mudusuru, Giri P
2016-10-19  7:01 ` [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment Gary Lin
2016-10-19  7:07   ` Yao, Jiewen
2016-10-19  7:11   ` Mudusuru, Giri P
2016-10-19  7:01 ` [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments Gary Lin
2016-10-19  8:20   ` Tian, Feng
2016-10-19  7:01 ` [PATCH 17/33] MdeModulePkg/Bus: " Gary Lin
2016-10-19  7:01 ` [PATCH 18/33] MdeModulePkg/Core: " Gary Lin
2016-10-19  8:20   ` Tian, Feng
2016-10-19  7:01 ` [PATCH 19/33] MdeModulePkg/Include: " Gary Lin
2016-10-19  7:01 ` [PATCH 20/33] MdeModulePkg/Library: Fix typos in comments and variables Gary Lin
2016-10-19  7:01 ` [PATCH 21/33] MdeModulePkg/Universal: Fix typos in comments Gary Lin
2016-10-19  7:01 ` [PATCH 22/33] MdePkg: " Gary Lin
2016-10-19  8:21   ` Gao, Liming
2016-10-19  7:01 ` [PATCH 23/33] NetworkPkg: " Gary Lin
2016-10-19  7:21   ` Fu, Siyuan
2016-10-26  0:53   ` Fu, Siyuan
2016-10-19  7:01 ` [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables Gary Lin
2016-10-19  7:50   ` Ni, Ruiyu
2016-10-19  7:01 ` [PATCH 25/33] OptionRomPkg: Fix typos in comments Gary Lin
2016-10-19  7:51   ` Ni, Ruiyu
2016-10-19  7:01 ` [PATCH 26/33] OvmfPkg: " Gary Lin
2016-10-19  7:01 ` [PATCH 27/33] QuarkPlatformPkg: " Gary Lin
2016-10-25 20:53   ` Kinney, Michael D
2016-10-19  7:01 ` [PATCH 28/33] QuarkSocPkg: " Gary Lin
2016-10-25 21:00   ` Kinney, Michael D
2016-10-19  7:01 ` [PATCH 29/33] SecurityPkg: " Gary Lin
2016-10-27  1:29   ` Zhang, Chao B
2016-11-14  3:12   ` Zhang, Chao B
2016-11-14  4:03     ` Gary Lin
2016-11-14  6:24       ` Gao, Liming
2016-11-14  8:30         ` Gary Lin
2016-10-19  7:01 ` [PATCH 30/33] ShellPkg: Fix typos in comments and variables Gary Lin
2016-10-19  7:51   ` Ni, Ruiyu
2016-10-19 20:29     ` Carsey, Jaben
2016-10-20  1:55       ` Gary Lin
2016-10-19  7:01 ` [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments Gary Lin
2016-10-19  7:46   ` Wu, Hao A
2016-10-19  7:01 ` [PATCH 32/33] UefiCpuPkg: " Gary Lin
2016-10-20  1:58   ` Fan, Jeff
2016-10-20  2:08     ` Gary Lin
2016-10-20  2:45       ` Fan, Jeff
2016-10-19  7:01 ` [PATCH 33/33] Vlv2TbltDevicePkg: " Gary Lin
2016-10-24  1:33   ` Wei, David [this message]
2016-10-19  7:28 ` [PATCH 00/33] Fix typos in comments and variables Zeng, Star
2016-10-19 14:50 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89954A0B46707A448411A627AD4EEE346638F8D8@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox