From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C902C21A18AAA for ; Tue, 18 Apr 2017 01:25:18 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2017 01:25:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,218,1488873600"; d="scan'208";a="78380213" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 18 Apr 2017 01:25:18 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Apr 2017 01:25:17 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.193]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Tue, 18 Apr 2017 16:25:16 +0800 From: "Wei, David" To: "Guo, Mang" , "edk2-devel@lists.01.org" CC: "Lu, ShifeiX A" Thread-Topic: [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue Thread-Index: AdK4AC4xZ2es3pyZR+aoMGsTdXLhRAAHRYmw Date: Tue, 18 Apr 2017 08:25:16 +0000 Message-ID: <89954A0B46707A448411A627AD4EEE3468F28741@SHSMSX101.ccr.corp.intel.com> References: <22D2C85ED001C54AA20BFE3B0E4751D15250364D@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <22D2C85ED001C54AA20BFE3B0E4751D15250364D@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 08:25:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: zwei4 Thanks, David Wei =20 -----Original Message----- From: Guo, Mang=20 Sent: Tuesday, April 18, 2017 12:57 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Lu, ShifeiX A Subject: [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue Debug BIOS will assert if change setup and save. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c | 15 +----------= ---- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSe= tupDxe/SetupInfoRecords.c b/Platform/BroxtonPlatformPkg/Common/PlatformSett= ings/PlatformSetupDxe/SetupInfoRecords.c index d504995..768893e 100644 --- a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/= SetupInfoRecords.c +++ b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/= SetupInfoRecords.c @@ -1808,7 +1808,6 @@ CheckSystemConfigSave ( SEC_INFOMATION SeCInfo; UINT8 SecureBootCfg; UINTN DataSize; - BOOLEAN SecureBootNotFound; =20 Status =3D gBS->LocateProtocol ( &gEfiSeCOperationProtocolGuid, @@ -1831,7 +1830,6 @@ CheckSystemConfigSave ( // Secure Boot configuration changes // DataSize =3D sizeof (SecureBootCfg); - SecureBootNotFound =3D FALSE; Status =3D gRT->GetVariable ( EFI_SECURE_BOOT_ENABLE_NAME, &gEfiSecureBootEnableDisableGuid, @@ -1841,18 +1839,7 @@ CheckSystemConfigSave ( ); =20 if (EFI_ERROR (Status)) { - SecureBootNotFound =3D TRUE; - } - - if (SecureBootNotFound) { - Status =3D gRT->GetVariable ( - EFI_SECURE_BOOT_ENABLE_NAME, - &gEfiSecureBootEnableDisableGuid, - NULL, - &DataSize, - &SecureBootCfg - ); - ASSERT_EFI_ERROR (Status); + SecureBootCfg =3D 0; } =20 if ((SecureBootCfg) !=3D SystemConfigPtr->SecureBoot) { --=20 2.10.1.windows.1